[Bug 24865] New: Customize the Accountlines Description
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Bug ID: 24865 Summary: Customize the Accountlines Description Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: lisetteslatah@gmail.com QA Contact: testopia@bugs.koha-community.org It would be great if we could customize what information was added to the "Description of charges" field when a fine was made so data could be stored even when the item is deleted. For example if you would like to be able to store the home library code, title, and barcode even if the item was deleted, you could have it e entered automatically when the fine was created. This would be very helpful to us. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The information for deleted items is still in Koha - maybe we could solve this without changing the description. It could also avoid display/linking isses. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The main issue I have with the description field is translatability. In the past we often stored strings there that would always remain in English and could not be changed. Nowadays we usually pull the information about the items using the itemnumbers and other identifiers, which is much nicer. But I am still finding things like bug 25596. I am just a little worried this could bring back the old behavior. Maybe we could add additional columns for the information instead? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Maria <mbugz2@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mbugz2@yahoo.com --- Comment #3 from Maria <mbugz2@yahoo.com> --- I can make a solution where the item id that is removed is saved in a new column in accountlines. Addition of functionality in the staff fines view to see owning library etc also for removed items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16461 CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Margaret Hade <margaret@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret@bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 130749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130749&action=edit Bug 24865: Customize the Accountlines Description It would be great if we could customize what information was added to the "Description of charges" field when a fine was made so data could be stored even when the item is deleted. Test Plan: 1) Create an overdue checkout that will get a fine 2) Run fines.pl 3) Note the description for the fine 4) Delete the fine from the database 5) Apply this patch 6) Run updatedatabase.pl 7) Restart all the things! 8) Run fines.pl 9) Note the description of the fine is unchanged 10) Delete the fine again 11) Browse to Slips & Notices 12) Edit the new notice OVERDUE_FINE_DESC You will have access to the objects checkout, item, and borrower 13) Run fines.pl 14) Note your new description was used -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- A very minor quibble, the current behavior is to give the due date including the time. The default notice in this patch calls the due date without the time. It should be changed to maintain current behavior. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130749|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 131286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131286&action=edit Bug 24865: Customize the Accountlines Description It would be great if we could customize what information was added to the "Description of charges" field when a fine was made so data could be stored even when the item is deleted. Test Plan: 1) Create an overdue checkout that will get a fine 2) Run fines.pl 3) Note the description for the fine 4) Delete the fine from the database 5) Apply this patch 6) Run updatedatabase.pl 7) Restart all the things! 8) Run fines.pl 9) Note the description of the fine is unchanged 10) Delete the fine again 11) Browse to Slips & Notices 12) Edit the new notice OVERDUE_FINE_DESC You will have access to the objects checkout, item, and borrower 13) Run fines.pl 14) Note your new description was used Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I have my doubts about whats going on here. Maybe I dont fully understand. [1] Isnt it a very expensive way to go thru notices to concatenate two fields: [% item.biblio.title %] [% checkout.date_due | $KohaDates %] [2] In the description a reference is made to deleted items. If an item is deleted, there is no issue anymore too. I dont see how you create a better description here? Can you explain in which exact situation you reach the else block where you call the letter? (No accountline found, amount>0, item deleted?) Note: commit message refers to item deletion, but test plan does not include it. Changing status: need for feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131286|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133344&action=edit Bug 24865: Customize the Accountlines Description It would be great if we could customize what information was added to the "Description of charges" field when a fine was made so data could be stored even when the item is deleted. Test Plan: 1) Create an overdue checkout that will get a fine 2) Run fines.pl 3) Note the description for the fine 4) Delete the fine from the database 5) Apply this patch 6) Run updatedatabase.pl 7) Restart all the things! 8) Run fines.pl 9) Note the description of the fine is unchanged 10) Delete the fine again 11) Browse to Slips & Notices 12) Edit the new notice OVERDUE_FINE_DESC You will have access to the objects checkout, item, and borrower 13) Run fines.pl 14) Note your new description was used Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- 1 - The idea though is adding the ability to customize which fields are being concatenated there, to allow librarians to add their own values in an understandable format. Additionally, we are now adding the ability to add translation here by getting patron language. I think it is worth the cost for new functionality 2 - The code addresses the creation of new overdue accountlines - the code is hit whenever a new overdue amount is generated. The note about deleted refers to the fact the info like 'Barcode' is calculated on display from information in the accountlines - when an item is deleted that link is broken and that info is not displayed. If [% item.barcode %] is added to the description it will be retained after deletion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, this is clever and I generally like it. It feels like a bit of a hack being in letters/notices though, which is a bit of a shame, but I can appreciate why you added it there. I wonder if this might helpful elsewhere too and a future work might split it out of notices and into a simplified interface a little more like the News and HTML Content stuff.. i.e. without the superfluous transport types handling. We almost need a base class for the template handling and then more specific classes for the use cases like letters/notices vs blocks/pages. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #10)
Hmm, this is clever and I generally like it.
It feels like a bit of a hack being in letters/notices though, which is a bit of a shame, but I can appreciate why you added it there.
I wonder if this might helpful elsewhere too and a future work might split it out of notices and into a simplified interface a little more like the News and HTML Content stuff.. i.e. without the superfluous transport types handling.
We almost need a base class for the template handling and then more specific classes for the use cases like letters/notices vs blocks/pages.
FWIW Bug 27334 adds template toolkit support to news. If that makes it in we could move this template from slips to there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #9)
1 - The idea though is adding the ability to customize which fields are being concatenated there, to allow librarians to add their own values in an understandable format. Additionally, we are now adding the ability to add translation here by getting patron language. I think it is worth the cost for new functionality
2 - The code addresses the creation of new overdue accountlines - the code is hit whenever a new overdue amount is generated. The note about deleted refers to the fact the info like 'Barcode' is calculated on display from information in the accountlines - when an item is deleted that link is broken and that info is not displayed. If [% item.barcode %] is added to the description it will be retained after deletion
Thx. Will finish it this one now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #10)
It feels like a bit of a hack being in letters/notices though, which is a bit of a shame, but I can appreciate why you added it there.
True. We might resolve that with a small follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133344|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133402&action=edit Bug 24865: Customize the Accountlines Description It would be great if we could customize what information was added to the "Description of charges" field when a fine was made so data could be stored even when the item is deleted. Test Plan: 1) Create an overdue checkout that will get a fine 2) Run fines.pl 3) Note the description for the fine 4) Delete the fine from the database 5) Apply this patch 6) Run updatedatabase.pl 7) Restart all the things! 8) Run fines.pl 9) Note the description of the fine is unchanged 10) Delete the fine again 11) Browse to Slips & Notices 12) Edit the new notice OVERDUE_FINE_DESC You will have access to the objects checkout, item, and borrower 13) Run fines.pl 14) Note your new description was used Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 133403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133403&action=edit Bug 24865: (QA follow-up) Remove hardcoded notice name from protected_letters If the letter has been removed, fall back to itemnumber/due date. (Title is no longer fetched.) We may assume that the notice is present. Note: The option to 'protect' a notice may need some more thought. Perhaps it needs to be an attribute on itself. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested by deleting notice, running fines again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good call on QA.. I was about to say, lets be pragmatic and handle follow-ups and follow-ups :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Customize the Accountlines |Customize the accountlines |Description |description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- This new notice is missing from fr-FR/1-Obligatoire/sample_notices.sql Note there is a work in progress Bug 27619 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- At this point in the cycle now I think I'd hold off and push this early next cycle.. I'm going to take another look at bug 27334 to see what's holding it up and as we've got collisions with bug 27619 too I think it's sensible to postpone this one a couple of weeks ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_22_11_candidate |release-notes-needed Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31170 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31170 [Bug 31170] Capitalization: Overdue Item Fine Description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch adds a new release notes| |notice/slip: | |OVERDUE_FINE_DESC | | | |This can | |be used to customize the | |accountlines description | |for overdue fines that can | |access objects for the | |checkout, the item, and the | |borrower -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/632 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34284 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34285 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24865 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40255 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org