[Bug 34041] New: z3950 responder additional options not coming through properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Bug ID: 34041 Summary: z3950 responder additional options not coming through properly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs@lists.koha-community.org Reporter: wizzyrea@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl The z3950 responder default configuration has responder options, but the start script is looking for them in the <config> node, which isn't in the config, so it never finds them if required. Probably we need to fix that, one way or another. :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 --- Comment #1 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 152448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152448&action=edit Bug 34041 - z3950 responder additional options not coming through properly This patch adds the <config> node that the z3950 responder starter script is looking for in the z3950/config.xml to the example code. To test: - verify that the <config> </config> is around the commented z3950_additional_options suggestion in the etc/z3950/config.xml file - bonus points, uncomment it and make sure you can start/stop/restart koha-z3950-responder with the example config. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |wizzyrea@gmail.com |ity.org | CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Added assignee. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. If I manually add the change to /etc/koha/sites/kohadev/z3950/config.xml and restart, I get some errors. I think the last config needs to be </config>? So this should be: <config> <z3950_responder_options>\-\-add-item-status k -t 5</z3950_responder_options> </config> 2. However, if I do that, then I can't get the z3950 responder to start using restart_all - get this: ... Error: Z39.50/SRU not running for kohadev: failed! ... I don't know enough about the Z3950 responder to test if it is running properly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152448|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164150&action=edit Bug 34041 - z3950 responder additional options not coming through properly This patch adds the <config> node that the z3950 responder starter script is looking for in the z3950/config.xml to the example code. To test: - verify that the <config> </config> is around the commented z3950_additional_options suggestion in the etc/z3950/config.xml file - copy the config stanza to the live file: /etc/koha/sites/kohadev/z3950/config.xml - restart_all - ps aux | grep z3950 - confirm the script has restarted - confirm the options: --add-item-status k -t 5 have been passed through -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164150|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 164152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164152&action=edit Bug 34041 - z3950 responder additional options not coming through properly This patch adds the <config> node that the z3950 responder starter script is looking for in the z3950/config.xml to the example code. To test: - verify that the <config> </config> is around the commented z3950_additional_options suggestion in the etc/z3950/config.xml file - copy the config stanza to the live file: /etc/koha/sites/kohadev/z3950/config.xml - restart_all - ps aux | grep z3950 - confirm the script has restarted - confirm the options: --add-item-status k -t 5 have been passed through Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.blouin@inlibro.com --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if that could explain part of the problems dicussed on mailing list lately? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |hammat.wele@inlibro.com --- Comment #7 from Blou <philippe.blouin@inlibro.com> --- Hammat, could you look at this -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164152|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166540&action=edit Bug 34041: z3950 responder additional options not coming through properly This patch adds the <config> node that the z3950 responder starter script is looking for in the z3950/config.xml to the example code. To test: - verify that the <config> </config> is around the commented z3950_additional_options suggestion in the etc/z3950/config.xml file - copy the config stanza to the live file: /etc/koha/sites/kohadev/z3950/config.xml - restart_all - ps aux | grep z3950 - confirm the script has restarted - confirm the options: --add-item-status k -t 5 have been passed through Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 166542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166542&action=edit Bug 34041: (follow-up) escape double dashes to prevent issues Having double dashes inside a commmented block is not valid XML. This patch restores it, with an added message explaining it To test: 1. Run: $ xmllint etc/z3950/config.xml => FAIL: You get: etc/z3950/config.xml:5: parser error : Double hyphen within comment: <!-- <config> <z3950_responder_options> <z3950_responder_options>--add-item-status k -t 5</z3950_responder_options 2. Apply this patch 3. Repeat 1 => SUCCESS: All good! Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should this be re-classified as a bug (not an enh)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34041 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #14 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org