https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |tomascohen@gmail.com Status|NEW |Needs Signoff Depends on| |33169, 32925, 33066 Blocks| |31791 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31791 [Bug 31791] Add the ability to lock records to prevent modification through the Koha staff interface(s) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32925 [Bug 32925] Display loading info when a form is submitted https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33066 [Bug 33066] We need a KohaTable Vue component https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 [Bug 33169] Improve vue breadcrumbs and left-hand menu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 161531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161531&action=edit Bug 35919: DB changes This patch adds: * A new table: `record_sources`. * A new user permission: `manage_record_sources`. * A FK on record_sources.recour_source_id on the biblio_metadata tables Record sources will contain a name and (for now) a flag telling if records from the specific source can be manually edited. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 161533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161533&action=edit Bug 35919: Add /record_sources endpoints This patch introduces endpoints for managing record sources. This is done on top of Koha::RecordSource(s) following the current coding style. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/record_sources.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 161535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161535&action=edit Bug 35919: DBIC schema [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 161538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161538&action=edit Bug 35919: Add cypress tests This patch adds Cypress tests for the `record sources` CRUD as required by QA. I tried to cover all the UI interactions and behaviours. To test: 1. Have all the patches applied 2. Run: $ ktd --shell k$ cypress run --spec t/cypress/integration/Admin/RecordSources_spec.ts => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161531|0 |1 is obsolete| | --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 161577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161577&action=edit Bug 35919: DB changes This patch adds: * A new table: `record_sources`. * A new user permission: `manage_record_sources`. * A FK on record_sources.recour_source_id on the biblio_metadata tables Record sources will contain a name and (for now) a flag telling if records from the specific source can be manually edited. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161533|0 |1 is obsolete| | --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 161579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161579&action=edit Bug 35919: Add /record_sources endpoints This patch introduces endpoints for managing record sources. This is done on top of Koha::RecordSource(s) following the current coding style. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/record_sources.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161535|0 |1 is obsolete| | --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 161581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161581&action=edit Bug 35919: DBIC schema [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161538|0 |1 is obsolete| | --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 161583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161583&action=edit Bug 35919: Add cypress tests This patch adds Cypress tests for the `record sources` CRUD as required by QA. I tried to cover all the UI interactions and behaviours. To test: 1. Have all the patches applied 2. Run: $ ktd --shell k$ cypress run --spec t/cypress/integration/Admin/RecordSources_spec.ts => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #0)

This bug replaces bug 32607 (it will be closed) in order to make it easier to track things.

Easier by hiding the history?... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #17)

(In reply to Tomás Cohen Arazi from comment #0)

...

This bug replaces bug 32607 (it will be closed) in order to make it easier to track things.

Easier by hiding the history?...

- Some generalizations got dropped. - Some generalizations were taken care of on separate bugs already in master. - Some features were simplified to make this easier to match the client's MVP, and future enhancements will be dealt with on follow-up bugs in which pertinent discussions can take place in a better way. I think that's the best way to do it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162594&action=edit Bug 35919: Fix label for 'can be edited' checkbox -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 162596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162596&action=edit Bug 35919: Adjust RewriteRule to match existing ones -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I don't understand why you stubborn and obstinate to do things differently. I have said that 10x on bug 32607, then here again. 1. computed title instead of the logic in template 2. retrieving the client api from setup() 3. _has_value should not be needed, we have form validation already 4. you should clean the api-client, why do you deal with headers and json stringify? we don't need it in other places! 5. in the routes: BeforeUnloadEvent() { window.location.href = "/cgi-bin/koha/admin/admin-home.pl"; }, Why? 6. Why do you name the add/edit component "Edit" when all others are named "AddForm"? 7. Why calling the client api this way: .then(() => something()) when all existing occurrences do: .then( success => something(), error => {}, ); 8.Edit.vue Object.keys(response).forEach(key => { this.row[key] = response[key] }) What's the point of this?? Some are blocker, some are weirdness, others are better than what exist but different. I let you decide the status of this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #24)

I don't understand why you stubborn and obstinate to do things differently. I have said that 10x on bug 32607, then here again.

Maybe because some things didn't exist when this was submitted in the first place? Or maybe some things were rewritten by the time this got (finally) some eyes on it. I really thought I had covered all the remaining things. I removed all of the contentious snippets. I will try to understand your concerns. Vue is not my whellhouse. This is the first time I work with Vue, trying to help someone else's dev to move forward. And even learnt Cypress and wrote the darn tests for a trivial CRUD page!

1. computed title instead of the logic in template 2. retrieving the client api from setup() 3. _has_value should not be needed, we have form validation already 4. you should clean the api-client, why do you deal with headers and json stringify? we don't need it in other places! 5. in the routes: BeforeUnloadEvent() { window.location.href = "/cgi-bin/koha/admin/admin-home.pl"; }, Why? 6. Why do you name the add/edit component "Edit" when all others are named "AddForm"?

7. Why calling the client api this way: .then(() => something()) when all existing occurrences do: .then( success => something(), error => {}, ); 8.Edit.vue Object.keys(response).forEach(key => { this.row[key] = response[key] }) What's the point of this??

Some are blocker, some are weirdness, others are better than what exist but different.

I let you decide the status of this.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- If no one beats me to it, will be looking here "soon" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #28)

If no one beats me to it, will be looking here "soon"

I will try to address Jonathan's QA concerns. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #31 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163349&action=edit Bug 35919: Add Koha::RecordSource(s) classes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163351&action=edit Bug 35919: Add record sources admin page This patch introduces a Vue.js based record sources managing page. To test it: 1. Apply this patch 2. Build the Vue.js stuff: $ ktd --shell k$ yarn js:build k$ restart_all 3. On the staff interface, go to Administration > Record sources 4. Play with the interface and the offered actions => SUCCESS: Things go well 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #35 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163353&action=edit Bug 35919: Add Koha::Biblio::Metadata->can_be_edited prove t/db_dependent/Koha/Biblio/Metadata.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 163355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163355&action=edit Bug 35919: Add superlibrarian permission to Permissions.t Permissions.t was failing when running a jenkins build to another branch with this bug applied. Permissions.t was missing the permission for record sources and is now added in this patch Test plan: 1) prove t/Koha/Auth/Permissions.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Marking NSO again, as I rewrote most of the Vue part of this dev. Some things I'm not comfortable with, but happy to follow the current standard practice for now, and evolve later. I kept the URL rewrite rule we originally submitted. I think requiring the trailing slash (/) if my rewrite avoids it, doesn't make sense. I can submit a bug for redoing the rest of the rewrites this way if required by QA (if this applies, as I'm not familiar with the little details the other modules might have making them requiring this). I also liked it more when the API client was instantiated globally instead on each place it is used. As it is a stateless object it should cause no issues. I moved it to match the current practice and will file a separate bug to restore the original implementation and discuss it in place. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #41 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. Create a record source, edit it Modify the name h1 is getting modified. I don't think it's expected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #43 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163390&action=edit Bug 35919: Fix cypress tests And remove "remove", "delete" inconsistency -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163348|0 |1 is obsolete| | Attachment #163349|0 |1 is obsolete| | Attachment #163350|0 |1 is obsolete| | Attachment #163351|0 |1 is obsolete| | Attachment #163352|0 |1 is obsolete| | Attachment #163354|0 |1 is obsolete| | Attachment #163360|0 |1 is obsolete| | Attachment #163369|0 |1 is obsolete| | Attachment #163389|0 |1 is obsolete| | Attachment #163390|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163391&action=edit Bug 35919: DB changes This patch adds: * A new table: `record_sources`. * A new user permission: `manage_record_sources`. * A FK on record_sources.recour_source_id on the biblio_metadata tables Record sources will contain a name and (for now) a flag telling if records from the specific source can be manually edited. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #46 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163393&action=edit Bug 35919: Add /record_sources endpoints This patch introduces endpoints for managing record sources. This is done on top of Koha::RecordSource(s) following the current coding style. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/record_sources.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #48 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163395&action=edit Bug 35919: DBIC schema [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #50 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163397&action=edit Bug 35919: Add superlibrarian permission to Permissions.t Permissions.t was failing when running a jenkins build to another branch with this bug applied. Permissions.t was missing the permission for record sources and is now added in this patch Test plan: 1) prove t/Koha/Auth/Permissions.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #52 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 163399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163399&action=edit Bug 35919: Adjust h1 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |jonathan.druart@gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- If it's not already, we should document how to setup editors for these prettier styling requirements. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #57 from Jonathan Druart <jonathan.druart@gmail.com> --- It's actually splitting because the line is longer I guess. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #59 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #39)

Marking NSO again, as I rewrote most of the Vue part of this dev.

Some things I'm not comfortable with, but happy to follow the current standard practice for now, and evolve later.

I kept the URL rewrite rule we originally submitted. I think requiring the trailing slash (/) if my rewrite avoids it, doesn't make sense.

I can submit a bug for redoing the rest of the rewrites this way if required by QA (if this applies, as I'm not familiar with the little details the other modules might have making them requiring this).

I also liked it more when the API client was instantiated globally instead on each place it is used. As it is a stateless object it should cause no issues. I moved it to match the current practice and will file a separate bug to restore the original implementation and discuss it in place.

Thanks everyone!

Did you open the bugs? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163392|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164709&action=edit Bug 35919: Add Koha::RecordSource(s) classes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163394|0 |1 is obsolete| | --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164711&action=edit Bug 35919: Add record sources admin page This patch introduces a Vue.js based record sources managing page. To test it: 1. Apply this patch 2. Build the Vue.js stuff: $ ktd --shell k$ yarn js:build k$ restart_all 3. On the staff interface, go to Administration > Record sources 4. Play with the interface and the offered actions => SUCCESS: Things go well 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163396|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164713&action=edit Bug 35919: Add cypress tests This patch adds Cypress tests for the `record sources` CRUD as required by QA. I tried to cover all the UI interactions and behaviours. To test: 1. Have all the patches applied 2. Run: $ ktd --shell k$ cypress run --spec t/cypress/integration/Admin/RecordSources_spec.ts => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163398|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164715&action=edit Bug 35919: Add Koha::Biblio::Metadata->source_allows_editing This patch adds a convenient method that tells if the record is editable, according to it's record source. To test: 1. Apply this patch 2. Run: $ ktd k$ prove t/db_dependent/Koha/Biblio/Metadata.t => SUCCESS: Tests pass! Use cases covered! 3. Sign off :-D Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Bug 31791: Rename can_be_edited -> source_allows_editing Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163400|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164717&action=edit Bug 35919: Fix cypress tests And remove "remove", "delete" inconsistency Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate Status|Passed QA |Failed QA --- Comment #70 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, some very small issues, but also a bigger one I couldn't get around (5): 1) Page title We since changed the markup there for better translatability among other things. Please adapt: +<title> + Record sources › Koha +</title> 2) Missing permissions.inc Guess everyone has only been testing as a superlibrarian again? ;) Wanted to fix in a follow-up, but got stuck on 5) :( 3) Reconsider sequence on admin page Currently this shows as the last entry below the Elasticsearch config, but I feel it would be better suited with the matching/overlay rules, what do you think? 4) Missing from side navigation The left hand admin navigation panel was missed. Sequence should match admin page, so good to do 3) first :) 5) Apache config? When trying to access the admin/record_sources I have a 404 error. I tried yarn build, restart_all and reset_all. I figure this line here might not be right? RewriteRule ^/cgi-bin/koha/admin/record_sources(.*)?$ /cgi-bin/koha/admin/record_sources.pl$1 [PT] I verified it showed in /etc/koha/apache-shared-intranet.conf -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #73 from Kyle M Hall <kyle@bywatersolutions.com> ---

5) Apache config?

When trying to access the admin/record_sources I have a 404 error.

I applied the patch, did a restart_all, and it looks to be working for me! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 --- Comment #74 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36372 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37419 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37419 [Bug 37419] Deleting the record source deletes the associated biblio_metadata rows. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35919 Bug 35919 depends on bug 33169, which changed state. Bug 33169 Summary: Improve vue breadcrumbs and left-hand menu https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33169 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.