[Bug 35425] New: Sortable prevents mouse selection of text inside child input/textarea elements
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Bug ID: 35425 Summary: Sortable prevents mouse selection of text inside child input/textarea elements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: slavashishkin@gmail.com Reporter: slavashishkin@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Depends on: 35383 To reproduce: 1. Open any biblio and edit that record. (select "Edit record" from the "Edit" drop-down menu). 2. Check that selecting the text in any draggable block input/textarea fields with a mouse is not possible - it starts dragging instantly. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 [Bug 35383] Dragging and dropping subfield of repeated tags doesn't work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 --- Comment #1 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 159313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159313&action=edit Bug 35425: Optimize UX when dragging a Tag or Subfield To reproduce: 1. Open any biblio and edit that record. (select "Edit record" from the "Edit" drop-down menu). 2. Check that selecting the text in any draggable block input/textarea fields with a mouse is not possible - it starts dragging instantly. 3. Apply the patch 4. Make sure that draging is activated only when you click on the "::" icon in front of the dragged item. And text selection works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159313|0 |1 is obsolete| | --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 159379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159379&action=edit Bug 35425: Optimize UX when dragging a Tag or Subfield To reproduce: 1. Open any biblio and edit that record. (select "Edit record" from the "Edit" drop-down menu). 2. Check that selecting the text in any draggable block input/textarea fields with a mouse is not possible - it starts dragging instantly. 3. Apply the patch 4. Make sure that draging is activated only when you click on the "::" icon in front of the dragged item. And text selection works correctly. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159379|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 159426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159426&action=edit Bug 35425: Optimize UX when dragging a Tag or Subfield To reproduce: 1. Open any biblio and edit that record. (select "Edit record" from the "Edit" drop-down menu). 2. Check that selecting the text in any draggable block input/textarea fields with a mouse is not possible - it starts dragging instantly. 3. Apply the patch 4. Make sure that draging is activated only when you click on the "::" icon in front of the dragged item. And text selection works correctly. Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- More a bug than an enh! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This fixes the buggy behavior, but in testing this I feel like we might think about improving UX a bit more (on a separate bug). I believe that our drag & drop is not very accessible and a little hard to handle when you are on a slow system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Patch complexity|--- |Small patch Version(s)|24.05.00 |24.05.00,23.11.01 released in| | --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Bug 35425 depends on bug 35383, which changed state. Bug 35383 Summary: Dragging and dropping subfield of repeated tags doesn't work https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35383 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35425 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Missing dependencies for 23.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org