https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32084 Bug ID: 32084 Summary: GetMaxPatronHoldsForRecord is incorrect and inefficient Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com This routine claims to return the max number of holds a patron can place on a record, however, it does not take into account whether a patron can hold an itemtype or not, so may be inflating the maximum number when the patron cannot in fact hold those items Additionally, the routine makes a call for effective circulation rule per item. We really only need to call once per itemtype and branch combination - if reserves control branch is 'patrons library' then it is really only once per itemtype on the biblio -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.