https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72048|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 72049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72049&action=edit Bug 20264: Remove syspref checkdigit According to http://irc.koha-community.org/koha/2013-06-26#i_1333289 http://irc.koha-community.org/koha/2013-06-26#i_1333589 and Hea data, this syspref is no longer in used and is always set to false. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan@calyx.net.au --- Comment #3 from Dilan Johnpullé <dilan@calyx.net.au> --- Patch failed to apply with the following error message: vagrant@kohadevbox:kohaclone(master)$ git bz apply -s 20264 Bug 20264 - Syspref checkdigit is no longer in used 72049 - Bug 20264: Remove syspref checkdigit Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 20264: Remove syspref checkdigit fatal: sha1 information is lacking or useless (C4/Members.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 20264: Remove syspref checkdigit The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-20264-Remove-syspref-checkdigit-H8JTSx.patch vagrant@kohadevbox:kohaclone(master|AM 1/1)$ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #4)

According to http://irc.koha-community.org/koha/2013-06-26#i_1333289 http://irc.koha-community.org/koha/2013-06-26#i_1333589 and Hea data, this syspref is no longer in used and is always set to false.

Does this provide enough evidence? Can we make some more noise on the mailing lists(?) in order to let people step up and say Hey I am still using that? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 --- Comment #8 from Dilan Johnpullé <dilan@calyx.net.au> --- (In reply to Dilan Johnpullé from comment #7)

Created attachment 72396 [details] [review] Bug 20264: Remove syspref checkdigit

According to http://irc.koha-community.org/koha/2013-06-26#i_1333289 http://irc.koha-community.org/koha/2013-06-26#i_1333589 and Hea data, this syspref is no longer in used and is always set to false.

Patch applies now and works as expected.

Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72396|0 |1 is obsolete| | --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 72406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72406&action=edit Bug 20264: Remove syspref checkdigit According to http://irc.koha-community.org/koha/2013-06-26#i_1333289 http://irc.koha-community.org/koha/2013-06-26#i_1333589 and Hea data, this syspref is no longer in used and is always set to false. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20396 CC| |gaetan.boisson@biblibre.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20396 [Bug 20396] Omnibus: Koha Cleanup -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20264 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, not backported for 17.11 -- You are receiving this mail because: You are watching all bug changes.