https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 58826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58826&action=edit Bug 17884 - troubles with syspref AllowHoldPolicyOverride on return Test plan : 1° with syspref AllowHoldPolicyOverride O. 2° in "Holds policy by item type" (in smart-rules.pl) with "no holds allowed" selected for an itype. 3° create an hold on an item of this ityp. 4° return this ite. 5° you have no message about the hold and the hold is not in status waitin, due to the lack of the check about the syspref during the check in. 6Â with this patch you get the message about the existing hold. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58826|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 59001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59001&action=edit Bug 17884 - troubles with syspref AllowHoldPolicyOverride on return Test plan : 1° with syspref AllowHoldPolicyOverride O. 2° in "Holds policy by item type" (in smart-rules.pl) with "no holds allowed" selected for an itype. 3° create an hold on an item of this ityp. 4° return this ite. 5° you have no message about the hold and the hold is not in status waitin, due to the lack of the check about the syspref during the check in. 6Â with this patch you get the message about the existing hold. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Linking some other bugs to this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org --- Comment #5 from Chris Slone <cslone@camdencountylibrary.org> --- I applied this patch and tested it as follows: 1 syspref: AllowHoldPolicyOverride - Allow. 2 created an item type with No holds Allowed defined in its Hold Policy 3 created a hold on an item with the above item type 4 checked in the item 5 the hold was found and was able to be confirmed The problem was that it if you have holdable and non-holdable item types on the same record (say a library use only copy of a book that is defined by its own item type), the item with the non-holdable item type will fulfill any biblio-level hold, which essentially negates the no-holds allowed property entirely. So it works, but nor quite as I expected it. Is it possible to specify that the hold should only be fulfilled if it is an item level request (perhaps this would best be split to a different bug...)? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17884 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE CC| |andrew@bywatersolutions.com --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Bug 20955 seeks to address this issue as well and has a more recent patch on it, but is stuck on the same issue Chris noted in the last comment here. *** This bug has been marked as a duplicate of bug 20955 *** -- You are receiving this mail because: You are watching all bug changes.