[Bug 43963] New: Round fines when charged and retire the RoundFinesAtPayment tolerance
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43963 Bug ID: 43963 Summary: Round fines when charged and retire the RoundFinesAtPayment tolerance Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Depends on: 43960 Blocks: 23728 Target Milestone: --- Round fines when they are charged and retire the RoundFinesAtPayment tolerance. Part of the currency rounding work collected on bug 23728; intended to come last in the series. Fines can be stored with fractions of a unit (see bug 27054), and RoundFinesAtPayment (members/paycollect.pl) only forgives differences under 0.01 at payment time, which can leave partial-cent credits (bug 24655). Only whole currency units can change hands. Proposed: fines are rounded at currency precision when charged, using the income rounding preferences, and RoundFinesAtPayment is deprecated. Needs a documented migration for sites with fractional fine rates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23728 [Bug 23728] Rounding code should be moved to a Koha module so code can be centralised https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43960 [Bug 43960] Round account line amounts at write time per income rounding preferences -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43963 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43963 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |43961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43961 [Bug 43961] POS accepts prices and quantities that produce fractions of a penny -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43963 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|43960 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43960 [Bug 43960] Round account line amounts at write time per income rounding preferences -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43963 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 210180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210180&action=edit Bug 43963: Retire RoundFinesAtPayment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43963 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43963 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #210180|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43963 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 210181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210181&action=edit Bug 43963: Round fines when they are calculated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43963 --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 210182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=210182&action=edit Bug 43963: Retire RoundFinesAtPayment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43963 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- These patches round fines once, when they are calculated, and retire RoundFinesAtPayment. CalcFine rounds the fine after the fines cap and the replacement price cap, using the currency decimal digits and IncomeRoundingMode. UpdateFine rounds the amount it receives before applying MaxFine and compares rounded values, so a fine that has not changed once rounded no longer gets a new 'overdue_update' offset each time fines.pl runs. Migration: the atomic update deletes RoundFinesAtPayment. Only sites with fractional fine rates (for example 0.275 per day) are affected. Charges recorded before this change may keep fractions of the smallest currency unit. The payment screen warns when the amount due has such a fraction, and points to misc/maintenance/round_account_lines.pl, which is Bug 43964. Test plan is in the commit messages. Depends on 43960 and 43961. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org