[Bug 14204] New: Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Bug ID: 14204 Summary: Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: nick@quecheelibrary.org QA Contact: gmcharlt@gmail.com Bug 12991 altered the creation of label batches such that the batch_id is set at 0 until items are added. The variable in the tests was set at batch creation and not updated after items were added to test batch and this led to failing tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 --- Comment #1 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 39203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39203&action=edit Bug 14204 - Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991 This patch updaes the batch_id variable after items are added to test batch To test: 1. prove t/db_dependent/Labels/t_Batch.t and see two tests fail 2. apply patch 3. prove again, tests pass! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Bug 12991 has no patches on it, and it is set to NEW. prove t/db_dependent/Labels/t_Batch.t works in master fine. Granted I have no labels. Do you? I'm trying to see why this is a problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix |Fix |t/db_dependent/Labels/t_Bat |t/db_dependent/Labels/t_Bat |ch.t failing test from Bug |ch.t failing test from Bug |12991 |12911 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39203|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39213&action=edit Bug 14204 - Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991 This patch updaes the batch_id variable after items are added to test batch To test: 1. prove t/db_dependent/Labels/t_Batch.t and see two tests fail 2. apply patch 3. prove again, tests pass! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: The $batch->add_item() call to C4::Creators::Batch::add_item triggers the change of the batch_id so this line is necessary! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12911 CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39213|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 39217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39217&action=edit [PASSED QA] Bug 14204: Fix t/db_dependent/Labels/t_Batch.t failing test from Bug 12991 This patch updaes the batch_id variable after items are added to test batch To test: 1. prove t/db_dependent/Labels/t_Batch.t and see two tests fail 2. apply patch 3. prove again, tests pass! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: The $batch->add_item() call to C4::Creators::Batch::add_item triggers the change of the batch_id so this line is necessary! Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 39218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39218&action=edit Bug 14204: (QA followup) remove unneeded messages Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Nick for this quick response! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39218|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 39219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39219&action=edit Bug 14204: (QA followup) remove unneeded messages TEST PLAN --------- 1) Apply first patch 2) prove -v t/db_dependent/Labels/t_Batch.t -- YUCK! No meaningful messages on a lot of the ok's. 3) Apply this patch 4) prove -v t/db_dependent/Labels/t_Batch.t -- YAY! Meaningful test results 5) koha qa test tools Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14204 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org