[Bug 26698] New: Hold can show as waiting and in transit at the same time
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Bug ID: 26698 Summary: Hold can show as waiting and in transit at the same time Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If a hold is requested, checked in at another branch, set to transit, then checked in but ignored at the receiving branch it can appear incorrectly on request.pl as the code checks: 1 - That there are no transfers 2 - That the items holding branch is the same as the request branch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 111789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111789&action=edit Bug 26698: Use is_at_destination to determine if hold is at destination This copies code from bug 12556 and uses a Koha::Hold method rather than code in script TO test: 1 - Place a hold for item from library B for delivery at library A 2 - Check the item in at library B, confirm and transfer 3 - Check item in at Library A but ignore the hold 4 - View the Holds tab of the details page: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=6 5 - Priority = "In transit" Pickup Library = "Item waiting at" 6 - Apply patch 7 - Restart all the thigns 8 - Reload the page 9 - Priority="In transit" and Pickup library="Item being transferred" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.11 |20.05 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- *** Bug 26105 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #3 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Tried twice the test plan and at step 5 didn't got the issue. But got «Priority="In transit" and Pickup library="Item being transferred"» Does the issue still happens? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #3)
Tried twice the test plan and at step 5 didn't got the issue. But got «Priority="In transit" and Pickup library="Item being transferred"»
Does the issue still happens?
Are you testing on 20.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- :o I missed that, thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111789|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 114486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114486&action=edit Bug 26698: Use is_at_destination to determine if hold is at destination This copies code from bug 12556 and uses a Koha::Hold method rather than code in script TO test: 1 - Place a hold for item from library B for delivery at library A 2 - Check the item in at library B, confirm and transfer 3 - Check item in at Library A but ignore the hold 4 - View the Holds tab of the details page: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=6 5 - Priority = "In transit" Pickup Library = "Item waiting at" 6 - Apply patch 7 - Restart all the thigns 8 - Reload the page 9 - Priority="In transit" and Pickup library="Item being transferred" Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- It works! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114486|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 115019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115019&action=edit Bug 26698: Use is_at_destination to determine if hold is at destination This copies code from bug 12556 and uses a Koha::Hold method rather than code in script TO test: 1 - Place a hold for item from library B for delivery at library A 2 - Check the item in at library B, confirm and transfer 3 - Check item in at Library A but ignore the hold 4 - View the Holds tab of the details page: http://localhost:8081/cgi-bin/koha/reserve/request.pl?biblionumber=6 5 - Priority = "In transit" Pickup Library = "Item waiting at" 6 - Apply patch 7 - Restart all the thigns 8 - Reload the page 9 - Priority="In transit" and Pickup library="Item being transferred" Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Trivial fix, works as expected.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sending to RM 20.05 queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26698 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org