[Bug 9995] New: For reference items no longer listed in XSLT result lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 Bug ID: 9995 Summary: For reference items no longer listed in XSLT result lists Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: regression Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de CC: kyle@bywatersolutions.com For reference items (itemtype = not for loan) no longer show up in OPAC result lists with MARC21 and XSLT. This was caused by the change for bug 5079. commit 43c875b6834cac7242bf27547c840338e628c8b8 http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=koha-tmpl/opac... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6886 Depends on| |5079 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17288&action=edit Bug 9995 - For reference items no longer listed in XSLT result lists Re-added the xsl that shouldn't have been removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- This patch lacks a test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #2)
This patch lacks a test plan.
I also see some code at the end of the xslt referring to item-status reference and doing things with OPACItemLocation pref. But the not-for-loan item I added does not appear in the Location line of the opac results? Your patch does show the reference item again in the Availability line. But it makes a bad pair for OPACItemLocation<>callnumber for some reason.. Leaving it at Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marcel, did you add the not for loan status to the item or to the itemtype? I am sure that itemtype status used to show up for reference, but not sure about item level not for loan. Adding the not for loan to the itemtype works nicely for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marcel, I wanted to see if I could fix the problem you describe, but I am not able to reproduce it. :( I have tested with the 2 possible ways to set an item not for loan: - marking the item type not for loan - marking the item not for loan For both the counts and display seem to be restored now to the former functionality. But I agree that there is something odd about the behaviour introduced by 5078. Problems I encountered were: 1) I get a lot of results with Location(s): without any information. 2) In one case I get only the callnumber, but no location or collection. I think the problem is, that I have not consistently cataloged locations and collections. Some items have one, some both, some none of those. And that throws the display off. But: I see that with and without this patch being applied, so it seems like a partial fix to me that doesn't make things worse. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17434&action=edit [SIGNED OFF] Bug 9995 - For reference items no longer listed in XSLT result lists Re-added the xsl that shouldn't have been removed. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with different settings for OpacItemLocation and not for loan set in the item and for the item type. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17288|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, guess I should have added a test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I was looking again a few moments :) But I still have my doubts over this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree there is something wrong with the feature. I was only questioning if this made it worse or a little bit better. This is quite a big bug for at least one of our libraries. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Working on a followup for this.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17434|0 |1 is obsolete| | --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17508&action=edit Bug 9995 - For reference items no longer listed in XSLT result lists Re-added the xsl that shouldn't have been removed. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with different settings for OpacItemLocation and not for loan set in the item and for the item type. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Including a QA followup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17509&action=edit 9995 Followup for Availability Replacing erroneous code trying to mix information from two levels (item level and branch level) by simpler numbers per status. The callnumber information should follow on the Location line. Fixing this in a second followup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17510&action=edit Bug 9995: Followup for Location line Simplifying erroneous code mixing information from two levels. Takes into account Singlebranchmode. All items, available or for reference, are shown on this line. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Have tried to simplify the code which obviously contained some bugs handling branch level and item level data. Also some when's should have been if's (if A and B are true, when A when B does not work.) The Available line now contains just numbers per status. The Location line respects OPACItemLocation and SingleBranchMode. And shows only available/reference items. Following considerations remain: The difference between Available and Reference is lost on Location line. Does that really matter? We do not provide status numbers per branch. IMO better than providing erroneous or incomplete results. Would appreciate an additional signoff from Katrin or Kyle. After that we can switch to Passed QA imo. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Forgetting still another one: If OPACItemLocation=field A but field A is blank. We now produce silly output. How should we resolve that? Exclude this item or fall back to another field (B or C), or .. ? Ideas are welcome.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marcel, thx for your work on this! I will be travelling from tomorrow to Sunday, so won't have time for testing before next week. Reading throuch your commit message I was wondering about 2 things:
The Available line now contains just numbers per status.
I am a bit worried about this, does it mean we don't show the callnumber for available and reference items anymore? Also, how do you define branch level/item level information? I think understanding how this is supposed to work will help testing :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #17 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #16) Hi Katrin,
I am a bit worried about this, does it mean we don't show the callnumber for available and reference items anymore?
The call number goes to the Location line, but this depends on OPACItemLocation.
Also, how do you define branch level/item level information? I think understanding how this is supposed to work will help testing :)
In the code was a test with generate-id to select one item per branch (branch level) but later on callnumber was inserted as if we were on item level, resulting in the listing of one callnumber per branch while there could be more.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17510|0 |1 is obsolete| | --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17519&action=edit Bug 9995: Followup for Location line Simplifying erroneous code mixing information from two levels. Takes into account Singlebranchmode. All items, available or for reference, are shown on this line. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #19 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #15)
If OPACItemLocation=field A but field A is blank. We now produce silly output. How should we resolve that? Exclude this item or fall back to another field (B or C), or .. ? Ideas are welcome..
Just looked a little bit more. Restored behavior of preceding ccode or location before call number. So, now my question becomes more hypothetical: Show what if location and callnumber are empty? Amended the last followup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10073 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #20 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Added a related patch under bug 10073. Have fun :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #21 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Do you know if this problem exists with UNIMARC ? M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #21)
Do you know if this problem exists with UNIMARC ?
Hm. A look in the UNIMARC counterpart shows me that the pref OPACItemLocation is not there. But I do see the construction with generate-id followed by an itemcallnumber. So please check if you can replicate this: Have a biblio with multiple items. Check if available count is correct. If available>1, please check if all call numbers are listed. Looks to me that you will only see one. Same for items with status reference (Not-for-loan). If you confirm the bug, please open a new report for UNIMARC. Thanks.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #23 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Additionally: If you have both items on available and reference, you will have incomplete results due to the construction with When's.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #24 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- BZ 5079 only changed XSLT file for MARC21... So a followup of 5079 for unimarc is needed. And this followup must take into account BZ9995. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #25 from M. de Rooy <m.de.rooy@rijksmuseum.nl> ---
From IRC:
cait>: marcelr: the referece bug is a bit monstrous now too <marcelr>: monstrous? <cait>: marcelr: I think it was by design to only display one callnumber for each <marcelr>: sounds odd to me <cait>: marcelr: because we for example have individual callnumbers for each item around here <cait>: think serials <cait>: with 120 items with unique callnumbers <marcelr>: fun <cait>: it's always been like that <cait>: the result list would be exploding -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #26 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- As we concluded on IRC, the followups go somewhere else :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17509|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17519|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #27 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 17523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17523&action=edit Bug 9995 - For reference items no longer listed in XSLT result lists Re-added the xsl that shouldn't have been removed. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with different settings for OpacItemLocation and not for loan set in the item and for the item type. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17508|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #28 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: I am not spending much more time on this. If bug 5079 is not reverted, this could improve things. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 --- Comment #29 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Ok, so I will fill an other bug for the unimarc followup when BZ9995 is pushed. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9995 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #30 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org