[Bug 21715] New: Ease translation of account and account offset type descriptions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Bug ID: 21715 Summary: Ease translation of account and account offset type descriptions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Both are now on separate files and descriptions are not enclosed by <span> tags, making it more error prone on the translation step. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 81519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81519&action=edit Bug 21715: Ease translation of account and account offset type descriptions This patch moves accounts-related descriptions into a single file to ease finding them, and also encloses descriptions inside <span> tags to make it easier to translate. To test: - Apply this patch - Verify the templates work as expected => SUCCESS: No behaviour change - Sign off :-D Bonus: there were two cases in which the INCLUDE line used 'accountline' as parameter, making it fail to pick the right account type! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81519|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 81524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81524&action=edit Bug 21715: Ease translation of account and account offset type descriptions This patch moves accounts-related descriptions into a single file to ease finding them, and also encloses descriptions inside <span> tags to make it easier to translate. To test: - Apply this patch - Verify the templates work as expected => SUCCESS: No behaviour change - Sign off :-D Bonus: there were two cases in which the INCLUDE line used 'accountline' as parameter, making it fail to pick the right account type! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 [Bug 21584] Wrong offset type for Lost Item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81524|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81544&action=edit Bug 21715: Ease translation of account and account offset type descriptions This patch moves accounts-related descriptions into a single file to ease finding them, and also encloses descriptions inside <span> tags to make it easier to translate. To test: - Apply this patch - Verify the templates work as expected => SUCCESS: No behaviour change - Sign off :-D Bonus: there were two cases in which the INCLUDE line used 'accountline' as parameter, making it fail to pick the right account type! Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- btw, we should get rigt of the "thanks" :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81544|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81651&action=edit Bug 21715: Ease translation of account and account offset type descriptions This patch moves accounts-related descriptions into a single file to ease finding them, and also encloses descriptions inside <span> tags to make it easier to translate. To test: - Apply this patch - Verify the templates work as expected => SUCCESS: No behaviour change - Sign off :-D Bonus: there were two cases in which the INCLUDE line used 'accountline' as parameter, making it fail to pick the right account type! Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I guess you could argue which is easier. At the moment it's easy to make a typo, but you have all strings together in one entry which gives you context. With this patch they will all appear separately and out of order. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- What I wanted to say too: But it follows an existing pattern and will be less error-prone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Bug 21715 depends on bug 21584, which changed state. Bug 21584 Summary: Wrong offset type for Lost Item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21584 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21715 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Causation not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org