[Bug 29822] New: Add checkboxes to the system preference DefaultPatronSearchFields to eliminate errors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Bug ID: 29822 Summary: Add checkboxes to the system preference DefaultPatronSearchFields to eliminate errors Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com As Koha did with system preferences such as borrower mandatory fields and borrower unwanted fields, it would be helpful and avoid searching errors if the system preference, DefaultPatronSearchFields would also use checkboxes. These checkboxes will allow users to easily choose which fields Koha should use for searching. Currently, if a user puts a value in this field that is not valid, searching for patrons will be broken. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add checkboxes to the |Use table column selection |system preference |modal for |DefaultPatronSearchFields |DefaultPatronSearchFields |to eliminate errors |preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 30608 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144814&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com, | |jake.deery@ptfs-europe.com, | |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144814|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 144831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144831&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement changes release notes| |the | |DefaultPatronSearchFields | |system preference from an | |input field where field | |values separated by a comma | |are entered, to a dropdown | |list with a limited subset | |of the available patron | |fields. | | | |This makes it much | |easier to set the standard | |fields for patron search, | |and helps avoid breaking | |the patron search when | |incorrect field values are | |entered. | | | |NOTE: There is a | |change in behavour for this | |system preference, as only | |a limited subset of the | |available patron fields are | |now selectable for the | |standard patron search. --- Comment #4 from David Nind <david@davidnind.com> --- The test plan I used (using KTD): 1. Check system preference DefaultPatronSearchFields and note that it is defined by entering a comma separated list. 2. Go to the patrons module and view the HTML source for the page: . search the source for 'standard' - this should have two results . note that the option value for the Standard input field are "firstname,middle_name,surname,othernames,cardnumber,userid" 3. Apply the patch. 4. Reload or search again for the DefaultPatronSearchFields system preference. 5. Note that this is now a dropdown list with selectable values, rather than needing to enter a comma separated list. 6. Add a field to the list, such as 'Primary email'. 7. Repeat step 2 - the standard input field should now include the field you added. 8. Make sure some patrons have a primary email address, such as firstname@gmail.com 9. Do a standard search for gmail.com ==> the results should include all the patrons you added a gmail address to 10. Do a specific search on the 'Primary email' field ==> the search results should be the same as for step 9 BONUS: Perform the same search using the header search bar and the search options drop down (note: you need to change the 'Search type' from 'Starts with' to 'Contains'). (entered in the 'Other phone' field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #5 from David Nind <david@davidnind.com> --- Ignore the last bit of random text! I was going to comment on the fact that you enter the mobile number in the 'Other number' field for this to work for patron search. This is different from entering the SMS number when the SMSSendDriver system preference is enabled. It took me a while to figure this out. Should I create a bug to sort out this confusion? I found a couple of bugs related to this, but Bug 14872 (specifically comment no. 6) would seem to be a better approach. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for testing David, always great to get your feedback. I should have said somewhere I. The bug, the list of fields I picked is entirely arbitrarily picked at the moment.. I picked what made most sense to me.. so do feel free to help refine that list. Regards SMS alert number, I found that one rather confusing too, though I wasn't aware of the bug you linked. I like the idea of dropping the filed from borrowers and instead having a preference to define which field should contain this notification number. I'll go comment there. Many thanks for testing again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) I believe the list is now too limited. This is also likely to cause issues for libraries that have added fields not in your list. I think we should offer the full list, like BorrowerUnwantedField does - it would also simplify your patch :) 2) I believe we had discussed not changing this one, because of something with the extended patron attributes, but I cannot remember the exact issue now :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #7)
1) I believe the list is now too limited. This is also likely to cause issues for libraries that have added fields not in your list. I think we should offer the full list, like BorrowerUnwantedField does - it would also simplify your patch :)
Honestly, I'm a bit surprised you want every field listed and I think it increases the code burden personally.
2) I believe we had discussed not changing this one, because of something with the extended patron attributes, but I cannot remember the exact issue now :(
I can definitively say we do not support patron attributes as options here: * The code limits the options to an allow list that can be seen in koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc for the field selection in various patron search forms. * The autocomplete javascript does NOT limit the fields in the same way, but is hard coded to use `me.` as a table identifier.. adding `extended_attributes.field_name` is very unlikely to work, but I have not tested.. what I have found though is that if you add a random "field" name, then autocomplete just completely breaks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146430&action=edit Modal highlighting why I think it's a bad idea I've attached a mock of the modal.. all the red dots are the fields I feel sohuld be actively disabled for this preference.. many of the remaining one's I also feel don't make much sense / would lead to unusable results - searching for 'mr' in the title field for example.. how is that remotely helpful? Also, to convert this to a Modal we would need to do a database update to convert the existing preference from csv to pipe delimited string, update the preference descriptions and catch all the cases where the preference is currently in use and convert them from expecting a CSV to expecting a Pipe delimited string. I'm happy to expand the select list.. but I really don't think it's appropriate to display a modal filled with options greyed out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You can still use the modal and exclude those fields easily in the yaml file. That way we still have a consistent display/one place of code to change things and it's reduced to the more helfpul fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The excludes just get greyed out rather than removed as far as I can tell. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd include the note fields OPAC and circulation. Wondering: how do we handle additional patron attributes here? Are they always searchable automatically or not searchable at all? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #11)
The excludes just get greyed out rather than removed as far as I can tell.
Maybe we could rethink that? I still think having more ways to do a similar thing is not good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Can we deal with patron attributes as it's own bug please.. this is rapidly going from a small improvement to a large and difficult development. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #14)
Can we deal with patron attributes as it's own bug please.. this is rapidly going from a small improvement to a large and difficult development.
I don't want to change behaviour, was just wondering about existing behaviour and that is about this bug. For BorrowerMandatoryFields you could add the patron attribute names to the system preference and it worked. If a similar feature existed for this, it could block switching it to a modal or at least we should verify first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This preference does not affect the attributes in any way.. I've varified that in the code. Attributes are handled as their own case in the main patron search page.. always searched. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146445&action=edit Bug 29822: Use the modal This looks silly to me... and it still requires changes to koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc koha-tmpl/intranet-tmpl/prog/en/includes/member-search-box.inc koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc and a database update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |koha-bugs@lists.koha-commun |.com |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #7)
it would also simplify your patch :)
Not in the slightest.. it makes it significantly more involved and has a much higher risk of regression. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144831|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146488&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146445|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146489&action=edit Bug 29822: Use the modal As requested by Katrin.. switch to the modal and expose all fields from the borrowers database table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146490&action=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect of moving from comma delimited to pipe delimitation for the preference contents -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146491&action=edit Bug 29822: Database and Preference description updates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146492&action=edit Bug 29822: Update unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- 1 patch turns into 5 to convert it to the Modal approach.. and the unit tests are failing.. I can't see why the split doesn't appear to work with pipe instead of comma as the separation character. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146488|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147433&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146489|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147434&action=edit Bug 29822: Use the modal As requested by Katrin.. switch to the modal and expose all fields from the borrowers database table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146490|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147435&action=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect of moving from comma delimited to pipe delimitation for the preference contents -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146491|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147436&action=edit Bug 29822: Database and Preference description updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146492|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 147437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147437&action=edit Bug 29822: Update unit tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #31 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Sorry, I get a template error: Template process failed: file error - parse error - patronfields.inc line 90-91: unexpected token ([) [% standard.replace('|', ',') [% SET full_address = 'streetnumber,streettype,address,address2,city,state,zipcode,country' %] at /kohadevbox/koha/C4/Templates.pm line 127 (I also tried on PTFS' and Bywater's sandboxes, one with the patch applied, and one with the patch applied after initialisation - just to make sure it wasn't a sandbox fault.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147433|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149890&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147434|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149891&action=edit Bug 29822: Use the modal As requested by Katrin.. switch to the modal and expose all fields from the borrowers database table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147435|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149892&action=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect of moving from comma delimited to pipe delimitation for the preference contents -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147436|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149893&action=edit Bug 29822: Database and Preference description updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147437|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 149894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149894&action=edit Bug 29822: Update unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We should be back on again now.. master is moving so fast at the moment :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- FAIL installer/data/mysql/atomicupdate/bug_29822.pl FAIL file permissions File must have the exec flag OK installer/data/mysql/mandatory/sysprefs.sql OK koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc OK koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc FAIL koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc FAIL forbidden patterns forbidden pattern: Do not use line breaks inside template tags (bug 18675) (line 90) FAIL valid_template parse error - /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/includes/patronfields.inc line 90-91: unexpected token ([) [% standard.replace('|', ',') [% SET full_address = 'streetnumber,streettype,address,address2,city,state,zipcode,country' %] OK koha-tmpl/intranet-tmpl/prog/js/patron-autocomplete.js OK t/db_dependent/selenium/patrons_search.t Processing additional checks OK! Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/selenium/patrons_search.t KO! # Failed test 'All standard fields are searchable if DefaultPatronSearchFields not set. middle_name is there.' # at /kohadevbox/koha/t/db_dependent/selenium/patrons_search.t line 163. # got: '0' # expected: '14' # Looks like you planned 25 tests but ran 1. # Looks like you failed 1 test of 1 run. # Failed test 'Search patrons' # at /kohadevbox/koha/t/db_dependent/selenium/patrons_search.t line 341. Can't call method "get_value" on an undefined value at /kohadevbox/koha/t/db_dependent/selenium/patrons_search.t line 164. # Looks like your test exited with 255 just after 1. /kohadevbox/koha/t/db_dependent/selenium/patrons_search.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/1 subtests Test Summary Report------------------- /kohadevbox/koha/t/db_dependent/selenium/patrons_search.t (Wstat: 65280 Tests: 1 Failed: 1) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149890|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151058&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149891|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151059&action=edit Bug 29822: Use the modal As requested by Katrin.. switch to the modal and expose all fields from the borrowers database table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149892|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151060&action=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect of moving from comma delimited to pipe delimitation for the preference contents tmp -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149893|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151061&action=edit Bug 29822: Database and Preference description updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149894|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151062&action=edit Bug 29822: Update unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased.. seems we lost a closing brace.. should be working now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The tests are still failing for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151064&action=edit Bug 29822: Escape backslash on split + effectively replace 'standard', don't display it. + avoid mixing | and , -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151058|0 |1 is obsolete| | --- Comment #47 from David Nind <david@davidnind.com> --- Created attachment 151233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151233&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151059|0 |1 is obsolete| | --- Comment #48 from David Nind <david@davidnind.com> --- Created attachment 151234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151234&action=edit Bug 29822: Use the modal As requested by Katrin.. switch to the modal and expose all fields from the borrowers database table Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151060|0 |1 is obsolete| | --- Comment #49 from David Nind <david@davidnind.com> --- Created attachment 151235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151235&action=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect of moving from comma delimited to pipe delimitation for the preference contents tmp Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151061|0 |1 is obsolete| | --- Comment #50 from David Nind <david@davidnind.com> --- Created attachment 151236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151236&action=edit Bug 29822: Database and Preference description updates Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151062|0 |1 is obsolete| | --- Comment #51 from David Nind <david@davidnind.com> --- Created attachment 151237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151237&action=edit Bug 29822: Update unit tests Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151064|0 |1 is obsolete| | --- Comment #52 from David Nind <david@davidnind.com> --- Created attachment 151238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151238&action=edit Bug 29822: Escape backslash on split + effectively replace 'standard', don't display it. + avoid mixing | and , Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement changes |This enhancement changes release notes|the |the |DefaultPatronSearchFields |DefaultPatronSearchFields |system preference from an |system preference from an |input field where field |input field where field |values separated by a comma |values separated by a comma |are entered, to a dropdown |are entered, to a modal |list with a limited subset |window listing all patron |of the available patron |fields (non-selectable |fields. |fields are greyed out). | | |This makes it much |This makes it much easier |easier to set the standard |to set the standard fields |fields for patron search, |for patron search, and |and helps avoid breaking |helps avoid breaking the |the patron search when |patron search when |incorrect field values are |incorrect field values are |entered. |entered. | | |NOTE: There is a | |change in behavour for this | |system preference, as only | |a limited subset of the | |available patron fields are | |now selectable for the | |standard patron search. | --- Comment #53 from David Nind <david@davidnind.com> --- Testing notes using KTD: 1. Check system preference DefaultPatronSearchFields and note that it is defined by entering a comma separated list. 2. Go to the patrons module and view the HTML source for the page: . search the source for 'standard' - this should have two results . note that the option value for the Standard input field are "firstname,middle_name,surname,othernames,cardnumber,userid" 3. Break the patron search: . for the DefaultPatronSearchFields system preference, add a field that doesn't exist, for example: someunknownfield . for patron search, enter any value in the search field and make sure standard is selected for the search field drop down list . you get a pop-up error message: "Something went wrong when loading the table. 500: Internal Server Error." 4. Apply the patch. 5. Update the database: databaseupdate 6. Restart everything: flushmemcached, restart_all 7. Reload or search again for the DefaultPatronSearchFields system preference. 8. Note that this is now a modal window with all the patron fields that are selectable shown (greyed out items are not selectable), rather than needing to enter a comma separated list. 9. Select some fields, such as 'First name', 'Surname', 'Primary email'. 10. Repeat step 2 - the standard input field now includes the fields you selected. 11. Make sure some patrons have a primary email address, such as firstname@gmail.com 12. Do a standard search for gmail.com ==> the results should include all the patrons you added a gmail address to 13. Do a specific search on the 'Primary email' field ==> the search results should be the same as for step 12 14. Run the tests, these should pass (note - KTD needs to be started with selenium: ktd --selenium up): . prove t/db_dependent/selenium/patrons_search.t BONUS: Perform the same search using the header search bar and the search options drop down (note: you need to change the 'Search type' from 'Starts with' to 'Contains'). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #54 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Sorry Martin, this needs another rebase (bug 34092). Does not seem hard but not trivial. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bugger.. I thought this was part of that dependency tree already :(. Looking at the rebase now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151233|0 |1 is obsolete| | --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153373&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151234|0 |1 is obsolete| | --- Comment #57 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153374&action=edit Bug 29822: Use the modal As requested by Katrin.. switch to the modal and expose all fields from the borrowers database table Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151235|0 |1 is obsolete| | --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153375&action=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect of moving from comma delimited to pipe delimitation for the preference contents tmp Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151236|0 |1 is obsolete| | --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153376&action=edit Bug 29822: Database and Preference description updates Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151237|0 |1 is obsolete| | --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153377&action=edit Bug 29822: Update unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151238|0 |1 is obsolete| | --- Comment #61 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153378&action=edit Bug 29822: Escape backslash on split + effectively replace 'standard', don't display it. + avoid mixing | and , Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- OK.. rebased.. but waiting for my ktd to startup so I can re-run the tests. Patches uploaded just in case someone is already available ;P -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34092 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #63 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Unit tests failing with rebase.. resetting to Failed whilst I work on that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153373|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153379&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153374|0 |1 is obsolete| | --- Comment #65 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153380&action=edit Bug 29822: Use the modal As requested by Katrin.. switch to the modal and expose all fields from the borrowers database table Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153375|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153381&action=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect of moving from comma delimited to pipe delimitation for the preference contents Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153376|0 |1 is obsolete| | --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153382&action=edit Bug 29822: Database and Preference description updates Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153377|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153383&action=edit Bug 29822: Update unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153378|0 |1 is obsolete| | --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153384&action=edit Bug 29822: Escape backslash on split + effectively replace 'standard', don't display it. + avoid mixing | and , Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153379|0 |1 is obsolete| | --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153442&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153380|0 |1 is obsolete| | --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153443&action=edit Bug 29822: Use the modal As requested by Katrin.. switch to the modal and expose all fields from the borrowers database table Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153381|0 |1 is obsolete| | --- Comment #72 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153444&action=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect of moving from comma delimited to pipe delimitation for the preference contents Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153382|0 |1 is obsolete| | --- Comment #73 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153445&action=edit Bug 29822: Database and Preference description updates Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153383|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153446&action=edit Bug 29822: Update unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153384|0 |1 is obsolete| | --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 153447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153447&action=edit Bug 29822: Escape backslash on split + effectively replace 'standard', don't display it. + avoid mixing | and , Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|34092 |34256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34092 [Bug 34092] patron-autocomplete.js and patron-search.inc search logic should match https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 [Bug 34256] Patron search: search for borrowernumber starts with fails -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33428 CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #76 from Nick Clemens <nick@bywatersolutions.com> --- This and 33428 are going to clash, happy to rebase mine on top of this Would it be better to leave the fields from the pref as pipe, and just move the other fields 'full_address', 'all_emails' etc to use the pipe too? Then we don't have to replace in the one instance for splitting. I don't understand the comment: + effectively replace 'standard', don't display it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153442|0 |1 is obsolete| | Attachment #153443|0 |1 is obsolete| | Attachment #153444|0 |1 is obsolete| | Attachment #153445|0 |1 is obsolete| | Attachment #153446|0 |1 is obsolete| | Attachment #153447|0 |1 is obsolete| | --- Comment #77 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154361&action=edit Bug 29822: Update 'DefaultPatronSearchFields' to a select list This patch updates the `DefaultPatronSearchFields` preference from freetext expecting a comma delimited list of borrower fields to a multi-select with a sensible list of fields available. I opted to not use the Modal approach with all borrower fields listed as I felt it made more sense to only expose a more limited subset of the fields available to us. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #78 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154362&action=edit Bug 29822: Use the modal As requested by Katrin.. switch to the modal and expose all fields from the borrowers database table Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #79 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154363&action=edit Bug 29822: Update code to reference by pipe Moving to modalselect also has the effect of moving from comma delimited to pipe delimitation for the preference contents Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #80 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154364&action=edit Bug 29822: Database and Preference description updates Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #81 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154365&action=edit Bug 29822: Update unit tests Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #82 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154366&action=edit Bug 29822: (QA follow-up) Use pipe for all field separators - Tidy atomic update Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33428 [Bug 33428] Should only search in searchable patron attributes if searching in standard fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Bug 29822 depends on bug 34256, which changed state. Bug 34256 Summary: Patron search: search for borrowernumber starts with fails https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34256 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 --- Comment #83 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #84 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement changes |This enhancement changes release notes|the |the |DefaultPatronSearchFields |`DefaultPatronSearchFields` |system preference from an |system preference from an |input field where field |input field where field |values separated by a comma |values separated by a comma |are entered, to a modal |are entered, to a modal |window listing all patron |window listing all patron |fields (non-selectable |fields (non-selectable |fields are greyed out). |fields are greyed out). | | |This makes it much easier |This makes it much easier |to set the standard fields |to set the standard fields |for patron search, and |for patron search, and |helps avoid breaking the |helps avoid breaking the |patron search when |patron search when |incorrect field values are |incorrect field values are |entered. |entered. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Rasa Satinskiene <rasa.satinskiene@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |Rasa Satinskiene contact| | CC| |rasa.satinskiene@ptfs-europ | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29822 Rasa Satinskiene <rasa.satinskiene@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/838 --- Comment #85 from Rasa Satinskiene <rasa.satinskiene@ptfs-europe.com> --- Manual updated -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org