[Bug 22784] New: Archiving Purchase Suggestions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Bug ID: 22784 Summary: Archiving Purchase Suggestions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: joy@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Create a way to archive the 'completed' purchase suggestions on the staff side. 1. Add an 'archived' column to purchase suggestions 2. Add a script to automatically mark suggestions of a certain age and status as archived 3. Add a button on the purchase suggestions page to archive specific suggestions 4. Add a 'view archived suggestions' button to view archived suggestions. Default view does not display archived suggestions 5. Add 'archived' option to the filters on the purchase suggestions page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 1884 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr Change sponsored?|--- |Seeking developer --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- The BULAC (http://www.bulac.fr/) is interested by the behaviours detailed on the first comment, and we’d like to sponsor this development. An important hope for us, not mentioned above, is to have better performance on the suggestions page loading, for it is now very slow because of the hundreds of suggestions we’ve already got. We hope archiving will settle this. As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: <sigb@bulac.fr>. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |agustinmoyano@theke.io |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking developer |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|agustinmoyano@theke.io |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95499&action=edit Bug 22784: DB Changes Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95500&action=edit Bug 22784: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95501&action=edit Bug 22784: Add the ability to archive/unarchive a purchase suggestions There are performance issues when searching suggestions if there are thousands of suggestions. To prevent that we are going to add the ability to archive purchase suggestions, in order to remove them from the search list (by default). Test plan: 0. Apply all the patches, execute the updatedatabase.pl script, restart all 1. Create some suggestions 2. Search for them 3. Use the "Archive" action button for one of them 4. Restart the search => The archived suggestion does no longer appear in the list 5. Use the filter "Included archived" in the "Suggestion information" filter box => The archived suggestion is now displayed 6. Use other filters => The "archived" filter is kept from one search to another 7. Use one of the action at the bottom of the suggestion list (change the status for instance) => The "archived" filter is still kept Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95502&action=edit Bug 22784: Add a cronjob to archive suggestions given age or status criteria In order to deal automatically with suggestions that need to be archived, this cronjob will help to add the "archived" flag following their age or status. Test plan: - Execute the script with the --help parameter and read the documentation. - Does it make sense? - Use it without the --confirm flag and try several combination For instance you will want to archive suggestions that have been rejected for more than a week: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=rejecteddate --age=weeks:1 or even suggestion that have been suggested for more than a year and have a ORDERED status: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=suggesteddate --age=years:1 --status=ORDERED - Use it with the --confirm flag and make sure the suggestions have been archived. Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22590 [Bug 22590] Allow batch printing of routing lists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_22784 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Joy Nelson from comment #0)
Create a way to archive the 'completed' purchase suggestions on the staff side. 1. Add an 'archived' column to purchase suggestions
Done!
2. Add a script to automatically mark suggestions of a certain age and status as archived
Done!
3. Add a button on the purchase suggestions page to archive specific suggestions
Were you suggesting 1 new action for the selected suggestions? This patchset only add 1 new action per suggestion. We could have another action at the bottom of the suggestion list but I am afraid it will become a bit packed and we are going to lose readability, dependent bug reports already add stuff there. I would suggest to deal with that on a separate bug report.
4. Add a 'view archived suggestions' button to view archived suggestions. Default view does not display archived suggestions
Not sure it is needed as there is the filter. I am willing to add something after you have tested the patches and can tell me what you have exactly in mind ;)
5. Add 'archived' option to the filters on the purchase suggestions page.
Done! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95501|0 |1 is obsolete| | Attachment #95502|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95510&action=edit Bug 22784: Add the ability to archive/unarchive a purchase suggestions There are performance issues when searching suggestions if there are thousands of suggestions. To prevent that we are going to add the ability to archive purchase suggestions, in order to remove them from the search list (by default). Test plan: 0. Apply all the patches, execute the updatedatabase.pl script, restart all 1. Create some suggestions 2. Search for them 3. Use the "Archive" action button for one of them 4. Restart the search => The archived suggestion does no longer appear in the list 5. Use the filter "Included archived" in the "Suggestion information" filter box => The archived suggestion is now displayed 6. Use other filters => The "archived" filter is kept from one search to another 7. Use one of the action at the bottom of the suggestion list (change the status for instance) => The "archived" filter is still kept Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95511&action=edit Bug 22784: Bugfix - do not modify #description build Debian packages from a git repository -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95512&action=edit Bug 22784: Do not display an empty table This is terrible and highlight that the whole script must be rewrite. GetDistinctValues does not handle the "archived" flag (and we do not want to put our hands there), so let's hack that and plan to rewrite the whole script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95513&action=edit Bug 22784: Add a cronjob to archive suggestions given age or status criteria In order to deal automatically with suggestions that need to be archived, this cronjob will help to add the "archived" flag following their age or status. Test plan: - Execute the script with the --help parameter and read the documentation. - Does it make sense? - Use it without the --confirm flag and try several combination For instance you will want to archive suggestions that have been rejected for more than a week: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=rejecteddate --age=weeks:1 or even suggestion that have been suggested for more than a year and have a ORDERED status: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=suggesteddate --age=years:1 --status=ORDERED - Use it with the --confirm flag and make sure the suggestions have been archived. Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23591 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 [Bug 23591] Add a new "Suggestions details" tab on bibliographic record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Séverine Queune <severine.queune@bulac.fr> --- Hi Jonathan, This patch doesn't apply on master : Applying: Bug 22784: DB Changes Using index info to reconstruct a base tree... M Koha/Schema/Result/Suggestion.pm M installer/data/mysql/kohastructure.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql Auto-merging Koha/Schema/Result/Suggestion.pm Applying: Bug 22784: DBIC Changes Using index info to reconstruct a base tree... M Koha/Schema/Result/Suggestion.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Suggestion.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Suggestion.pm Failed to merge in the changes. Patch failed at 0001 Bug 22784: DBIC Changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22590 |23590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22590 [Bug 22590] Allow batch printing of routing lists https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Allow to modify the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sorry, wrong bug number in the dep list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95499|0 |1 is obsolete| | --- Comment #14 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95533&action=edit Bug 22784: DB Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95500|0 |1 is obsolete| | --- Comment #15 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95534&action=edit Bug 22784: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95510|0 |1 is obsolete| | --- Comment #16 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95535&action=edit Bug 22784: Add the ability to archive/unarchive a purchase suggestions There are performance issues when searching suggestions if there are thousands of suggestions. To prevent that we are going to add the ability to archive purchase suggestions, in order to remove them from the search list (by default). Test plan: 0. Apply all the patches, execute the updatedatabase.pl script, restart all 1. Create some suggestions 2. Search for them 3. Use the "Archive" action button for one of them 4. Restart the search => The archived suggestion does no longer appear in the list 5. Use the filter "Included archived" in the "Suggestion information" filter box => The archived suggestion is now displayed 6. Use other filters => The "archived" filter is kept from one search to another 7. Use one of the action at the bottom of the suggestion list (change the status for instance) => The "archived" filter is still kept Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95511|0 |1 is obsolete| | --- Comment #17 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95536&action=edit Bug 22784: Bugfix - do not modify #description build Debian packages from a git repository Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95512|0 |1 is obsolete| | --- Comment #18 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95537&action=edit Bug 22784: Do not display an empty table This is terrible and highlight that the whole script must be rewrite. GetDistinctValues does not handle the "archived" flag (and we do not want to put our hands there), so let's hack that and plan to rewrite the whole script. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95513|0 |1 is obsolete| | --- Comment #19 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 95538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95538&action=edit Bug 22784: Add a cronjob to archive suggestions given age or status criteria In order to deal automatically with suggestions that need to be archived, this cronjob will help to add the "archived" flag following their age or status. Test plan: - Execute the script with the --help parameter and read the documentation. - Does it make sense? - Use it without the --confirm flag and try several combination For instance you will want to archive suggestions that have been rejected for more than a week: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=rejecteddate --age=weeks:1 or even suggestion that have been suggested for more than a year and have a ORDERED status: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=suggesteddate --age=years:1 --status=ORDERED - Use it with the --confirm flag and make sure the suggestions have been archived. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #20 from Liz Rea <wizzyrea@gmail.com> --- This still applies, QA? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Liz Rea from comment #20)
This still applies, QA?
Please don't - only person from the QA team seeing this will probably be me and the people who can't QA because they are already on the bug report having worked on it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Liz Rea from comment #20)
This still applies, QA?
I can take a look on Monday -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95533|0 |1 is obsolete| | --- Comment #23 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96900&action=edit Bug 22784: DB Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95534|0 |1 is obsolete| | --- Comment #24 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96901&action=edit Bug 22784: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95535|0 |1 is obsolete| | --- Comment #25 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96902&action=edit Bug 22784: Add the ability to archive/unarchive a purchase suggestions There are performance issues when searching suggestions if there are thousands of suggestions. To prevent that we are going to add the ability to archive purchase suggestions, in order to remove them from the search list (by default). Test plan: 0. Apply all the patches, execute the updatedatabase.pl script, restart all 1. Create some suggestions 2. Search for them 3. Use the "Archive" action button for one of them 4. Restart the search => The archived suggestion does no longer appear in the list 5. Use the filter "Included archived" in the "Suggestion information" filter box => The archived suggestion is now displayed 6. Use other filters => The "archived" filter is kept from one search to another 7. Use one of the action at the bottom of the suggestion list (change the status for instance) => The "archived" filter is still kept Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95536|0 |1 is obsolete| | --- Comment #26 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96903&action=edit Bug 22784: Bugfix - do not modify #description build Debian packages from a git repository Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95537|0 |1 is obsolete| | --- Comment #27 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96904&action=edit Bug 22784: Do not display an empty table This is terrible and highlight that the whole script must be rewrite. GetDistinctValues does not handle the "archived" flag (and we do not want to put our hands there), so let's hack that and plan to rewrite the whole script. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95538|0 |1 is obsolete| | --- Comment #28 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 96905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96905&action=edit Bug 22784: Add a cronjob to archive suggestions given age or status criteria In order to deal automatically with suggestions that need to be archived, this cronjob will help to add the "archived" flag following their age or status. Test plan: - Execute the script with the --help parameter and read the documentation. - Does it make sense? - Use it without the --confirm flag and try several combination For instance you will want to archive suggestions that have been rejected for more than a week: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=rejecteddate --age=weeks:1 or even suggestion that have been suggested for more than a year and have a ORDERED status: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=suggesteddate --age=years:1 --status=ORDERED - Use it with the --confirm flag and make sure the suggestions have been archived. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Currently blocked by dependency bug 23950. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96900|0 |1 is obsolete| | Attachment #96901|0 |1 is obsolete| | Attachment #96902|0 |1 is obsolete| | Attachment #96903|0 |1 is obsolete| | Attachment #96904|0 |1 is obsolete| | Attachment #96905|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100806&action=edit Bug 22784: DB Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100807&action=edit Bug 22784: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100808&action=edit Bug 22784: Add the ability to archive/unarchive a purchase suggestions There are performance issues when searching suggestions if there are thousands of suggestions. To prevent that we are going to add the ability to archive purchase suggestions, in order to remove them from the search list (by default). Test plan: 0. Apply all the patches, execute the updatedatabase.pl script, restart all 1. Create some suggestions 2. Search for them 3. Use the "Archive" action button for one of them 4. Restart the search => The archived suggestion does no longer appear in the list 5. Use the filter "Included archived" in the "Suggestion information" filter box => The archived suggestion is now displayed 6. Use other filters => The "archived" filter is kept from one search to another 7. Use one of the action at the bottom of the suggestion list (change the status for instance) => The "archived" filter is still kept Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100809&action=edit Bug 22784: Bugfix - do not modify #description build Debian packages from a git repository Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #34 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100810&action=edit Bug 22784: Do not display an empty table This is terrible and highlight that the whole script must be rewrite. GetDistinctValues does not handle the "archived" flag (and we do not want to put our hands there), so let's hack that and plan to rewrite the whole script. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100811&action=edit Bug 22784: Add a cronjob to archive suggestions given age or status criteria In order to deal automatically with suggestions that need to be archived, this cronjob will help to add the "archived" flag following their age or status. Test plan: - Execute the script with the --help parameter and read the documentation. - Does it make sense? - Use it without the --confirm flag and try several combination For instance you will want to archive suggestions that have been rejected for more than a week: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=rejecteddate --age=weeks:1 or even suggestion that have been suggested for more than a year and have a ORDERED status: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=suggesteddate --age=years:1 --status=ORDERED - Use it with the --confirm flag and make sure the suggestions have been archived. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100806|0 |1 is obsolete| | Attachment #100807|0 |1 is obsolete| | Attachment #100808|0 |1 is obsolete| | Attachment #100809|0 |1 is obsolete| | Attachment #100810|0 |1 is obsolete| | Attachment #100811|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100854&action=edit Bug 22784: DB Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100855&action=edit Bug 22784: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100856&action=edit Bug 22784: Add the ability to archive/unarchive a purchase suggestions There are performance issues when searching suggestions if there are thousands of suggestions. To prevent that we are going to add the ability to archive purchase suggestions, in order to remove them from the search list (by default). Test plan: 0. Apply all the patches, execute the updatedatabase.pl script, restart all 1. Create some suggestions 2. Search for them 3. Use the "Archive" action button for one of them 4. Restart the search => The archived suggestion does no longer appear in the list 5. Use the filter "Included archived" in the "Suggestion information" filter box => The archived suggestion is now displayed 6. Use other filters => The "archived" filter is kept from one search to another 7. Use one of the action at the bottom of the suggestion list (change the status for instance) => The "archived" filter is still kept Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #39 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100857&action=edit Bug 22784: Bugfix - do not modify #description build Debian packages from a git repository Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #40 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100858&action=edit Bug 22784: Do not display an empty table This is terrible and highlight that the whole script must be rewrite. GetDistinctValues does not handle the "archived" flag (and we do not want to put our hands there), so let's hack that and plan to rewrite the whole script. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #41 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 100859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100859&action=edit Bug 22784: Add a cronjob to archive suggestions given age or status criteria In order to deal automatically with suggestions that need to be archived, this cronjob will help to add the "archived" flag following their age or status. Test plan: - Execute the script with the --help parameter and read the documentation. - Does it make sense? - Use it without the --confirm flag and try several combination For instance you will want to archive suggestions that have been rejected for more than a week: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=rejecteddate --age=weeks:1 or even suggestion that have been suggested for more than a year and have a ORDERED status: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=suggesteddate --age=years:1 --status=ORDERED - Use it with the --confirm flag and make sure the suggestions have been archived. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, can you please rebase? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100855|0 |1 is obsolete| | --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 101948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101948&action=edit Bug 22784: DBIC changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #42)
Hi Jonathan, can you please rebase?
The patches applied ok. The one that does not it DBIC changes, it can be done this way: % git bz apply --skip % dbic That's it :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #44)
(In reply to Katrin Fischer from comment #42)
Hi Jonathan, can you please rebase?
The patches applied ok. The one that does not it DBIC changes, it can be done this way: % git bz apply --skip % dbic
That's it :)
I did that on one of Nick's patches recenlty and then he had some thing dependent on it in the ohter patches - thought I'd play it safe here :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102779&action=edit Bug 22784: Fix small display issue with fa icon in suggestions table The <i> was not closed resulting in the "Archived" displaying in the wrong font. Might be a browser specific issue, but adding the closing </i> fixed it and follows the existing pattern. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100854|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102780&action=edit Bug 22784: DB Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100856|0 |1 is obsolete| | --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102781&action=edit Bug 22784: Add the ability to archive/unarchive a purchase suggestions There are performance issues when searching suggestions if there are thousands of suggestions. To prevent that we are going to add the ability to archive purchase suggestions, in order to remove them from the search list (by default). Test plan: 0. Apply all the patches, execute the updatedatabase.pl script, restart all 1. Create some suggestions 2. Search for them 3. Use the "Archive" action button for one of them 4. Restart the search => The archived suggestion does no longer appear in the list 5. Use the filter "Included archived" in the "Suggestion information" filter box => The archived suggestion is now displayed 6. Use other filters => The "archived" filter is kept from one search to another 7. Use one of the action at the bottom of the suggestion list (change the status for instance) => The "archived" filter is still kept Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100857|0 |1 is obsolete| | --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102782&action=edit Bug 22784: Bugfix - do not modify #description build Debian packages from a git repository Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100858|0 |1 is obsolete| | --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102783&action=edit Bug 22784: Do not display an empty table This is terrible and highlight that the whole script must be rewrite. GetDistinctValues does not handle the "archived" flag (and we do not want to put our hands there), so let's hack that and plan to rewrite the whole script. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100859|0 |1 is obsolete| | --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102784&action=edit Bug 22784: Add a cronjob to archive suggestions given age or status criteria In order to deal automatically with suggestions that need to be archived, this cronjob will help to add the "archived" flag following their age or status. Test plan: - Execute the script with the --help parameter and read the documentation. - Does it make sense? - Use it without the --confirm flag and try several combination For instance you will want to archive suggestions that have been rejected for more than a week: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=rejecteddate --age=weeks:1 or even suggestion that have been suggested for more than a year and have a ORDERED status: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=suggesteddate --age=years:1 --status=ORDERED - Use it with the --confirm flag and make sure the suggestions have been archived. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101948|0 |1 is obsolete| | --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102785&action=edit Bug 22784: DBIC changes Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102779|0 |1 is obsolete| | --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 102786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102786&action=edit Bug 22784: Fix small display issue with fa icon in suggestions table The <i> was not closed resulting in the "Archived" displaying in the wrong font. Might be a browser specific issue, but adding the closing </i> fixed it and follows the existing pattern. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #54 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This worked really well in my testing and is a real nice addition to help carefully clean up suggestions without having to delete the data. The only thing is maybe the way we display archived entries in the suggestions table - I think the icon/message could be better placed somehow, but haven't come up with a good suggestion myself. Definitely not a blocker :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Archiving Purchase |Archiving purchase |Suggestions |suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #55 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #56 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 102944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102944&action=edit Bug 22784: (QA follow-up) booleans should be TINYINT As per the coding guidelines, they should be TINYINT(1). Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #57 from Tomás Cohen Arazi <tomascohen@gmail.com> --- We should add that last patch I attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #59 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch, thanks Tomas. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed, | |rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #60 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancements to the release notes| |suggestions process adds a | |way to archive completed | |purchase suggestions. Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Archiving purchase |Add the ability to archive |suggestions |purchase suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Bug 22784 depends on bug 23590, which changed state. Bug 23590 Summary: Add the ability to change the manager of a suggestion and notify the new manager https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27462 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27462 [Bug 27462] Number of suggestions includes archived suggestions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27635 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27635 [Bug 27635] Add option for patron to view archived suggestions on the OPAC -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org