https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32744 Depends on|32744 |32743 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743 [Bug 32743] Reindent the invoice details page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32744 [Bug 32744] [OMNIBUS] Standardize structure around action fieldsets -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 145902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145902&action=edit Bug 32746: Standardize structure around action fieldsets in acquisitions This patch updates acquisitions templates so that fieldsets with the "action" class are placed outside the form's main fieldset. A couple of minor changes have been made to related CSS. To test, apply the patch and rebuild the staff interface CSS. Go to acquisitions and check the following pages to confirm that changes to form structure look correct: - Open the "Late orders" page from the left-hand sidebar menu and check the form in the sidebar. - Open the "Orders search" form in the search header and submit the form without specifying any search criteria. This should bring up a blank orders search form. - Open the "Invoices" page from the left-hand sidebar menu. Check the form in the sidebar. - Perform an invoice search which will return results. - View one of the invoices returned by your search. - On the invoice detail age, the "Save" button associated with the invoice details at the top should look correct. - There should be a box below that with the heading "Adjustments" and a link to add an adjustment. - When you click "Add an adjustment," a form should be displayed with the correct controls at the bottom. Clicking "Cancel" should hide the form. - Click the "Manage invoice files" link, and check the form on that page. - Locate a vendor and view its details. - Check the "Uncertain prices" page, linked from the menu in the left-hand sidebar. - Open the "Baskets" page from the left-hand sidebar. Click the "Add to basket" button for one of the existing baskets. - Click "From existing orders (copy)". Check that this form looks correct. - Open the "Basket groups" page from the left-hand sidebar menu. - Click "New basket group" and check that form. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind <david@davidnind.com> --- The patch no longer applies - I'm getting a sha1 error: git bz apply 32746 Bug 32746 - Standardize structure around action fieldsets in acquisitions 145902 - Bug 32746: Standardize structure around action fieldsets in acquisitions Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 32746: Standardize structure around action fieldsets in acquisitions error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt). error: could not build fake ancestor Patch failed at 0001 Bug 32746: Standardize structure around action fieldsets in acquisitions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 --- Comment #5 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #3)

This is applying okay for me today, could you try again?

Must have been something I did wrong at my end. Now applies, and have signed off. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32954 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32954 [Bug 32954] Standardize action fieldsets in rotating collections, suggestions, tools -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 Bug 32746 depends on bug 32743, which changed state. Bug 32743 Summary: Reindent the invoice details page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32743 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146447|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147359&action=edit Bug 32746: Standardize structure around action fieldsets in acquisitions This patch updates acquisitions templates so that fieldsets with the "action" class are placed outside the form's main fieldset. A couple of minor changes have been made to related CSS. To test, apply the patch and rebuild the staff interface CSS. Go to acquisitions and check the following pages to confirm that changes to form structure look correct: - Open the "Late orders" page from the left-hand sidebar menu and check the form in the sidebar. - Open the "Orders search" form in the search header and submit the form without specifying any search criteria. This should bring up a blank orders search form. - Open the "Invoices" page from the left-hand sidebar menu. Check the form in the sidebar. - Perform an invoice search which will return results. - View one of the invoices returned by your search. - On the invoice detail age, the "Save" button associated with the invoice details at the top should look correct. - There should be a box below that with the heading "Adjustments" and a link to add an adjustment. - When you click "Add an adjustment," a form should be displayed with the correct controls at the bottom. Clicking "Cancel" should hide the form. - Click the "Manage invoice files" link, and check the form on that page. - Locate a vendor and view its details. - Check the "Uncertain prices" page, linked from the menu in the left-hand sidebar. - Open the "Baskets" page from the left-hand sidebar. Click the "Add to basket" button for one of the existing baskets. - Click "From existing orders (copy)". Check that this form looks correct. - Open the "Basket groups" page from the left-hand sidebar menu. - Click "New basket group" and check that form. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 --- Comment #8 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32746 Lisette Scheer <lisette.scheer@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34452 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34452 [Bug 34452] Button Update adjustments is hidden -- You are receiving this mail because: You are watching all bug changes.