https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 169051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169051&action=edit Bug 37375: Fix holdings table not loading if MARC framework is missing certain 952 subfields When you've catalogued a record with MARC framework that is for some reason missing certain 952 subfields (8, a, b, c, or y), holdings table is no longer loading but stuck in the "Processing..." loader. To test, open Koha in two browser tabs: IN TAB 1 (framework configuration): 1. Create a new MARC framework "TEST", based on the default MARC framework IN TAB 2 (record view): 2. Create a new record using MARC framework "TEST" 3. Add an item to the newly created record 4. Observe item visible on the record's holdings list IN TAB 1 (framework configuration): 5. Delete all 952 subfields in framework "TEST" except: 8, a, b, c, y IN TAB 2 (record view): 6. Refresh page 7. Observe item visible on the record's holdings list 8. Open your browser's console for upcoming error messages Iterating remaining subfields in following order, | <FIELD> | <NAME> ------------------------------------------------------ | 952$8 | row._strings.collection_code | 952$c | row._strings.location | 952$a | row._strings.home_library_id | 952$b | row._strings.holding_library_id | 952$y | row._strings.item_type_id IN TAB 1 (framework configuration): 9. Delete subfield <FIELD> in framework "TEST" IN TAB 2 (record view): 10. Refresh page 11. Observe error "Uncaught TypeError: <NAME> is undefined" 12. Apply patch IN TAB 2: 13. Refresh page 14. Observe item visible on the record's holdings list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 --- Comment #2 from Lari Taskula <lari.taskula@hypernova.fi> --- For context, one of our client libraries had a MARC framework without 952$8 and after upgrading to 24.05.1 could no longer see items for the records that were catalogued with this framework. Koha should either way load the items, even if the framework was not configured as expected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37544 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170578|0 |1 is obsolete| | --- Comment #5 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 170579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170579&action=edit Bug 37375: Fix holdings table not loading if MARC framework is missing certain 952 subfields When you've catalogued a record with MARC framework that is for some reason missing certain 952 subfields (8, a, b, c, or y), holdings table is no longer loading but stuck in the "Processing..." loader. To test, open Koha in two browser tabs: IN TAB 1 (framework configuration): 1. Create a new MARC framework "TEST", based on the default MARC framework IN TAB 2 (record view): 2. Create a new record using MARC framework "TEST" 3. Add an item to the newly created record 4. Observe item visible on the record's holdings list IN TAB 1 (framework configuration): 5. Delete all 952 subfields in framework "TEST" except: 8, a, b, c, y IN TAB 2 (record view): 6. Refresh page 7. Observe item visible on the record's holdings list 8. Open your browser's console for upcoming error messages Iterating remaining subfields in following order, | <FIELD> | <NAME> ------------------------------------------------------ | 952$8 | row._strings.collection_code | 952$c | row._strings.location | 952$a | row._strings.home_library_id | 952$b | row._strings.holding_library_id | 952$y | row._strings.item_type_id IN TAB 1 (framework configuration): 9. Delete subfield <FIELD> in framework "TEST" IN TAB 2 (record view): 10. Refresh page 11. Observe error "Uncaught TypeError: <NAME> is undefined" (Firefox) (or Cannot read properties of undefined (reading 'str') (Chromium)) 12. Apply patch IN TAB 2: 13. Refresh page 14. Observe item visible on the record's holdings list -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170702|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170781&action=edit Bug 37375: Fix holdings table not loading if MARC framework is missing certain 952 subfields When you've catalogued a record with MARC framework that is for some reason missing certain 952 subfields (8, a, b, c, or y), holdings table is no longer loading but stuck in the "Processing..." loader. To test, open Koha in two browser tabs: IN TAB 1 (framework configuration): 1. Create a new MARC framework "TEST", based on the default MARC framework IN TAB 2 (record view): 2. Create a new record using MARC framework "TEST" 3. Add an item to the newly created record 4. Observe item visible on the record's holdings list IN TAB 1 (framework configuration): 5. Delete all 952 subfields in framework "TEST" except: 8, a, b, c, y IN TAB 2 (record view): 6. Refresh page 7. Observe item visible on the record's holdings list 8. Open your browser's console for upcoming error messages Iterating remaining subfields in following order, | <FIELD> | <NAME> ------------------------------------------------------ | 952$8 | row._strings.collection_code | 952$c | row._strings.location | 952$a | row._strings.home_library_id | 952$b | row._strings.holding_library_id | 952$y | row._strings.item_type_id IN TAB 1 (framework configuration): 9. Delete subfield <FIELD> in framework "TEST" IN TAB 2 (record view): 10. Refresh page 11. Observe error "Uncaught TypeError: <NAME> is undefined" (Firefox) (or Cannot read properties of undefined (reading 'str') (Chromium)) 12. Apply patch IN TAB 2: 13. Refresh page 14. Observe item visible on the record's holdings list Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the loading of release notes| |the holdings table for a | |record in the staff | |interface, where the | |framework for a MARC21 | |instance is missing certain | |952 subfields (8, a, b, c, | |or y). The holdings table | |will still now load, before | |it would display as | |"Processing" and not | |display any holding | |details. --- Comment #9 from David Nind <david@davidnind.com> --- I realise this does help fix part of the problem with 24.05+ since bug 33568. So thanks everyone for getting it this far! However, since I'm not familiar enough with how bugs 33568 works (apart from helping speed up the loading of records with very large numbers of items and being API-based), is this what we want? To me, this is saying you can still have issues with your underlying frameworks and record and item data, but we'll still load what we have anyway. I don't think that should hold up this bug in any way, but I think it is perhaps a wider issue that we should think about outside this. Bug 33568 has made the issue of framework and data issues more visible. Or maybe I'm overthinking this! As an aside, do we need a bug to address the equivalent issue for a UNIMARC setup with 995(?) subfields? I'm happy to test and create a bug if you think we do. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joseanjos@gmail.com --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- *** Bug 37544 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 --- Comment #14 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #12)

Please see my patches there, which are similar as yours. However I am wondering if it's a config issue (shouldn't location and ccode exist and be linked with an authorised value category?)

I'm leaning towards this being a configuration issue - I think this is a case where authorized value lists must be used. I've started a chat in the cataloguing channel to get wider input https://chat.koha-community.org/koha-community/pl/1qbrjph7hbgnikzyk3sajfrxqe -- You are receiving this mail because: You are watching all bug changes.

For the item_type_id, holding_library_id and home_library_id I am not sure the test is needed. They subtag must be exist in the framework. It seems there is currently nothing that prevents user from completely deleting

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 --- Comment #16 from Lari Taskula <lari.taskula@hypernova.fi> --- We could add a warning to alert there are configuration issues with the framework. Interesting by the way that "Administration -> MARC bibliographic framework test" doesn't complain about missing subfields. But first I think it is important that we quickly fix the stuck processing loader and display the items regardless of unexpected configuration, and have this patch (or something similar) pushed. We could then handle the discussed issues in a new Bug. (In reply to Jonathan Druart from comment #12) the subfields - I don't know why anyone would do that but as long as they can such cases should be covered and not have the code die unhandled. That's why I added all of them to this patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 --- Comment #18 from Jonathan Druart <jonathan.druart@gmail.com> --- Just tested and you can indeed remove 952$b and things seem to work (apart from this table). I was expecting a warning on the about page or the search_for_data_inconsistencies, but no alert. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170781|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170857&action=edit Bug 37375: Fix holdings table not loading if MARC framework is missing certain 952 subfields When you've catalogued a record with MARC framework that is for some reason missing certain 952 subfields (8, a, b, c, or y), holdings table is no longer loading but stuck in the "Processing..." loader. To test, open Koha in two browser tabs: IN TAB 1 (framework configuration): 1. Create a new MARC framework "TEST", based on the default MARC framework IN TAB 2 (record view): 2. Create a new record using MARC framework "TEST" 3. Add an item to the newly created record 4. Observe item visible on the record's holdings list IN TAB 1 (framework configuration): 5. Delete all 952 subfields in framework "TEST" except: 8, a, b, c, y IN TAB 2 (record view): 6. Refresh page 7. Observe item visible on the record's holdings list 8. Open your browser's console for upcoming error messages Iterating remaining subfields in following order, | <FIELD> | <NAME> ------------------------------------------------------ | 952$8 | row._strings.collection_code | 952$c | row._strings.location | 952$a | row._strings.home_library_id | 952$b | row._strings.holding_library_id | 952$y | row._strings.item_type_id IN TAB 1 (framework configuration): 9. Delete subfield <FIELD> in framework "TEST" IN TAB 2 (record view): 10. Refresh page 11. Observe error "Uncaught TypeError: <NAME> is undefined" (Firefox) (or Cannot read properties of undefined (reading 'str') (Chromium)) 12. Apply patch IN TAB 2: 13. Refresh page 14. Observe item visible on the record's holdings list Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de --- Comment #22 from Jan Kissig <bibliothek@th-wildau.de> --- Hi, can this be ported to 24.05 as well? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Christopher Brannon from comment #23)

Backport +1. We are running into this as well.

What about the w field? We're running into an issue where we get a "month out of range" error if the record contains 0000-00-00, which I guess is a default value if nothing is entered. This field has never been required, but suddenly it is causing problems.

You need to fix the 0000-00-00, those are invalid dates and not defaults and should not exist in your database. There is bug 31143 aiming to create a clean-up script for those. Replace with NULL. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37375 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #26 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 33568 not in 23.11.x -- You are receiving this mail because: You are watching all bug changes.