[Bug 18072] New: Add Koha objects for Branch Transfer Limits
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Bug ID: 18072 Summary: Add Koha objects for Branch Transfer Limits Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: lari.taskula@jns.fi QA Contact: testopia@bugs.koha-community.org Add Koha objects for Branch Transfer Limits -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #1 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 59979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59979&action=edit Bug 18072: Add Koha objects for Branch Transfer Limit This patch also fixes documentation in Koha/Item/Transfer.pm and Koha/Item/Transfers.pm. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #2 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 59980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59980&action=edit Bug 18072: Add Koha::Item->can_be_transferred This patch adds a new method Koha::Item->can_be_transferred. Includes unit test. To test: 1. prove t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #3 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 59981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59981&action=edit Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit functions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |lari.taskula@jns.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59980|0 |1 is obsolete| | --- Comment #4 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 59982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59982&action=edit Bug 18072: Add Koha::Item->can_be_transferred This patch adds a new method Koha::Item->can_be_transferred. Includes unit test. To test: 1. prove t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59979|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 60009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60009&action=edit Bug 18072: Add Koha objects for Branch Transfer Limit This patch also fixes documentation in Koha/Item/Transfer.pm and Koha/Item/Transfers.pm. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59981|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 60010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60010&action=edit Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit functions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59982|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 60011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60011&action=edit Bug 18072: Add Koha::Item->can_be_transferred This patch adds a new method Koha::Item->can_be_transferred. Includes unit test. To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Chris Kirby <chris.kirby@ilsleypubliclibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris.kirby@ilsleypubliclib | |rary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I'd suggest to swap $to, $from in the parameters. ->can_be_transferred( $from, $to ) sounds more logical. When could even pass $hashref { from => $from, to => $to } to avoid ambiguity. I am not sure the tests on the existence of the libraries are necessary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Josef Moravec from comment #6)
Created attachment 60010 [details] [review] Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit functions
Do you plan to replace this subroutine? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #10 from Lari Taskula <lari.taskula@jns.fi> --- (In reply to Jonathan Druart from comment #8)
I'd suggest to swap $to, $from in the parameters. ->can_be_transferred( $from, $to ) sounds more logical. When could even pass $hashref { from => $from, to => $to } to avoid ambiguity. I used this particular order because one may leave $from undefined, in which case the item's holdingbranch will be used as $from, and the typical use case would be simply $item->can_be_transferred($to). I agree with your point for the advantage of using hashref.
(In reply to Jonathan Druart from comment #9)
(In reply to Josef Moravec from comment #6)
Created attachment 60010 [details] [review] [review] Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit functions
Do you plan to replace this subroutine? No. I would like to replace all of them and write proper tests for that, but unfortunately I don't have time to work with that now.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #11 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 60116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60116&action=edit Bug 18072: (QA-follow-up) let Koha::Item->can_be_transferred take HASHref as param This patch changes Koha::Item->can_be_transferred to accept a HASHref as follows: $item->can_be_transferred({ to => $library, from => $library2 }) To test: 1. prove t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #12 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 60117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60117&action=edit Bug 18072: Add Koha::Biblio->can_be_transferred This patch adds a new method Koha::Biblio->can_be_transferred. The method checks if at least one of the item of that biblio can be transferred to desired location. This method will be useful for building a smarter pickup location list for holds, because we will be able to hide those libraries to which none of the items of this biblio can be transferred to due to branch transfer limits (see Bug 7614). To test: 1. prove t/db_dependent/Koha/Biblios.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7614 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 [Bug 7614] Branch transfer limit and holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60011|0 |1 is obsolete| | --- Comment #13 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 60782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60782&action=edit Bug 18072: Add Koha::Item->can_be_transferred This patch adds a new method Koha::Item->can_be_transferred. Includes unit test. To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60116|0 |1 is obsolete| | --- Comment #14 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 60783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60783&action=edit Bug 18072: (QA-follow-up) let Koha::Item->can_be_transferred take HASHref as param This patch changes Koha::Item->can_be_transferred to accept a HASHref as follows: $item->can_be_transferred({ to => $library, from => $library2 }) To test: 1. prove t/db_dependent/Koha/Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Lari Taskula <lari.taskula@jns.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60117|0 |1 is obsolete| | --- Comment #15 from Lari Taskula <lari.taskula@jns.fi> --- Created attachment 60784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60784&action=edit Bug 18072: Add Koha::Biblio->can_be_transferred This patch adds a new method Koha::Biblio->can_be_transferred. The method checks if at least one of the item of that biblio can be transferred to desired location. This method will be useful for building a smarter pickup location list for holds, because we will be able to hide those libraries to which none of the items of this biblio can be transferred to due to branch transfer limits (see Bug 7614). To test: 1. prove t/db_dependent/Koha/Biblios.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #16 from Lari Taskula <lari.taskula@jns.fi> --- Rebased on top of current master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Koha Team AMU <koha.aixmarseille@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60009|0 |1 is obsolete| | --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63683&action=edit Bug 18072: Add Koha objects for Branch Transfer Limit This patch also fixes documentation in Koha/Item/Transfer.pm and Koha/Item/Transfers.pm. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60010|0 |1 is obsolete| | --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63684&action=edit Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit functions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60782|0 |1 is obsolete| | --- Comment #19 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63685&action=edit Bug 18072: Add Koha::Item->can_be_transferred This patch adds a new method Koha::Item->can_be_transferred. Includes unit test. To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60783|0 |1 is obsolete| | --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63686&action=edit Bug 18072: (QA-follow-up) let Koha::Item->can_be_transferred take HASHref as param This patch changes Koha::Item->can_be_transferred to accept a HASHref as follows: $item->can_be_transferred({ to => $library, from => $library2 }) To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60784|0 |1 is obsolete| | --- Comment #21 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 63687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63687&action=edit Bug 18072: Add Koha::Biblio->can_be_transferred This patch adds a new method Koha::Biblio->can_be_transferred. The method checks if at least one of the item of that biblio can be transferred to desired location. This method will be useful for building a smarter pickup location list for holds, because we will be able to hide those libraries to which none of the items of this biblio can be transferred to due to branch transfer limits (see Bug 7614). To test: 1. prove t/db_dependent/Koha/Biblios.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63687|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66724&action=edit Bug 18072: Add Koha::Biblio->can_be_transferred This patch adds a new method Koha::Biblio->can_be_transferred. The method checks if at least one of the item of that biblio can be transferred to desired location. This method will be useful for building a smarter pickup location list for holds, because we will be able to hide those libraries to which none of the items of this biblio can be transferred to due to branch transfer limits (see Bug 7614). To test: 1. prove t/db_dependent/Koha/Biblios.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Very easy conflict with bug 18292 fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63683|0 |1 is obsolete| | --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67049&action=edit Bug 18072: Add Koha objects for Branch Transfer Limit This patch also fixes documentation in Koha/Item/Transfer.pm and Koha/Item/Transfers.pm. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63684|0 |1 is obsolete| | --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67050&action=edit Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit functions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63685|0 |1 is obsolete| | --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67051&action=edit Bug 18072: Add Koha::Item->can_be_transferred This patch adds a new method Koha::Item->can_be_transferred. Includes unit test. To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63686|0 |1 is obsolete| | --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67052&action=edit Bug 18072: (QA-follow-up) let Koha::Item->can_be_transferred take HASHref as param This patch changes Koha::Item->can_be_transferred to accept a HASHref as follows: $item->can_be_transferred({ to => $library, from => $library2 }) To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66724|0 |1 is obsolete| | --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67053&action=edit Bug 18072: Add Koha::Biblio->can_be_transferred This patch adds a new method Koha::Biblio->can_be_transferred. The method checks if at least one of the item of that biblio can be transferred to desired location. This method will be useful for building a smarter pickup location list for holds, because we will be able to hide those libraries to which none of the items of this biblio can be transferred to due to branch transfer limits (see Bug 7614). To test: 1. prove t/db_dependent/Koha/Biblios.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 67054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67054&action=edit Bug 18072: (QA followup) Remove warning from tests This patch removes a warning from Items.t due to bad parameters. It also makes the tests use Test::Exception. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 67209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67209&action=edit Bug 18072: Only accept Koha::Library in parameters I do not think we should allowed branchode and Koha::Library objects, it adds confusion in callers (we never know if we have a branchcode of a library object). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #31 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #30)
Created attachment 67209 [details] [review] Bug 18072: Only accept Koha::Library in parameters
I do not think we should allowed branchode and Koha::Library objects, it adds confusion in callers (we never know if we have a branchcode of a library object).
Does this patch make sense? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67049|0 |1 is obsolete| | Attachment #67050|0 |1 is obsolete| | Attachment #67051|0 |1 is obsolete| | Attachment #67052|0 |1 is obsolete| | Attachment #67053|0 |1 is obsolete| | Attachment #67054|0 |1 is obsolete| | Attachment #67209|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76282&action=edit Bug 18072: Add Koha objects for Branch Transfer Limit This patch also fixes documentation in Koha/Item/Transfer.pm and Koha/Item/Transfers.pm. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76283&action=edit Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit functions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76284&action=edit Bug 18072: Add Koha::Item->can_be_transferred This patch adds a new method Koha::Item->can_be_transferred. Includes unit test. To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76285&action=edit Bug 18072: (QA-follow-up) let Koha::Item->can_be_transferred take HASHref as param This patch changes Koha::Item->can_be_transferred to accept a HASHref as follows: $item->can_be_transferred({ to => $library, from => $library2 }) To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76286&action=edit Bug 18072: Add Koha::Biblio->can_be_transferred This patch adds a new method Koha::Biblio->can_be_transferred. The method checks if at least one of the item of that biblio can be transferred to desired location. This method will be useful for building a smarter pickup location list for holds, because we will be able to hide those libraries to which none of the items of this biblio can be transferred to due to branch transfer limits (see Bug 7614). To test: 1. prove t/db_dependent/Koha/Biblios.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76287&action=edit Bug 18072: (QA followup) Remove warning from tests This patch removes a warning from Items.t due to bad parameters. It also makes the tests use Test::Exception. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76288&action=edit Bug 18072: Only accept Koha::Library in parameters I do not think we should allowed branchode and Koha::Library objects, it adds confusion in callers (we never know if we have a branchcode of a library object). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #31)
(In reply to Jonathan Druart from comment #30)
Created attachment 67209 [details] [review] [review] Bug 18072: Only accept Koha::Library in parameters
I do not think we should allowed branchode and Koha::Library objects, it adds confusion in callers (we never know if we have a branchcode of a library object).
Does this patch make sense?
Yes, yes it does ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76282|0 |1 is obsolete| | Attachment #76283|0 |1 is obsolete| | Attachment #76284|0 |1 is obsolete| | Attachment #76285|0 |1 is obsolete| | Attachment #76286|0 |1 is obsolete| | Attachment #76287|0 |1 is obsolete| | Attachment #76288|0 |1 is obsolete| | --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76292&action=edit Bug 18072: Add Koha objects for Branch Transfer Limit This patch also fixes documentation in Koha/Item/Transfer.pm and Koha/Item/Transfers.pm. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76293&action=edit Bug 18072: Add deprecation warning to C4::Circulation Branch Transfer Limit functions Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76294&action=edit Bug 18072: Add Koha::Item->can_be_transferred This patch adds a new method Koha::Item->can_be_transferred. Includes unit test. To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76295&action=edit Bug 18072: (QA-follow-up) let Koha::Item->can_be_transferred take HASHref as param This patch changes Koha::Item->can_be_transferred to accept a HASHref as follows: $item->can_be_transferred({ to => $library, from => $library2 }) To test: 1. prove t/db_dependent/Koha/Items.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #44 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76296&action=edit Bug 18072: Add Koha::Biblio->can_be_transferred This patch adds a new method Koha::Biblio->can_be_transferred. The method checks if at least one of the item of that biblio can be transferred to desired location. This method will be useful for building a smarter pickup location list for holds, because we will be able to hide those libraries to which none of the items of this biblio can be transferred to due to branch transfer limits (see Bug 7614). To test: 1. prove t/db_dependent/Koha/Biblios.t Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76297&action=edit Bug 18072: (QA followup) Remove warning from tests This patch removes a warning from Items.t due to bad parameters. It also makes the tests use Test::Exception. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76298&action=edit Bug 18072: Only accept Koha::Library in parameters I do not think we should allowed branchode and Koha::Library objects, it adds confusion in callers (we never know if we have a branchcode of a library object). Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18072 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #48 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org