[Bug 32574] New: memberresultst table cannot be column configured in 22.05.x
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Bug ID: 32574 Summary: memberresultst table cannot be column configured in 22.05.x Change sponsored?: --- Product: Koha Version: 22.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com memberresultst needs to use TablesSettings.GetTableSettings but it is using TablesSettings.GetColumns so table settings don't work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 145068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145068&action=edit Bug 32574: [22.05] Fix table settings on member.tt To test: 1. Apply patch 2. Do a patron searches that will return mutiple patrons. 3. Make sure you see the Columns button 4. Make sure you can properly hide columns via Table settings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145068|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 145069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145069&action=edit Bug 32574: [22.05] Fix table settings on member.tt To test: 1. Apply patch 2. Do a patron searches that will return mutiple patrons. 3. Make sure you see the Columns button 4. Make sure you can properly hide columns via Table settings Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes an issue with release notes| |configuring the columns for | |patron search results in | |Koha 22.05 - this should | |now work as expected. The | |columns are now | |configurable using the | |Columns button in the | |search results and in the | |table settings | |(Administration > | |Additional parameters > | |Table settings > Patrons > | |member > memberresultst). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145069|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 145073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145073&action=edit Bug 32574: [22.05] Fix table settings on member.tt To test: 1. Apply patch 2. Do a patron searches that will return mutiple patrons. 3. Make sure you see the Columns button 4. Make sure you can properly hide columns via Table settings Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Confusing area: koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc:function KohaTable(id_selector, dt_parameters, table_settings, add_filters) { koha-tmpl/opac-tmpl/bootstrap/en/includes/columns_settings.inc:function KohaTable(selector, dt_parameters, columns_settings) { First glance this looks wrong too: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: table_settings = [% TablesSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %]; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- But this looks good and should be pushed further to the right RMaint queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.10 released in| | Status|Passed QA |Pushed to oldstable --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x to upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Keywords|rel_22_05_candidate | Status|Pushed to oldstable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32574 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- can't reproduce on 21.11.x, won't backport -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org