[Bug 20814] New: Display issue with 'Saved reports' tabs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Bug ID: 20814 Summary: Display issue with 'Saved reports' tabs Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: severine.queune@bulac.fr QA Contact: testopia@bugs.koha-community.org Created attachment 75546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75546&action=edit Saved report - bullet list instead of tabs Saved report tabs become a bullet list when using the search form on /cgi-bin/koha/reports/reports-home.pl Problem may doesn't appear on some instances, test with sandbox to reproduce (screenshot from Biblibre's sandbox #11). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display issue with 'Saved |Display issue with 'Saved |reports' tabs |reports' tabs when | |memcached is off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- The error happens when memcached is disabled. This eliminates the "Cache expiry" column and messes up the column count for DataTAbles. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20350 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 [Bug 20350] Add column configuration to table of saved reports -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 75549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75549&action=edit Bug 20814: Display issue with 'Saved reports' tabs when memcached is off This patch changes the configuration of the saved reports table so that columns which were previously excluded from the table altogether are now hidden. This prevents a JavaScript error when DataTables tries to reference a missing column. To test, apply the patch and go to Reports -> Use saved. You should have at least one report category configured and assigned to reports in order for the tabs display to be visible. Test the table of saved reports under a variety of these circumstances: - memcached disabled or enabled - reports exist or don't exist which require update from the old marcxml syntax - cache_expiry and/or update columns are configured in Administration -> Columns settings to be shown or hidden The report category tabs and the table should render correctly under all circumstances. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #1)
The error happens when memcached is disabled. This eliminates the "Cache expiry" column and messes up the column count for DataTAbles.
But it should not be disabled now ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75549|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76770&action=edit Bug 20814: Display issue with 'Saved reports' tabs when memcached is off This patch changes the configuration of the saved reports table so that columns which were previously excluded from the table altogether are now hidden. This prevents a JavaScript error when DataTables tries to reference a missing column. To test, apply the patch and go to Reports -> Use saved. You should have at least one report category configured and assigned to reports in order for the tabs display to be visible. Test the table of saved reports under a variety of these circumstances: - memcached disabled or enabled - reports exist or don't exist which require update from the old marcxml syntax - cache_expiry and/or update columns are configured in Administration -> Columns settings to be shown or hidden The report category tabs and the table should render correctly under all circumstances. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76770|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 76932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76932&action=edit Bug 20814: Display issue with 'Saved reports' tabs when memcached is off This patch changes the configuration of the saved reports table so that columns which were previously excluded from the table altogether are now hidden. This prevents a JavaScript error when DataTables tries to reference a missing column. To test, apply the patch and go to Reports -> Use saved. You should have at least one report category configured and assigned to reports in order for the tabs display to be visible. Test the table of saved reports under a variety of these circumstances: - memcached disabled or enabled - reports exist or don't exist which require update from the old marcxml syntax - cache_expiry and/or update columns are configured in Administration -> Columns settings to be shown or hidden The report category tabs and the table should render correctly under all circumstances. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Memcache should not be off anymore, but this does not hurt. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Bug 20814 depends on bug 20350, which changed state. Bug 20350 Summary: Add column configuration to table of saved reports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20814 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 20350 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org