[Bug 32542] New: Coce images not appearing in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Bug ID: 32542 Summary: Coce images not appearing in staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl To recreate: 1. Have Coce on, use 'https://coce.bywatersolututions.com' as the CoceProviders if needed. Select all providers 2. Turn on IntranetCoce and OpacCoce. 3. Do a OPAC search to retrieve some Coce images on both the OPAC results page and detail. 4. Do the same search and look at the same detail pages in the staff client. Nothing appears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- It seems like what is happening here is that we are removing the containers prematurely. coce.js fetches the images and adds them but not before other JS in results.js is deciding there is no image and removing the container. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Esther Melander <estherm@sodaspringsid.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |estherm@sodaspringsid.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #2 from Esther Melander <estherm@sodaspringsid.com> --- This problem appears to be intermittent and random. For example, do a catalog search in the staff interface and the image will not show. Do the same search a few days later and the image shows. When doing a search and building a list with lots of different titles, some cover images show, others do not. We have tested different browsers, deleting cache, having librarians search on different browsers and computers, and the book covers will show one place and not another. We cannot pinpoint a reproducible show/not show of book cover images. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 pierre.genty@biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre.genty@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Esther Melander from comment #2)
This problem appears to be intermittent and random. For example, do a catalog search in the staff interface and the image will not show. Do the same search a few days later and the image shows. When doing a search and building a list with lots of different titles, some cover images show, others do not. We have tested different browsers, deleting cache, having librarians search on different browsers and computers, and the book covers will show one place and not another. We cannot pinpoint a reproducible show/not show of book cover images.
Esther, the problem being intermittent and random makes sense to me. When the call to Coce takes too long we removed the parent container. So this can depend on the speed of your network connection. I can more reliably recreate the issue when I clear my cache, as it then takes more time to load the images when nothing is cached. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Michael Adamyk <madamyk@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk@ckls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Coce images not appearing |Coce images not appearing |in staff client |in staff interface -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Danielle <danielle.meininger@tillamookcounty.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle.meininger@tillamoo | |kcounty.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32307 CC| |nick@bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32307 [Bug 32307] Chocolat image viewer broken in the staff interface when Coce is enabled -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #4 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 186842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186842&action=edit Bug 32542: Add 'wait_for_images' to results.js' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #5 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- I think we need the fix from bug 32307 on the results page too I tried, Coce is at least called now, but it still doesn't show the images -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Nick, your patch is working for me. The first try I saw the warning in the console, but once the images are cached they appeared. Maybe we should extend the timeout then? But it's 5 seconds already... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #6)
Nick, your patch is working for me. The first try I saw the warning in the console, but once the images are cached they appeared. Maybe we should extend the timeout then? But it's 5 seconds already...
It's actually the coce server that is slow. The request takes 8 seconds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6)
Nick, your patch is working for me. The first try I saw the warning in the console, but once the images are cached they appeared. Maybe we should extend the timeout then? But it's 5 seconds already...
This is exactly what I experience when I test. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35647 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- *** Bug 35647 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #10 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Created attachment 198968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198968&action=edit Bug 32542: Await all image loads before setting coce.done Patch from commit 5e70a1a -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tadeusz@sosnierz.com --- Comment #11 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- ^ This resolves the issue for me: `done` was set prematurely for multiple image loads, so verify_cover_images was giving up before stuff has actually arrived. Now we wait until all `onload` events trigger, which solves the issue (for me, locally anyway). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot@biblibre.co | |m --- Comment #12 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Hi, Does the patch require a sign off ? I’ve tested it and the behaviour seems fine to me. It’s worth noting that Chromium without the patch handles cover images better... So for now maybe the status can be updated no ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186842|0 |1 is obsolete| | Attachment #198968|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #13 from Jan Kissig <bibliothek@th-wildau.de> --- I followed this testplan: 1. a) Set system preference CoceHost to 'https://coce.bywatersolututions.com' select some CoceProviders b) I also tested on a local Coce Server 2. enabled system preference IntranetCoce 3. Additionaly other cover services AmazonCoverImages can be anabled 4. Searched in staff for Perl 5. a) when only Coce was enabled: No cover image available was shown b) when Coce and other service was enabled: Only cover from other service appeared 6. applied patch and reloaded the results page: 7 a) On a slow coce Server the spinner was visible for 5 seconds, then console said Could not retrieve the images other images appeared On a fast coce server the cover images appeared b) All cover images including the ones from coce appeared -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #14 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201044&action=edit Bug 32542: Add 'wait_for_images' to results.js' Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #15 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201045&action=edit Bug 32542: Await all image loads before setting coce.done Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bibliothek@th-wildau.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |baptiste.wojtkowski@biblibr |y.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tadeusz@sosnierz.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> ---
144 if (!loaded && counter_wait < 50) {// Do not wait more than 5 > seconds 145 window.setTimeout(function(){wait_for_images(cb);}, 100); 146 } else { 147 if (counter_wait >= 50 ) { 148 console.log("Could not retrieve the images") 149 }
All three numbers depend from each others, for sake of maintainability please use one constant there. QA tools are not happy : Processing files [RUNNING] koha-tmpl/intranet-tmpl/js/coce.js [RUNNING] koha-tmpl/intranet-tmpl/prog/js/pages/results.js [PASS] koha-tmpl/intranet-tmpl/js/coce.js [FAIL] koha-tmpl/intranet-tmpl/prog/js/pages/results.js Result: [PASS] koha-tmpl/intranet-tmpl/js/coce.js [FAIL] koha-tmpl/intranet-tmpl/prog/js/pages/results.js FAIL forbidden_patterns forbidden pattern: console.log (line 148) FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/js/pages/results.js` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #17 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 206686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206686&action=edit Bug 32542: (QA follow-up) Use constants for cover image wait timeout and tidy files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201044|0 |1 is obsolete| | Attachment #201045|0 |1 is obsolete| | Attachment #206686|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #18 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 206698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206698&action=edit Bug 32542: Add 'wait_for_images' to results.js' Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #19 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 206699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206699&action=edit Bug 32542: Await all image loads before setting coce.done Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #20 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 206700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206700&action=edit Bug 32542: (QA follow-up) Use constants for cover image wait timeout and tidy files Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32542 --- Comment #21 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org