[Bug 17787] New: Suppressed items seems so still be included in number of search results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Bug ID: 17787 Summary: Suppressed items seems so still be included in number of search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: viktor.sarge@regionhalland.se QA Contact: testopia@bugs.koha-community.org We have a use case where like 99% of the collection is hidden and only a few selected items are displayed in the opac (by showing their covers up front on the main page). When going to the detail page and clicking the link for an author that has a long list of records (but only one visible in the opac) I might get indication of 63 hits in the search results and a the links to pages 1,2,3 etc for search results. Only problem is that there is actually only one result since the rest are suppressed. My guess is that the code calculating the number of hits and creating links to the pages of search results is not talking to the suppression system. I could not find any open bugs about this. Perhaps because our use of suppression is a bit of a edge case(?) I ended up "solving" the problem by removing the links on author etc. since we don't use search anyhow. I'll likely not research the issue further, but I felt I should at least report it and keep an eye out. All input is welcome. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |koha-bugs@lists.koha-commun | |ity.org Summary|Suppressed items seems so |Suppressed items seem to be |still be included in number |included in count of search |of search results |results Component|OPAC |Searching -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #1 from Séverine Queune <severine.queune@bulac.fr> --- Still valid. Same behaviour when OpacHiddenItems is used. See screenshot attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 --- Comment #2 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 79234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79234&action=edit Wrong number of results when opachiddenitems is used -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suppressed items seem to be |Suppressed items included |included in count of search |in count of search results |results | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rogan.hamby@gmail.com --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 24142 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suppressed items included |Hidden items included in |in count of search results |count of search results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24403 [Bug 24403] [OMNIBUS] OpacHiddenItems should hide items everywhere in the OPAC -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18989 CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Gérard Simon Voyer <simon.voyer@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simon.voyer@collecto.ca --- Comment #4 from Gérard Simon Voyer <simon.voyer@collecto.ca> --- Bonjour everyone! I've had my shot at this and broke my logic circuits hard. At first, I tried complex matching rules to try while opening loops done over @newresults (from opac/opac-search.pl) to get something. That's when I realized nothing ever matched. Then I realized that @newresults was already filtered, which is why I had no match. So in the end : my $results_count = scalar @newresults; ... ... if ($results_hashref->{$server}->{"hits"}){ $total = $results_count; } ... ... $template->param(total => $total); gave me the right count... I'll have to go document myself on how to propose a fix on this issue, but I think the explanation above can give anyone looking for an answer the missing piece. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Seems correct with OpacHiddenItems now on master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #5)
Seems correct with OpacHiddenItems now on master.
staff detail: https://snipboard.io/B1JPT9.jpg opac search : https://snipboard.io/zMv1qo.jpg OpacHiddenItems: itype: [VM] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 --- Comment #7 from Gérard Simon Voyer <simon.voyer@collecto.ca> --- Hi Jonathan! Is there anything I have to do to follow-up and possibly help you close the bug? I'm new and joining IRC today so I can start seasoning myself as a Koha dev. I realize that the 40+ Koha boxes we maintain and host at Collecto are using a codebase that is shifting towards an important an uncomfortable diff with the master branch. I worked around using $results_count = scalar @newresults; if ($hits > results_per_page) { $total = $results_count } else { $total = hits } But this seems to base itself off the fact that our users will not notice biased results counts if the results span over more than a page. I'd rather use official patches from veteran Koha devs! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- My opinion, is that we should add indexes for hidden things, and implicitly use them so records are not included in search results. As opposed to doing funky arithmetic calculations afterwards. This would solve many other issues like hidden records being included in facets, etc. I can commit to work on this after the 21.05 release. And would love to have help with testing, from people participating in this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 --- Comment #9 from Gérard Simon Voyer <simon.voyer@collecto.ca> --- Currently setting up a fresh docker-testing box so I can sign-off on a few bugs I've commented on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 --- Comment #10 from Gérard Simon Voyer <simon.voyer@collecto.ca> --- (In reply to Tomás Cohen Arazi from comment #8) Also the smartest thing I've heard today, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 --- Comment #11 from Gérard Simon Voyer <simon.voyer@collecto.ca> --- Sorry for the wait, it's a beautiful day outside in Québec. Tests made with a fresh koha-testing-docker setup on "master" branch of the GitLab repo (https://gitlab.com/koha-community/Koha) 1 - Search for "dance" in OPAC 2 - "Your search has returned 3 results" (https://snipboard.io/TalPXj.jpg) -- good 3 - add "itype: [MU]" to the OpacHiddenItems preference 4 - "Your search has returned 3 results" (https://snipboard.io/oFKXML.jpg) -- bug in action Am I still allowed to propose my glitchy bugfix? It would be good practice for me to test how to submit a first fix, even if it's still not going to be pushed anywhere else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 --- Comment #12 from Gérard Simon Voyer <simon.voyer@collecto.ca> --- Created attachment 120721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120721&action=edit Bug 17787: Hidden items included in count of search results opac-search.pl does not consider items hidden by OpacHiddenItems in the search count. This attachment aims at fixing the count for visual harmony, since the bug lives on but is only reported in cases where the results count is greater than the value of results_per_page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |lucas@bywatersolutions.com --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> --- This is still a problem in master and this bugfix seems to fix the problem, I am setting it to NSO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120721|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 135460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135460&action=edit Bug 17787: Hidden items included in count of search results opac-search.pl does not consider items hidden by OpacHiddenItems in the search count. This attachment aims at fixing the count for visual harmony, since the bug lives on but is only reported in cases where the results count is greater than the value of results_per_page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #15 from David Nind <david@davidnind.com> --- I tested (using koha-testing-docker) by: 1. Searching in the OPAC for 'doctor who' - "Your search returned 4 results", four results listed (1x book, 3 x visual resources) 2. Changed OpacHiddenItems- itype: [BK] 3. Searched again as per step 1 - shows "Your search returned 4 results", three results listed (3 x visual resources). 4. Applied patch. 5. Now number of search results matches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Failed QA --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- After testing many search terms to find a case that is closer to the original report (multiple pages of results), here is one and it doesn't work. == Test plan == 1. Use sample data 2. Change OpacHiddenItems to «itype: [BK]» 3. Search in the OPAC for 'man' 4. 29 or 28 results depending on SearchEngine being Zebra of ElasticSearch Actually there are a handful of results on every page. Which is wrong because it shouldn't say 29 but around 10 and they should be on one page 5. Apply patch and restart service 6. Redo the search 7. Number of hits should match the actual number and be on one page. But last step doesn't happen with the current patch. I found the reason: comment 7:
I worked around using [...] But this seems to base itself off the fact that our users will not notice biased results counts if the results span over more than a page.
comment 11:
my glitchy bugfix
So patch isn't ready, it was just a workaround solving part of the issue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Noémie Labine <noemie.labine@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |noemie.labine@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31114 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org