[Bug 17588] New: Move GetMemberIssuesAndFines to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Bug ID: 17588 Summary: Move GetMemberIssuesAndFines to Koha::Patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Depends on| |17578, 17586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 [Bug 17578] Replace GetMemberDetails with GetMember https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 [Bug 17586] Add the Koha::Account::Lines->get_balance method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17584 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 [Bug 17584] Add the Koha::Patron->get_issues method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57339&action=edit Bug 17588: Koha::Patrons - Move GetMemberIssuesAndFines The GetMemberIssuesAndFines subroutine used to retrieve the issues, overdues and fines for a given patron. Most of the time, only 1 or 2 of these values were used. This patch removes this subroutine and uses the new get_issues, get_overdues and get_balance method from Koha::Patron and Koha::Account::Lines. Test plan: 1/ Add overdues, issues and fines to different patrons 2/ On the checkout, checkin and patron search result and the patron detail pages, these 3 informations, if displayed before this patch, must be correctly displayed. 3/ Use the batch patron deletion tool and make sure that patrons with a balance > 0 are not deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57339|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57992&action=edit Bug 17588: Koha::Patrons - Move GetMemberIssuesAndFines The GetMemberIssuesAndFines subroutine used to retrieve the issues, overdues and fines for a given patron. Most of the time, only 1 or 2 of these values were used. This patch removes this subroutine and uses the new get_issues, get_overdues and get_balance method from Koha::Patron and Koha::Account::Lines. Test plan: 1/ Add overdues, issues and fines to different patrons 2/ On the checkout, checkin and patron search result and the patron detail pages, these 3 informations, if displayed before this patch, must be correctly displayed. 3/ Use the batch patron deletion tool and make sure that patrons with a balance > 0 are not deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57993&action=edit Bug 17588: get_account_lines->get_balance has been replace with account->balance On previous bugs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Bug 17588 depends on bug 17578, which changed state. Bug 17578 Summary: Replace GetMemberDetails with GetMember https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17578 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Bug 17588 depends on bug 17586, which changed state. Bug 17586 Summary: Add the Koha::Account::Lines->get_balance method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17586 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58430&action=edit Bug 17588: ->get_issues has been replaced with ->checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Bug 17588 depends on bug 17584, which changed state. Bug 17584 Summary: Add the Koha::Patron->checkouts method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17584 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57992|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58759&action=edit [SIGNED-OFF] Bug 17588: Koha::Patrons - Move GetMemberIssuesAndFines The GetMemberIssuesAndFines subroutine used to retrieve the issues, overdues and fines for a given patron. Most of the time, only 1 or 2 of these values were used. This patch removes this subroutine and uses the new get_issues, get_overdues and get_balance method from Koha::Patron and Koha::Account::Lines. Test plan: 1/ Add overdues, issues and fines to different patrons 2/ On the checkout, checkin and patron search result and the patron detail pages, these 3 informations, if displayed before this patch, must be correctly displayed. 3/ Use the batch patron deletion tool and make sure that patrons with a balance > 0 are not deleted Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57993|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58760&action=edit [SIGNED-OFF] Bug 17588: get_account_lines->get_balance has been replace with account->balance On previous bugs Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58430|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58761&action=edit [SIGNED-OFF] Bug 17588: ->get_issues has been replaced with ->checkouts Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 59154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59154&action=edit Bug 17588: Koha::Patrons - Move GetMemberIssuesAndFines The GetMemberIssuesAndFines subroutine used to retrieve the issues, overdues and fines for a given patron. Most of the time, only 1 or 2 of these values were used. This patch removes this subroutine and uses the new get_issues, get_overdues and get_balance method from Koha::Patron and Koha::Account::Lines. Test plan: 1/ Add overdues, issues and fines to different patrons 2/ On the checkout, checkin and patron search result and the patron detail pages, these 3 informations, if displayed before this patch, must be correctly displayed. 3/ Use the batch patron deletion tool and make sure that patrons with a balance > 0 are not deleted Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 59155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59155&action=edit Bug 17588: get_account_lines->get_balance has been replace with account->balance On previous bugs Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 59156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59156&action=edit Bug 17588: ->get_issues has been replaced with ->checkouts Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Version|unspecified |master --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Does not apply ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58759|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58760|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58761|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 --- Comment #12 from Julian Maurice <julian.maurice@biblibre.com> --- Previous patches were not obsoleted. Sorry for that. This should apply correctly now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17588 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer@bsz-bw.de --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org