[Bug 16116] New: Change of issue publication date doesn't reflect on the next issue generated
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Bug ID: 16116 Summary: Change of issue publication date doesn't reflect on the next issue generated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: francois.charbonnier@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com I noticed in 3.20, but also in master, that you can't change the next issue publication date when editing a serial subscription anymore. And, that we lost a feature I liked when receiving a new issue. Before 3.20, when receiving a new issue, you could change the "Published on" date and Koha will adjust the subscription's next issue publication date for all the new issues to be received. Test plan : 1. In Cataloging > New with Z39.50, look for issn = 1536-6596 (National Geographic) into the LCC z39.60 server. Add the record. 2. Add a new subscription for National Geographic. Fill-in the form. - use the default values of the first page - for the second page : First issue publication date = 10/01/2016 Frequency = 1/month Subscription lenght = 12 issues Subscription start date = 01/01/2016 Numbering pattern = Number Begins with = 1 - Save 3. Receive the first issue. Change the status to "received". Note that the "Published on" date = 10/01/2016. This date goes to the "Date published" column in the serial collection page. 4. The second issue is generated. Edit serial to receive the issue. 5. Change the "Published on" date to 11/02/2016. Change the status to "received". Save. 6. "Date published" for the next issue generated is : 10/03/2016. Before 3.20, it would have been "11/03/2016". It was a shortcut to change the Next issue publication date from the subscription. 7. Edit the subscription. Change the "Next issue publication date" to : 11/03/2016. 8. Go back to the serial collection page. Date published for the last expected issue = 11/03/2016 9. Receive the issue. Change the status to "received". Save 10. The next issue generated is 10/04/2016. It should have been 11/04/2016. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Francois Charbonnier <francois.charbonnier@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12671 --- Comment #1 from Francois Charbonnier <francois.charbonnier@inlibro.com> --- Could it be https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 (Guess next serial date when there are several issues per unit) that broke this feature? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 [Bug 12671] Guess next serial date when there are several issues per unit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Gaetan Boisson <gaetan.boisson@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson@biblibre.com --- Comment #2 from Gaetan Boisson <gaetan.boisson@biblibre.com> --- Confirmed. I was not able to change the next issue date in a durable fashion. This might be a bigger problem than it seems, because in certain situations (a "double issue" that skips a month, that is number 36 is for February and march, and number 37 is for April) this is the recommended way of handling it. I haven't tested this toroughly yet. Maybe the number guessing method makes sure we don't get two issues for April, but there would be a lot of edge cases to try. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Francois Charbonnier from comment #1)
Could it be https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 (Guess next serial date when there are several issues per unit) that broke this feature?
Probably. I just looked at the code quickly and I think the problem comes from the _get_next_date_* subroutines where we force the day (or day and month) to the same as firstacquidate. Maybe it's not necessary. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |bouzid.fergani@inlibro.com |ity.org | CC| |bouzid.fergani@inlibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 --- Comment #4 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 58265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58265&action=edit Bug 16116 - Fix problem change of issue publication date doesn't reflect on the next issue generated Test plan : 1. In Cataloging > New with Z39.50, look for issn = 1536-6596 (National Geographic) into the LCC z39.60 server. Add the record. 2. Add a new subscription for National Geographic. Fill-in the form. - use the default values of the first page - for the second page : First issue publication date = 10/01/2016 Frequency = 1/month Subscription lenght = 12 issues Subscription start date = 01/01/2016 Numbering pattern = Number Begins with = 1 - Save 3. Receive the first issue. Change the status to "received". Note that the "Published on" date = 10/01/2016. This date goes to the "Date published" column in the serial collection page. 4. The second issue is generated. Edit serial to receive the issue. 5. Change the "Published on" date to 14/02/2016. Change the status to "received". Save. 6. "Date published" for the next issue generated is : 14/03/2016. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 --- Comment #5 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 58266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58266&action=edit Bug 16116 - Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Bouzid <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58265|0 |1 is obsolete| | Attachment #58266|0 |1 is obsolete| | --- Comment #6 from Bouzid <bouzid.fergani@inlibro.com> --- Created attachment 61002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61002&action=edit Bug 16116 - Fix problem change of issue publication date doesn't reflect on the next issue generated Test plan : 1. In Cataloging > New with Z39.50, look for issn = 1536-6596 (National Geographic) into the LCC z39.60 server. Add the record. 2. Add a new subscription for National Geographic. Fill-in the form. - use the default values of the first page - for the second page : First issue publication date = 10/01/2016 Frequency = 1/month Subscription lenght = 12 issues Subscription start date = 01/01/2016 Numbering pattern = Number Begins with = 1 - Save 3. Receive the first issue. Change the status to "received". Note that the "Published on" date = 10/01/2016. This date goes to the "Date published" column in the serial collection page. 4. The second issue is generated. Edit serial to receive the issue. 5. Change the "Published on" date to 14/02/2016. Change the status to "received". Save. 6. "Date published" for the next issue generated is : 14/03/2016. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 --- Comment #7 from Bouzid <bouzid.fergani@inlibro.com> --- Hi All, I deteted patch unit test because it test a local sub. Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61002|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 62163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62163&action=edit [SIGNED-OFF] Bug 16116 - Fix problem change of issue publication date doesn't reflect on the next issue generated Test plan : 1. In Cataloging > New with Z39.50, look for issn = 1536-6596 (National Geographic) into the LCC z39.60 server. Add the record. 2. Add a new subscription for National Geographic. Fill-in the form. - use the default values of the first page - for the second page : First issue publication date = 10/01/2016 Frequency = 1/month Subscription lenght = 12 issues Subscription start date = 01/01/2016 Numbering pattern = Number Begins with = 1 - Save 3. Receive the first issue. Change the status to "received". Note that the "Published on" date = 10/01/2016. This date goes to the "Date published" column in the serial collection page. 4. The second issue is generated. Edit serial to receive the issue. 5. Change the "Published on" date to 14/02/2016. Change the status to "received". Save. 6. "Date published" for the next issue generated is : 14/03/2016. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Would it be possible for Francois, Gaetan or Julian to test this patch too? I am not so sure if the proposed changes really solve all problems in this area. Another signoff would not be a bad idea. Another point (referring to an earlier remark):
Before 3.20, when receiving a new issue, you could change the "Published on" date and Koha will adjust the subscription's next issue publication date for all the new issues to be received.
Would it be an idea to add an option to the subscription that makes it possible to rebase issue dates somehow ? We now have a 'buggy' mix of using last issue and first acqui date. Maybe an additional base date to use optionally (overruling first acqui)? Other ideas ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving this patch out of the SO queue for now. This should not be pushed in its current form just before release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marcel, can this go back into the queue now? I am currently trying to figure out a way for the library to change the date an issue is published and am failing... I think this really needs a solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #11)
Hi Marcel, can this go back into the queue now?
I am currently trying to figure out a way for the library to change the date an issue is published and am failing... I think this really needs a solution.
I have spent some more time on this problem. Please look at bug 18356, bug 18607 and bug 18697. That solution also includes releasing the link with firstacqui date and solves several computational problems. It is imo a completer solution and supported by tests. For that reason I would propose to close this bug if these patches have been QAed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Closing this bug in favor of bug 18356, bug 18607 and bug 18697. These have been pushed recently. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |DUPLICATE --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- *** This bug has been marked as a duplicate of bug 18356 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16116 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com, | |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org