[Bug 8827] New: YUI CSS files no longer found on Yahoo servers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 Priority: P5 - low Change sponsored?: --- Bug ID: 8827 Assignee: oleonard@myacpl.org Summary: YUI CSS files no longer found on Yahoo servers Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: NEW Version: master Component: OPAC Product: Koha If you have your yuipath preference set to retrieve YUI files from Yahoo's servers, your OPAC layout will break because the CSS files are no longer at the old location. The short-term fix is to always retrieve YUI CSS from the local file system (as we do in the staff client). A longer-term fix is to remove the yuipath preference altogether (since it is a goal to eliminate YUI) or generalize it to include other assets like jQuery which can also be found on CDNs like Google's (see http://jquery.com/download/ for the currently available CDN links). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 12525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12525&action=edit Bug 8827 - YUI CSS files no longer found on Yahoo servers This patch removes the [% yuipath %] variable from the link to the YUI CSS files in the OPAC and adds a hard-coded path to the local files. To test, set your yuipath system preference to "from Yahoo's servers," clear your browser cache, and view the OPAC. The style and layout should look the same as if your yuipath preference were set to "local." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12525|0 |1 is obsolete| | --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 12526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12526&action=edit [SIGNED_OFF] Patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Fixes broken display. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Would it be an idea to add some text next to the pref, mentioning that css is always local and javascript comes from Yahoo, or something like that? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #2)
Created attachment 12526 [details] [SIGNED_OFF] Patch
works as expected, passing QA... $ koha-qa.pl -c 1 testing 1 commit(s) (applied to commit 0a35b26) * 47fd399 Bug 8827 - YUI CSS files no longer found on Yahoo servers koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc * koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8867 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|8867 | --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #4)
Would it be an idea to add some text next to the pref, mentioning that css is always local and javascript comes from Yahoo, or something like that?
great idea - i've added a new bug to track this http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8867 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 --- Comment #7 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #6)
(In reply to comment #4)
Would it be an idea to add some text next to the pref, mentioning that css is always local and javascript comes from Yahoo, or something like that?
great idea - i've added a new bug to track this
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8867
ahh, ignore this bug - i just clicked that its CSS *only*, thats local :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8867 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_8 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Patch does not apply to 3.8.x, please resubmit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8827 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Version|3.8 |3.10 Resolution|--- |FIXED --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #9)
Patch does not apply to 3.8.x, please resubmit.
Not applicable to 3.8.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org