[Bug 24117] New: Patron does not get debarred upon returning overdue item if syspref item-level_itypes is set to biblio and item does not have type information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 Bug ID: 24117 Summary: Patron does not get debarred upon returning overdue item if syspref item-level_itypes is set to biblio and item does not have type information Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: pjamorim91@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To reproduce: 1) Have item-level_itypes sys pref set to "biblio" 2) Return an overdue item which biblio record has correct type information but item itself does not (which should be fine because 1)) 3) Notice that the item is returned just fine, but the patron does not get debarred, respecting circulation rules correctly configured. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 --- Comment #1 from Pedro Amorim <pjamorim91@gmail.com> --- Created attachment 95820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95820&action=edit Bugfix commit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 --- Comment #2 from Pedro Amorim <pjamorim91@gmail.com> --- Created attachment 95822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95822&action=edit Proposed fix for reported bug -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 Pedro Amorim <pjamorim91@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95820|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|koha-bugs@lists.koha-commun |pjamorim91@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Needs Signoff |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Pedro, As _debar_user_on_return is only called once I would suggest you to pass $item instead of $item_unblessed. It will avoid to pass yet another parameter to this subroutine. Also you will need to provide a test plan in the commit message, as well as a better commit title https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 --- Comment #4 from Pedro Amorim <pjamorim91@gmail.com> --- Hi Jonathan, Thank you so much for your feedback. In the past, the $item parameter was changed to $item_unblessed, by this commit https://github.com/Koha-Community/Koha/commit/31c29fd31f557306233e6a2936148a... I opted to leave the code as it was previously written and add the parameter I needed, precisely because the function is only called once. I did not have the opportunity to test the behaviour of _GetCircControlBranch when $item is being used instead of $item_unblessed but I'll try test it soon and follow your instructions. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org