http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14427 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9006 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14427 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|KOHAVERSION hiding in |Use Koha::version() instead |installer/install.pl |of C4::Context->KOHAVERSION -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14427 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14427 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Also: git grep KOHAVERSION Should only show release notes entry. :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14427 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- The only problem is that the generated log file is named updatedatabase_2015-06-22T13:18:26_3.2100009_.log when it should be updatedatabase_2015-06-22T13:23:31_3.2100009_3.2100010.log -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14427 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40424|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40458&action=edit Bug 14427: Use Koha::version instead of C4::Context->KOHAVERSION While testing bug 9006, I discovered this gem in installer/install.pl TEST PLAN --------- 1) back up DB 2) drop db and create db 3) git reset --hard origin/3.20.x 4) run web installer and all sample data 5) git reset --hard origin/master 6) empty your koha intranet error log 7) run web installer to upgrade -- there will be warnings regarding regex around installer/install.pl line 328 or so. grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log 8) repeat steps 2-6 9) apply this patch 10) run web installer to upgrade -- no regex warnings. grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log 11) koha qa test tools Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14427 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40458|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 40771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40771&action=edit Bug 14427: Use Koha::version instead of C4::Context->KOHAVERSION While testing bug 9006, I discovered this gem in installer/install.pl TEST PLAN --------- 1) back up DB 2) drop db and create db 3) git reset --hard origin/3.20.x 4) run web installer and all sample data 5) git reset --hard origin/master 6) empty your koha intranet error log 7) run web installer to upgrade -- there will be warnings regarding regex around installer/install.pl line 328 or so. grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log 8) repeat steps 2-6 9) apply this patch 10) run web installer to upgrade -- no regex warnings. grep "\$kohaversion" ~/koha-dev/var/logs/koha-error_log 11) koha qa test tools Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14427 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.