http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37268&action=edit Bug 13915 - Inventory tool no longer hides items with date last seen greater than the inventory date In previous versions of Koha, selecting an inventory date would filter out items that had been seen since the "Inventory date". Bug 12631 changed the inventory tool so that this behavior only occurs when a barcodes list file is uploaded for comparison. Test Plan: 1) Apply this patch 2) Run the inventory tool with no set parameters 3) Mark the first item as seen 4) Rerun the tool with only a date last seen parameter of yesterday 5) Note the item you marked as seen is no longer on the list -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915 --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 37333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37333&action=edit [Signed-off] Bug 13915 - Inventory tool no longer hides items with date last seen greater than the inventory date In previous versions of Koha, selecting an inventory date would filter out items that had been seen since the "Inventory date". Bug 12631 changed the inventory tool so that this behavior only occurs when a barcodes list file is uploaded for comparison. Test Plan: 1) Apply this patch 2) Run the inventory tool with no set parameters 3) Mark the first item as seen 4) Rerun the tool with only a date last seen parameter of yesterday 5) Note the item you marked as seen is no longer on the list Followed test plan. Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The search option is named 'inventory date' - If I understood correctly, this could be more clear as 'inventory date before'? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bit confused as the following lines were introduced by bug 12631 and are undone here: Patch from 12631: + my $paramdatelastseen = ($compareinv2barcd) ? $datelastseen : ''; + ($inventorylist, $totalrecords) = GetItemsForInventory($minlocation, $maxlocation, $location, $itemtype, $ignoreissued, $paramdatelastseen, $branchcode, $branch, 0, undef, $staton); Patch attached to this bug: - my $paramdatelastseen = ($compareinv2barcd) ? $datelastseen : ''; - ($inventorylist, $totalrecords) = GetItemsForInventory($minlocation, $maxlocation, $location, $itemtype, $ignoreissued, $paramdatelastseen, $branchcode, $branch, 0, undef, $staton); + ($inventorylist, $totalrecords) = GetItemsForInventory($minlocation, $maxlocation, $location, $itemtype, $ignoreissued, $datelastseen, $branchcode, $branch, 0, undef, $staton); Are we sure there is no regression on bug 12631 by this change? I had problems testing 12631 when I tried, so not sure. Can you please take a look and explain? The test plan works for me - I'd just like to be careful. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13915 Tom Misilo <misilot@fit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |misilot@fit.edu -- You are receiving this mail because: You are watching all bug changes.