[Bug 18747] New: Select All in Add Patron Option in Patron Lists only selects the first 20 entries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Bug ID: 18747 Summary: Select All in Add Patron Option in Patron Lists only selects the first 20 entries Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: karen@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Select all only selects the first 20 records in the Add Patrons option of Patron Lists, even if you change the view to show 50, 100, or all options. The expected behavior is that Select All would select all the options. To recreate this issue, go to Patrons -> Patron Lists -> Select a patron list -> Select Add Patrons in the Action button menu. Next, select 50, 100 or All entries to show. Then, click on Select All. Only the first 20 entries are selected, not all of the entries on the screen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Patrick Robitaille <patrick.robitaille@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille@collecto | |.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |17.05 --- Comment #1 from Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> --- Hi, Problem is still present in 17.05. Anyone works on this? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 AspenCat Team <aspencatteam@clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam@clicweb.org --- Comment #2 from AspenCat Team <aspencatteam@clicweb.org> --- We have also noticed this behavior. It makes batch edits of patrons a clunky process of adding 20 at a time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|17.05 |master --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 JaTara Barnes <jendayi30@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jendayi30@gmail.com --- Comment #4 from JaTara Barnes <jendayi30@gmail.com> --- Still valid in 20.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 --- Comment #5 from JaTara Barnes <jendayi30@gmail.com> --- Still valid in 20.05 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 124193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124193&action=edit Bug 18747: Select All in Add Patron Option in Patron Lists only selects the first 20 entries This patch corrects the JavaScript functions for the "select all" and "clear all" action when viewing patrons in a list. Before this correction, checkboxes which were previously in hidden table rows would not be checked. To test, apply the patch and go to Patrons -> Patron Lists - View a patron list - If necessary, add multiple patrons to the list so that the number exceeds 20. - Change the number of entries shown by the DataTable: Show [ 50 ] entries. - Click "Select all." All visible checkboxes should be checked. - Click "Clear all." All checkboxes should be unchecked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124193|0 |1 is obsolete| | --- Comment #7 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 124328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124328&action=edit Bug 18747: Select All in Add Patron Option in Patron Lists only selects the first 20 entries This patch corrects the JavaScript functions for the "select all" and "clear all" action when viewing patrons in a list. Before this correction, checkboxes which were previously in hidden table rows would not be checked. To test, apply the patch and go to Patrons -> Patron Lists - View a patron list - If necessary, add multiple patrons to the list so that the number exceeds 20. - Change the number of entries shown by the DataTable: Show [ 50 ] entries. - Click "Select all." All visible checkboxes should be checked. - Click "Clear all." All checkboxes should be unchecked. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #8 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Works as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124328|0 |1 is obsolete| | --- Comment #9 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 125024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125024&action=edit Bug 18747: Select All in Add Patron Option in Patron Lists only selects the first 20 entries This patch corrects the JavaScript functions for the "select all" and "clear all" action when viewing patrons in a list. Before this correction, checkboxes which were previously in hidden table rows would not be checked. To test, apply the patch and go to Patrons -> Patron Lists - View a patron list - If necessary, add multiple patrons to the list so that the number exceeds 20. - Change the number of entries shown by the DataTable: Show [ 50 ] entries. - Click "Select all." All visible checkboxes should be checked. - Click "Clear all." All checkboxes should be unchecked. Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.05 |21.11.00,21.05.05,20.11.11 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18747 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org