[Bug 32523] New: Shortcuts / Links to missing fields in MARC-Editor don't work as expected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Bug ID: 32523 Summary: Shortcuts / Links to missing fields in MARC-Editor don't work as expected Change sponsored?: --- Product: Koha Version: 22.11 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: bibliothek@th-wildau.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The links / shortcuts to missing mandatory fields in the biblio marc editor won't work after redesign (or update from 22.05 to 22.11). Clicking on a "Go to field"-button will not focus that specific field. Test plan: * go to /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= * click Save * Error dialog appears, informing about missing input in mandatory fields. * Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. * In the error dialog click on a "Go to field" which points f.e. to section 9 * The selected / active tab will switch to section 9 and will not focus on the selected field I already have a clue how to solve that issue and try to upload a patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #1 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 144829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144829&action=edit Bug 32523 - Shortcuts / Links to missing fields in MARC-Editor don't work as expected -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #2 from Jan Kissig <bibliothek@th-wildau.de> --- Comment on attachment 144829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144829 Bug 32523 - Shortcuts / Links to missing fields in MARC-Editor don't work as expected This bug appears after switching to the new staff interface design (from 22.05 to 22.11). When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field. This patch fixes that error. Test plan: 1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 2) click Save 3) Error dialog appears, informing about missing input in mandatory fields. 4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. 5) In the error dialog click on a "Go to field" which points f.e. to section 9 6) The selected / active tab will switch to section 9 and will not focus on the selected field 7) apply patch 8) repeat step 1) to 6) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hi Jan, I'm thinking this is ready for testing.. if it is could you switch the status to 'Needs signoff' to send up the signal that you're happy it's ready? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Hi Jan. Your patch works (yeah!), but I can't seem to sign it off. I get this message: root@kohadevbox:koha(bz32523)$ git bz attach -e 32523 HEAD /usr/bin/git-bz:1908: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal obsoleted = (initial_description == patch.description) Traceback (most recent call last): File "/usr/bin/git-bz", line 2722, in <module> do_attach(*args) File "/usr/bin/git-bz", line 2074, in do_attach attach_commits(bug, commits, edit_comments=global_options.edit) File "/usr/bin/git-bz", line 1988, in attach_commits description, body, obsoletes, statuses, patch_complexities, depends = edit_attachment_comment(bug, commit.subject, body) File "/usr/bin/git-bz", line 1940, in edit_attachment_comment lines = edit_template(template.getvalue()) File "/usr/lib/python2.7/StringIO.py", line 271, in getvalue self.buf += ''.join(self.buflist) UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 3: ordinal not in range(128) I can sign off other patches (and my koha-testing-docker (KTD) is all up to date), so I don't think it is my setup (but I could be wrong!). Also, I think you will need to amend your patch for the QA Team to be happy, including: - Formatting title as Bug XXXXX: Title - Including the description and test plan in the patch See the commit message guidelines at https://wiki.koha-community.org/wiki/Commit_messages David -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the standard release notes| |MARC editor so that the | |links for any errors go to | |the correct tab. Currently, | |the links only work if you | |are the correct tab. --- Comment #5 from David Nind <david@davidnind.com> --- I've added a draft release note. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #6 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 144976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144976&action=edit Bug 32523: Links to missing fields in MARC-editor error This bug appears after switching to the new staff interface design (from 22.05 to 22.11). When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field. This patch fixes that error. Test plan: 1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 2) click Save 3) Error dialog appears, informing about missing input in mandatory fields. 4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. 5) In the error dialog click on a "Go to field" which points f.e. to section 9 6) The selected / active tab will switch to section 9 and will not focus on the selected field 7) apply patch 8) repeat step 1) to 6) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #7 from Jan Kissig <bibliothek@th-wildau.de> --- Hi David, thank you for your feedback. I have no clue where the error in root@kohadevbox:koha(bug_32523)$ git bz attach -e 32523 HEAD comes from. I use koha-testing-docker and cloned koha as described: git clone https://git.koha-community.org/Koha-community/Koha.git koha and use it as SYNC_REPO. Created a branch bug_32523 and switched to it, changed the source, committed and checked if it worked after running ktd up Inside the ktd (ktd --shell) I run root@kohadevbox:koha(bug_32523)$ git bz attach -e 32523 HEAD and get the same error as you. Someone a clue? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144829|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #8 from David Nind <david@davidnind.com> --- The patch now no longer applies 8-(... Applying: Bug 32523: Links to missing fields in MARC-editor error Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 32523: Links to missing fields in MARC-editor error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #9 from David Nind <david@davidnind.com> --- Must have been something with my setup, now applies! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #10 from David Nind <david@davidnind.com> --- Created attachment 145002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145002&action=edit Bug 32523: Links to missing fields in MARC-editor error This bug appears after switching to the new staff interface design (from 22.05 to 22.11). When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field. This patch fixes that error. Test plan: 1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl? frameworkcode= 2) click Save 3) Error dialog appears, informing about missing input in mandatory fields. 4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. 5) In the error dialog click on a "Go to field" which points f.e. to section 9 6) The selected / active tab will switch to section 9 and will not focus on the selected field 7) apply patch 8) repeat step 1) to 6) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145002|0 |1 is obsolete| | --- Comment #11 from David Nind <david@davidnind.com> --- Comment on attachment 145002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145002 Bug 32523: Links to missing fields in MARC-editor error I've obsoleted my sign off - something weird going on with unicode errors when trying to sign off - possibly caused by the subject line: Subject: [PATCH] =?UTF-8?q?Bug=C2=A032523:=20Links=20to=20missing=20fields?= =?UTF-8?q?=20in=20MARC-editor=20error?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I don't know how to fix... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #12 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 145012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145012&action=edit Bug 32523: Links to missing fields in MARC editor error This bug appears after switching to the new staff interface design (from 22.05 to 22.11). When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field. This patch fixes that error. Test plan: 1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 2) click Save 3) Error dialog appears, informing about missing input in mandatory fields. 4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. 5) In the error dialog click on a "Go to field" which points f.e. to section 9 6) The selected / active tab will switch to section 9 and will not focus on the selected field 7) apply patch 8) repeat step 1) to 6) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144976|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145012|0 |1 is obsolete| | --- Comment #13 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 145013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145013&action=edit Bug 32523: Links to missing fields in MARC editor error This bug appears after switching to the new staff interface design (from 22.05 to 22.11). When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field. This patch fixes that error. Test plan: 1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 2) click Save 3) Error dialog appears, informing about missing input in mandatory fields. 4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. 5) In the error dialog click on a "Go to field" which points f.e. to section 9 6) The selected / active tab will switch to section 9 and will not focus on the selected field 7) apply patch 8) repeat step 1) to 6) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #14 from Jan Kissig <bibliothek@th-wildau.de> --- I am sorry for spamming that bug page. @David you were right, the subject was in case the problem. I created the commit message inside visual studio and it seems like this caused the strange formatted subject, which then caused git bz -e to fail. I marked the first attachment as obsolete and was able to submit again, but now with correct subject line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145013|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 145039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145039&action=edit Bug 32523: Links to missing fields in MARC editor error This bug appears after switching to the new staff interface design (from 22.05 to 22.11). When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field. This patch fixes that error. Test plan: 1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 2) click Save 3) Error dialog appears, informing about missing input in mandatory fields. 4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. 5) In the error dialog click on a "Go to field" which points f.e. to section 9 6) The selected / active tab will switch to section 9 and will not focus on the selected field 7) apply patch 8) repeat step 1) to 6) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #16 from David Nind <david@davidnind.com> --- (In reply to Jan Kissig from comment #14)
I am sorry for spamming that bug page.
@David you were right, the subject was in case the problem. I created the commit message inside visual studio and it seems like this caused the strange formatted subject, which then caused git bz -e to fail.
I marked the first attachment as obsolete and was able to submit again, but now with correct subject line.
No problem Jan! Glad you were able to figure out how to fix it. Now signed off. David -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|22.11 |master Assignee|koha-bugs@lists.koha-commun |bibliothek@th-wildau.de |ity.org | --- Comment #17 from David Nind <david@davidnind.com> --- I've changed the assignee to yourself, as well as changing the version to master (needs back porting to 22.11). Good luck with the QA! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145039|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146151&action=edit Bug 32523: Links to missing fields in MARC editor error This bug appears after switching to the new staff interface design (from 22.05 to 22.11). When adding/editing a biblio in staff interface leaving out mandatory fields and click on save, you get an error dialog with shortcuts/links to these missing fields. Clicking on these links should change section tabs and focus the field. This patch fixes that error. Test plan: 1) in staff interface go to /cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode= 2) click Save 3) Error dialog appears, informing about missing input in mandatory fields. 4) Click on tab 0 (section 0) to make sure only marc 0XX fields are visible. 5) In the error dialog click on a "Go to field" which points f.e. to section 9 6) The selected / active tab will switch to section 9 and will not focus on the selected field 7) apply patch 8) repeat step 1) to 6) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Jan, congrats on your first patch for Koha! Sorry it took a while to get around to this one! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #21 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Can this fix please be backported to 22.11? Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos@dataly.gr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.03 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 --- Comment #22 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.03 |23.05.00,22.11.03,22.05.10 released in| | Status|Pushed to stable |Pushed to oldstable CC| |lucas@bywatersolutions.com --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|23.05.00,22.11.03,22.05.10 |23.05.00,22.11.03,22.05.10, released in| |21.11.18 CC| |arthur.suzuki@biblibre.com --- Comment #24 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.18 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #25 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32523 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 31880 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org