[Bug 23512] New: Reindent notices and slips page (letter.tt)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Bug ID: 23512 Summary: Reindent notices and slips page (letter.tt) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Tools Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I would like to reindent tools/letter.tt: Correct indentation, replace tabs with spaces, and add some comments to clarify the structure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92509&action=edit Bug 23512: Reindent notices and slips page (letter.tt) This patch re-indents the template for notices and slips. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, go to Tools -> Notices & slips. Test every aspect of the notice creation and edit process. At each step the page should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92510&action=edit Bug 23512: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92509|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92529&action=edit Bug 23512: Reindent notices and slips page (letter.tt) This patch re-indents the template for notices and slips. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, go to Tools -> Notices & slips. Test every aspect of the notice creation and edit process. At each step the page should work correctly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92510|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92530&action=edit Bug 23512: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92529|0 |1 is obsolete| | Attachment #92530|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92547&action=edit Bug 23512: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92547|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92548&action=edit Bug 23512: Reindent notices and slips page (letter.tt) This patch re-indents the template for notices and slips. It makes only whitespace changes. It should have no effect on the behavior of the page. To test, go to Tools -> Notices & slips. Test every aspect of the notice creation and edit process. At each step the page should work correctly. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 92549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92549&action=edit Bug 23512: (follow-up) Markup comments and corrections This patch adds comments to the template to highlight the markup structure. It also corrects some minor markup errors. This patch should have no effect on the interface or functionality. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- So pleased to see lots of templates getting this treatment.. nice to have clean nicely indented files to work on. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23512 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org