[Bug 16900] New: Hold suspend button incorrectly styled in patron holds list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900 Bug ID: 16900 Summary: Hold suspend button incorrectly styled in patron holds list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org When viewing the 'holds' tab in circulation or on the patron detail page, the "suspend" link is incorrectly styled. It has a "btn-link" class, which is inconsistent with current guidelines. It also has Glyphicon icons instead of Font Awesome. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 53278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53278&action=edit Bug 16900 - Hold suspend button incorrectly styled in patron holds list This patch updates the style of the suspend/resume button in the list of holds displayed on the checkout page and on the patron detail page. The button is now a Bootstrap-styled button with a Font Awesome icon. To test, apply the patch and locate a patron who has holds. - On the checkout page, view the 'Holds' tab and confirm that there is a correctly-styled 'Suspend' button for each hold. - Verify that the button works correctly and looks correct when a hold has been suspended. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900 Arslan Farooq <arslanone@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arslanone@gmail.com --- Comment #2 from Arslan Farooq <arslanone@gmail.com> --- Created attachment 53300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53300&action=edit Bug 16900 - Hold suspend button incorrectly styled in patron holds list This patch updates the style of the suspend/resume button in the list of holds displayed on the checkout page and on the patron detail page. The button is now a Bootstrap-styled button with a Font Awesome icon. To test, apply the patch and locate a patron who has holds. - On the checkout page, view the 'Holds' tab and confirm that there is a correctly-styled 'Suspend' button for each hold. - Verify that the button works correctly and looks correct when a hold has been suspended. Above two requirements were tested. Works fine. As expected. Suspend link is a button, and canceling it shows resume button (both using font awesome). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900 Arslan Farooq <arslanone@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Attachment #53278|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53278|0 |1 is patch| | Attachment #53278|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, it appears that the button of the suspend modal is an unusual blue. Apart from that observation, this works fine :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53300|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 53302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53302&action=edit [PASSED QA] Bug 16900 - Hold suspend button incorrectly styled in patron holds list This patch updates the style of the suspend/resume button in the list of holds displayed on the checkout page and on the patron detail page. The button is now a Bootstrap-styled button with a Font Awesome icon. To test, apply the patch and locate a patron who has holds. - On the checkout page, view the 'Holds' tab and confirm that there is a correctly-styled 'Suspend' button for each hold. - Verify that the button works correctly and looks correct when a hold has been suspended. Signed-off-by: Arslan Farooq <arslanone@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16900 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in 3.22.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org