[Bug 22742] New: RenewLoan return wrong datetime format
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 Bug ID: 22742 Summary: RenewLoan return wrong datetime format Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: arthur.suzuki@biblibre.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- DateTime format returned by RenewLoan method is "%Y-%m-%d %H:%S". I guess the later %S should be replaced with %M. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 88341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88341&action=edit Bug 22742: FIX : RenewLoan returns correct datetime format Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |arthur.suzuki@biblibre.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 Arthur Bousquet <arthur.bousquet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 Arthur Bousquet <arthur.bousquet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88341|0 |1 is obsolete| | --- Comment #2 from Arthur Bousquet <arthur.bousquet@inlibro.com> --- Created attachment 89565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89565&action=edit Bug 22742: FIX : RenewLoan returns correct datetime format Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 Bin <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89565|0 |1 is obsolete| | --- Comment #3 from Bin <bin.wen@inlibro.com> --- Created attachment 89568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89568&action=edit Bug 22742: FIX : RenewLoan returns correct datetime format Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> https://bugs.koha-community.org/show_bug.cgi?id=22472 Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 Bin <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89568|0 |1 is obsolete| | --- Comment #4 from Bin <bin.wen@inlibro.com> --- Created attachment 89569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89569&action=edit Bug 22742: FIX : RenewLoan returns correct datetime format Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> https://bugs.koha-community.org/show_bug.cgi?id=22472 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22891 [Bug 22891] ILS-DI: RenewLoan explodes in error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Arthur, please check our guidelines for commit messages :) https://wiki.koha-community.org/wiki/Commit_messages Now: [PATCH] Bug 22742: FIX : RenewLoan returns correct datetime format Better: Bug 22742: ILS-DI: Fix datetime format returned by RenewLoan I am sorry, but I am not able to test this further. RenewLoan dies for me: circular data structures not supported at /home/vagrant/kohaclone/opac/ilsdi.pl line 233. or: Can't encode a value of type: CODE at /home/vagrant/kohaclone/opac/ilsdi.pl line 233. URL I used: http://localhost:8080/cgi-bin/koha/ilsdi.pl?service=RenewLoan&patron_id=51&item_id=756 I am marking this as BLOCKED and dependent on the new bug 22891 I filed. While I can see that this change should work, usually a unit test would be needed for any change in a .pm file. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 89654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89654&action=edit Bug 22742: ILS-DI - Fix datetime format returned by RenewLoan Test plan : Call RenewLoan a few times and check the date returned is correct (minute wise). Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> https://bugs.koha-community.org/show_bug.cgi?id=22472 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Attachment #89569|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 Bug 22742 depends on bug 22891, which changed state. Bug 22891 Summary: ILS-DI: RenewLoan explodes in error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22891 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22742 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Bug caused by enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org