[Bug 39943] New: Add a separate PIN code field for accessing self service devices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Bug ID: 39943 Summary: Add a separate PIN code field for accessing self service devices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: lari.taskula@hypernova.fi QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org Some libraries allow their patrons to authenticate to a self-checkout or an access control device with a short pin number. While this is user-friendly and compatible with numpad devices, from a security standpoint it is not acceptable to have such a weak pin code as the patron account password outside library premises in OPAC on the public internet. It would be useful to separate a weaker PIN code field from the borrowers.password field. This weaker PIN code would only be used for SIP2 and possibly SCO/SCI access in a more restricted environment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se Assignee|koha-bugs@lists.koha-commun |andreas.jonsson@kreablo.se |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Bibliotek i Västmanland list of Sponsors| | Sponsorship status|--- |Sponsored URL| |https://wiki.koha-community | |.org/wiki/PIN_Code_Authenti | |cation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Large patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #1 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200364&action=edit Bug 39943: add systempreference EnablePinAuthentication Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #2 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200365&action=edit Bug 39943: add borrowers.pin field The pin field contains a hash on the same format as the password field, but dedicated for pin authentiation. Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #3 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200366&action=edit Bug 39943: pin field schema [DO NOT PUSH] Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #4 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200367&action=edit Bug 39943: sip2 account parameter allow_pin_code Add parameter that makes it possible to enable pin code authentication per SIP-account. Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #5 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200368&action=edit Bug 39943: allow_pin_code field schema [DO NOT PUSH] Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #6 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200369&action=edit Bug 39943: Add move_pin_codes.pl script Script to move existing pin codes to the new dedicated pin field, for Libraries that currently use the password field as PIN. Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #7 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200370&action=edit Bug 39943: pin code authentication via SIP This patch implements pin code authentication via SIP when enabled on the SIP account. Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #8 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200371&action=edit Bug 39943: Add EnablePinAuthentication to UsageStats Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #9 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200372&action=edit Bug 39943: add systempreference MinPinLength Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #10 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200373&action=edit Bug 39943: Add PIN_CHANGE letter Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #11 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200374&action=edit Bug 39943: add Koha::Patron::set_pin Method for setting the pin code, analogous to setting the password. Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #12 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200375&action=edit Bug 39943: patron/{patron_id}/pin endpoint REST endpoint for setting pin, analogous to setting password. Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #13 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200376&action=edit Bug 39943: Set PIN for staff. Let staff with edit_patron permission set PIN for others. Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #14 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200377&action=edit Bug 39943: opac-pin as copy of opac-passwd Copy the files for changing password for modification to changing pin. Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #15 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200378&action=edit Bug 39943: Change PIN code for OPAC To test: 0. After applying these patches: yarn build koha-upgrade-schema kohadev restart_all 1. Either set system preferences minPasswordLength to 4 and RequireStrongPassword to "Don't require" or replace example passwords in this test plan with conforming passwords. 2. Create a borrower category PIN for testing. 3. Create a borrower with userid 'pintest' i category PIN. Set password '0000'. 4. Verify that it is possible to login to opac with 'pintest'. 5. Set some variables (command line on koha server/docker): instance=kohadev category=PIN patron=pintest su=zippin sp=zippin pincode='0000' password=pintest inst=PINTEST kohabin=/kohadevbox/koha/misc 6. Run migration script: sudo koha-shell -c "perl '$kohabin'/migration_tools/move_pin_codes.pl --category '$category'" "$instance" sudo koha-shell -c "perl '$kohabin'/migration_tools/move_pin_codes.pl --category '$category' --confirm" "$instance" 7. Verify that it is no longer possible to login to OPAC with 'pintest' (because the password hash is moved to the pin field). 8. Enable the system preference 'EnablePinAuthentication'. 9. Create a patron with userid 'zippin' password 'zippin' and give it circulate permissions (to allow it to connect to the SIP-server). 10. Also, set password 'pintest' on the pintest borrower. 11. Go to Koha administration -> Self-service circulation (SIP2) -> Institutions and add an institution with name 'PINTEST'. 12. Under SIP2 accounts add new account tied to userid 'zippin' and institution 'PINTEST'. 13. Verify that the patron password of 'pintest' is valid (the SIP response SHOULD NOT contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information \ --patron "$patron" --password "$password" 14. Verify that the pin code for 'pintest' is NOT valid (the SIP response MUST contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information \ --patron "$patron" --password "$pincode" 15. On the SIP account for 'zippin' select "yes" for the parameter "Allow pin code" and save the settings. Also restart sip server: koha-sip --restart $instance 16. Verify that the pin code for 'pintest' is now valid (the SIP response must NOT contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 \ --port 6001 --su "$su" --sp "$sp" --location "$inst" \ --message patron_information --patron "$patron" \ --password "$pincode" 17. In the staff interface go to the patron 'pintest' and click on 'Change password or PIN' 18. In the fields "New pin" and "Confirm new pin" try inputting some letters, 3 digits, many digits and mismatching "Confirm new pin" and verify that validation errors "Pin code too short", "Pin code must consist of only digits" and "Please enter the same pin code as above" appears. 19. Enter the pin code '1111' into both pin code fields. In a separate tab/browser window, change the system preference MinPinLength to 6. Go back to the previous tab/browser window and click "save" to save the new PIN code. Verify that the there is a validation error when saving. 20. Change "MinPinLength" to 4. And change the pin code for patron 'pintest' to '1111'. 21. Verify that the new pin code 1111 for 'pintest' is now valid (the SIP response must NOT contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information --patron "$patron" --password 1111 22. Log in to the OPAC with userid/password pintest/pintest. 23. Go to your account and click "Change PIN" in the left menu. 24. In the fields "New PIN code" and "Repeat new PIN code" try inputting some letters, 3 digits, many digits and mismatching "Confirm new pin" and verify that validation errors "Pin code too short", "Pin code must consist of only digits" and "Please enter the same pin code as above" appears. 25. Type the wrong password in the password field, and enter the same pin code in both pincode fields. Press save and verify that there is an error "Your password was entered incorrectly...". Verify that the pin code was not changed (repeat 21.) 26. Enter the pin code '2222' into both pin code fields. In a separate tab/browser window, change the system preference MinPinLength to 6. Go back to the previous tab/browser window and click "save" to save the new PIN code. Verify that the there is a validation error when saving. 27. Change "MinPinLength" to 4. From the OPAC change the pin code for patron 'pintest' to '2222'. 28. Verify that the new pin code 2222 for 'pintest' is now valid (the SIP response must NOT contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information --patron "$patron" --password 2222 29. Set an email address on the pintest borrower (pintest@example.com) and set the system preference NotifyPasswordChange to "Notify". 30. Set the pin code to '3333' on the pintest borrower and verify that a "Library account PIN code change notification" was added to the message queue for the borrower. 31. Disable the system preference 'EnablePinAuthentication'. 32. Verify that the pin code is now invalid (SIP response MUST contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information --patron "$patron" --password 3333 Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Strategic theme|--- |Security Text to go in the| |Koha can now allow personal release notes| |identification numbers - | |PIN - for | |authenticating on self | |service equipment at the | |library, while | |requiring strong passwords | |for logging into the opac | |over a public | |network. The system | |preference | |EnablePinAuthentication and | |SIP-account parameter | |allow_pin_codes enables | |this feature. | | | |Libraries that currently | |use the Koha password for | |PIN | |authentication may migrate | |to use the dedicated pin | |field. See the | |documentation of the script | |migration_tools/move_pin_co | |des.pl for | |suggestions on how to do | |this. Initiative type|--- |Epic -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200378|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #16 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200579&action=edit Bug 39943: Change PIN code for OPAC To test: 0. After applying these patches: yarn build koha-upgrade-schema kohadev restart_all 1. Either set system preferences minPasswordLength to 4 and RequireStrongPassword to "Don't require" or replace example passwords in this test plan with conforming passwords. 2. Create a borrower category PIN for testing. 3. Create a borrower with userid 'pintest' i category PIN. Set password '0000'. 4. Verify that it is possible to login to opac with 'pintest'. 5. Set some variables (command line on koha server/docker): instance=kohadev category=PIN patron=pintest su=zippin sp=zippin pincode='0000' password=pintest inst=PINTEST kohabin=/kohadevbox/koha/misc 6. Run migration script: sudo koha-shell -c "perl '$kohabin'/migration_tools/move_pin_codes.pl --category '$category'" "$instance" sudo koha-shell -c "perl '$kohabin'/migration_tools/move_pin_codes.pl --category '$category' --confirm" "$instance" 7. Verify that it is no longer possible to login to OPAC with 'pintest' (because the password hash is moved to the pin field). 8. Enable the system preference 'EnablePinAuthentication'. 9. Create a patron with userid 'zippin' password 'zippin' and give it circulate permissions (to allow it to connect to the SIP-server). 10. Also, set password 'pintest' on the pintest borrower. 11. Go to Koha administration -> Self-service circulation (SIP2) -> Institutions and add an institution with name 'PINTEST'. 12. Under SIP2 accounts add new account tied to userid 'zippin' and institution 'PINTEST'. 13. Verify that the patron password of 'pintest' is valid (the SIP response SHOULD NOT contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information \ --patron "$patron" --password "$password" 14. Verify that the pin code for 'pintest' is NOT valid (the SIP response MUST contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information \ --patron "$patron" --password "$pincode" 15. On the SIP account for 'zippin' select "yes" for the parameter "Allow pin code" and save the settings. Also restart sip server: koha-sip --restart $instance 16. Verify that the pin code for 'pintest' is now valid (the SIP response must NOT contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 \ --port 6001 --su "$su" --sp "$sp" --location "$inst" \ --message patron_information --patron "$patron" \ --password "$pincode" 17. In the staff interface go to the patron 'pintest' and click on 'Change password or PIN' 18. In the fields "New pin" and "Confirm new pin" try inputting some letters, 3 digits, many digits and mismatching "Confirm new pin" and verify that validation errors "Pin code too short", "Pin code must consist of only digits" and "Please enter the same pin code as above" appears. 19. Enter the pin code '1111' into both pin code fields. In a separate tab/browser window, change the system preference MinPinLength to 6. Go back to the previous tab/browser window and click "save" to save the new PIN code. Verify that the there is a validation error when saving. 20. Change "MinPinLength" to 4. And change the pin code for patron 'pintest' to '1111'. 21. Verify that the new pin code 1111 for 'pintest' is now valid (the SIP response must NOT contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information --patron "$patron" --password 1111 22. Log in to the OPAC with userid/password pintest/pintest. 23. Go to your account and click "Change PIN" in the left menu. 24. In the fields "New PIN code" and "Repeat new PIN code" try inputting some letters, 3 digits, many digits and mismatching "Confirm new pin" and verify that validation errors "Pin code too short", "Pin code must consist of only digits" and "Please enter the same pin code as above" appears. 25. Type the wrong password in the password field, and enter the same pin code in both pincode fields. Press save and verify that there is an error "Your password was entered incorrectly...". Verify that the pin code was not changed (repeat 21.) 26. Enter the pin code '2222' into both pin code fields. In a separate tab/browser window, change the system preference MinPinLength to 6. Go back to the previous tab/browser window and click "save" to save the new PIN code. Verify that the there is a validation error when saving. 27. Change "MinPinLength" to 4. From the OPAC change the pin code for patron 'pintest' to '2222'. 28. Verify that the new pin code 2222 for 'pintest' is now valid (the SIP response must NOT contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information --patron "$patron" --password 2222 29. Set an email address on the pintest borrower (pintest@example.com) and set the system preference NotifyPasswordChange to "Notify". 30. Set the pin code to '3333' on the pintest borrower and verify that a "Library account PIN code change notification" was added to the message queue for the borrower. 31. Disable the system preference 'EnablePinAuthentication'. 32. Verify that the pin code is now invalid (SIP response MUST contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information --patron "$patron" --password 3333 Sponsored-by: Bibliotek i Västmanland -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #17 from David Cook <dcook@prosentient.com.au> --- Good to see that the PIN is stored as a hash, but I think it's still going to be accessible with the Reports module. I'm trying to push for "*_credentials" tables that are easier to secure. That said, I don't think it would be too difficult to migrate to that. Overall, I think this is a great addition to Koha. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #18 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Created attachment 200981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200981&action=edit Bug 39943: Add pin column to deletedborrowers Patch from commit 3f150e8 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #19 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 201802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201802&action=edit Bug 39943: Add set_pin tests To test: 1. prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #20 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 201803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201803&action=edit Bug 39943: Add is_pin_valid tests To test: 1. prove t/db_dependent/AuthUtils.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #21 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 201804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201804&action=edit Bug 39943: (proposal) Add a failing test for minimum pin length Proposing to enforce a fallback for minimum pin length. If agreed upon, this patch should be followed by a change that adds a fallback of 3 digits minimum. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #22 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 201805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201805&action=edit Bug 39943: (proposal) Enforce a PIN minimum length of 3 digits To test: 1. prove t/db_dependent/Koha/Patrons.t 2. prove t/db_dependent/AuthUtils.t Observe success -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #23 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 201806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201806&action=edit Bug 39943: pin field schema [DO NOT PUSH] Patch from commit dc91f02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200366|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #24 from Lari Taskula <lari.taskula@hypernova.fi> --- Awesome work, really impressive. This will be highly appreciated in many Finnish libraries. QA notes: 1. prove t/db_dependent/Koha/Patrons.t fails with DBIx::Class::Row::store_column(): No such column 'pin' on Koha::Schema::Result::Deletedborrower at /home/koha/Koha/Koha/Patron.pm line 1497 I see that you later attached a follow up patch adding the column to deletedborrowers, I've also attached a schema patch to make this test pass. 2. Should we enfore an absolute minimum pin length? From Koha::AuthUtils::is_pin_valid() I noticed that you left out the fallback value of 3 that the is_password_valid() method had. With these patches we default to a minimum of 4 by the atomicupdate (which is OK), but setting MinPinLength 0 is possible while on the other hand at least 1 digit is enforced by Koha::AuthUtils::is_pin_valid() regex step "non_digits". I think that like is_password_valid(), enforcing a fallback of 3 digits if MinPinLength < 3 would be reasonable. See my patches tagged with (proposal). 3. Your patch "Bug 39943: allow_pin_code field schema [DO NOT PUSH]" contains a change to kohastructure.sql likely meant for the previous patch. The new default value and the nullability will be dropped if this change is not pushed. 4. GUI questions: I think we should display the PIN code field at: - staff/cgi-bin/koha/members/memberentry.pl?op=edit_form&destination=circ&borrowernumber=123 (after password) - self registration (I could see libraries wanting to store patron's PIN code during self registration. Btw check syspref PatronSelfRegistrationBorrowerUnwantedField, pin is missing from this list and probably the other similar sysprefs as well. See Koha::Database::Columns->columns{'borrowers'}) These additions can be moved into new Bugs so that they won't stop this feature from moving on. Other very minor patch diff issues that stood out when reading your changes line by line: 5. Patch "Bug 39943: Add PIN_CHANGE letter" contains changes to OpenAPI spec, likely meant for the later patch "Bug 39943: patron/{patron_id}/pin endpoint" t::lib::Mocks::mock_preference( 'MinPinLength', undef ); throws_ok { $patron->set_pin( { pin => '12' } ); } 'Koha::Exceptions::Pin::TooShort', 'MinPinLength is undef, fall back to 3, fail test'; is( "$@", 'Pin length (2) is shorter than required (3)', 'Exception parameters passed correctly' ); t::lib::Mocks::mock_preference( 'MinPinLength', 2 ); throws_ok { $patron->set_pin( { pin => '12' } ); } 'Koha::Exceptions::Pin::TooShort', 'MinPinLength is 2, fall back to 3, fail test'; 6. Patch "Bug 39943: patron/{patron_id}/pin endpoint" 6.1 introduces Koha/Exceptions/Pin.pm late as it is already used by the previous patch. 6.2 has a strange looking endpoint edit in "api/v1/swagger/paths/patrons_pin.yaml", probably related to note 5 These do not change the end result nor the functionality of the feature but leave the mentioned patches slightly disorganized. Ran the following unit tests and they passed: 7. t/db_dependent/Auth/pin.t 8. t/db_dependent/api/v1/patrons_pin.t Followed the test plan you've written, and the feature works as advertised. I've added tests for set_pin() and is_pin_valid(). I'm still marking this as Failed QA due to note 3 which should be a trivial fix. Also I would like to hear your take on note 2 about the absolute minimum pin length. Again, really good work. Thank you so much for this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #26 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #17)
Good to see that the PIN is stored as a hash, but I think it's still going to be accessible with the Reports module.
Sorry I should've been clearer. You'll want to add "pin" to FORBIDDEN_COLUMN_MATCHES in Koha/Report.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #27 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206731&action=edit Bug 39943: add systempreference EnablePinAuthentication Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #28 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206732&action=edit Bug 39943: add borrowers.pin field The pin field contains a hash on the same format as the password field, but dedicated for pin authentiation. Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #29 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206733&action=edit Bug 39943: pin field schema [DO NOT PUSH] Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #30 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206734&action=edit Bug 39943: sip2 account parameter allow_pin_code Add parameter that makes it possible to enable pin code authentication per SIP-account. Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #31 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206735&action=edit Bug 39943: allow_pin_code field schema [DO NOT PUSH] Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #32 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206736&action=edit Bug 39943: Add move_pin_codes.pl script Script to move existing pin codes to the new dedicated pin field, for Libraries that currently use the password field as PIN. Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #33 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206737&action=edit Bug 39943: pin code authentication via SIP This patch implements pin code authentication via SIP when enabled on the SIP account. Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #34 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206738&action=edit Bug 39943: Add EnablePinAuthentication to UsageStats Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #35 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206739&action=edit Bug 39943: add systempreference MinPinLength Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #36 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206740&action=edit Bug 39943: Add PIN_CHANGE letter Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #37 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206741&action=edit Bug 39943: add Koha::Patron::set_pin Method for setting the pin code, analogous to setting the password. Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #38 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206742&action=edit Bug 39943: patron/{patron_id}/pin endpoint REST endpoint for setting pin, analogous to setting password. Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #39 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206743&action=edit Bug 39943: Set PIN for staff. Let staff with edit_patron permission set PIN for others. Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #40 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206744&action=edit Bug 39943: opac-pin as copy of opac-passwd Copy the files for changing password for modification to changing pin. Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #41 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206745&action=edit Bug 39943: Change PIN code for OPAC To test: 0. After applying these patches: yarn build koha-upgrade-schema kohadev restart_all 1. Either set system preferences minPasswordLength to 4 and RequireStrongPassword to "Don't require" or replace example passwords in this test plan with conforming passwords. 2. Create a borrower category PIN for testing. 3. Create a borrower with userid 'pintest' i category PIN. Set password '0000'. 4. Verify that it is possible to login to opac with 'pintest'. 5. Set some variables (command line on koha server/docker): instance=kohadev category=PIN patron=pintest su=zippin sp=zippin pincode='0000' password=pintest inst=PINTEST kohabin=/kohadevbox/koha/misc 6. Run migration script: sudo koha-shell -c "perl '$kohabin'/migration_tools/move_pin_codes.pl --category '$category'" "$instance" sudo koha-shell -c "perl '$kohabin'/migration_tools/move_pin_codes.pl --category '$category' --confirm" "$instance" 7. Verify that it is no longer possible to login to OPAC with 'pintest' (because the password hash is moved to the pin field). 8. Enable the system preference 'EnablePinAuthentication'. 9. Create a patron with userid 'zippin' password 'zippin' and give it circulate permissions (to allow it to connect to the SIP-server). 10. Also, set password 'pintest' on the pintest borrower. 11. Go to Koha administration -> Self-service circulation (SIP2) -> Institutions and add an institution with name 'PINTEST'. 12. Under SIP2 accounts add new account tied to userid 'zippin' and institution 'PINTEST'. 13. Verify that the patron password of 'pintest' is valid (the SIP response SHOULD NOT contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information \ --patron "$patron" --password "$password" 14. Verify that the pin code for 'pintest' is NOT valid (the SIP response MUST contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information \ --patron "$patron" --password "$pincode" 15. On the SIP account for 'zippin' select "yes" for the parameter "Allow pin code" and save the settings. Also restart sip server: koha-sip --restart $instance 16. Verify that the pin code for 'pintest' is now valid (the SIP response must NOT contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 \ --port 6001 --su "$su" --sp "$sp" --location "$inst" \ --message patron_information --patron "$patron" \ --password "$pincode" 17. In the staff interface go to the patron 'pintest' and click on 'Change password or PIN' 18. In the fields "New pin" and "Confirm new pin" try inputting some letters, 3 digits, many digits and mismatching "Confirm new pin" and verify that validation errors "Pin code too short", "Pin code must consist of only digits" and "Please enter the same pin code as above" appears. 19. Enter the pin code '1111' into both pin code fields. In a separate tab/browser window, change the system preference MinPinLength to 6. Go back to the previous tab/browser window and click "save" to save the new PIN code. Verify that the there is a validation error when saving. 20. Change "MinPinLength" to 4. And change the pin code for patron 'pintest' to '1111'. 21. Verify that the new pin code 1111 for 'pintest' is now valid (the SIP response must NOT contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information --patron "$patron" --password 1111 22. Log in to the OPAC with userid/password pintest/pintest. 23. Go to your account and click "Change PIN" in the left menu. 24. In the fields "New PIN code" and "Repeat new PIN code" try inputting some letters, 3 digits, many digits and mismatching "Confirm new pin" and verify that validation errors "Pin code too short", "Pin code must consist of only digits" and "Please enter the same pin code as above" appears. 25. Type the wrong password in the password field, and enter the same pin code in both pincode fields. Press save and verify that there is an error "Your password was entered incorrectly...". Verify that the pin code was not changed (repeat 21.) 26. Enter the pin code '2222' into both pin code fields. In a separate tab/browser window, change the system preference MinPinLength to 6. Go back to the previous tab/browser window and click "save" to save the new PIN code. Verify that the there is a validation error when saving. 27. Change "MinPinLength" to 4. From the OPAC change the pin code for patron 'pintest' to '2222'. 28. Verify that the new pin code 2222 for 'pintest' is now valid (the SIP response must NOT contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information --patron "$patron" --password 2222 29. Set an email address on the pintest borrower (pintest@example.com) and set the system preference NotifyPasswordChange to "Notify". 30. Set the pin code to '3333' on the pintest borrower and verify that a "Library account PIN code change notification" was added to the message queue for the borrower. 31. Disable the system preference 'EnablePinAuthentication'. 32. Verify that the pin code is now invalid (SIP response MUST contain the text 'Invalid password') $kohabin/sip_cli_emulator.pl --address 127.0.0.1 --port 6001 \ --su "$su" --sp "$sp" --location "$inst" \ --message patron_information --patron "$patron" --password 3333 Sponsored-by: Bibliotek i Västmanland Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #42 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206746&action=edit Bug 39943: Add pin column to deletedborrowers Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #43 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206747&action=edit Bug 39943: Add set_pin tests To test: 1. prove t/db_dependent/Koha/Patrons.t Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #44 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206748&action=edit Bug 39943: Add is_pin_valid tests To test: 1. prove t/db_dependent/AuthUtils.t Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #45 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206749&action=edit Bug 39943: Add a failing test for minimum pin length To test: 1. prove t/db_dependent/AuthUtils.t 2. prove t/db_dependent/Koha/Patrons.t Observe both tests failing. This patch is followed by a change that adds a fallback of 3 digits minimum and makes these tests pass. Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #46 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206750&action=edit Bug 39943: Enforce a PIN minimum length of 3 digits To test: 1. prove t/db_dependent/Koha/Patrons.t 2. prove t/db_dependent/AuthUtils.t Observe success Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #47 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206751&action=edit Bug 39943: pin field schema [DO NOT PUSH] Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #48 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206752&action=edit Bug 39943: Add pin to FORBIDDEN_COLUMN_MATCHES This patch prevents access to "pin" column from the reports module. Co-credits to David Cook for proposing this change. To test: 1. prove t/db_dependent/Koha/Reports.t 2. Create a new SQL report with the following SQL SELECT pin FROM borrowers; 3. Run the report 4. Observe error "The column selection in this report includes a password field." Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200364|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200367|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200368|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200369|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200370|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200371|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200372|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200373|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200374|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200375|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200376|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200377|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200981|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201802|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201803|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201804|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201805|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201806|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #49 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206755&action=edit Bug 39943: Enforce a PIN minimum length of 3 digits To test: 1. prove t/db_dependent/Koha/Patrons.t 2. prove t/db_dependent/AuthUtils.t Observe success 3. Enable system preference EnablePinAuthentication 4. Set system preference MinPinLength = 1 5. Navigate to OPAC > Change PIN 6. Fill in your password 7. Input 1 to "New PIN code" and the repeat field below 8. Click "Change PIN" 9. Observe error "PIN code is too short" 10. Enter 123 to pin code and the repeat field below 11. Click "Change PIN" 12. Observe PIN code has been changed Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #50 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206756&action=edit Bug 39943: pin field schema [DO NOT PUSH] Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #51 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206757&action=edit Bug 39943: Add pin to FORBIDDEN_COLUMN_MATCHES This patch prevents access to "pin" column from the reports module. Co-credits to David Cook for proposing this change. To test: 1. prove t/db_dependent/Koha/Reports.t 2. Create a new SQL report with the following SQL SELECT pin FROM borrowers; 3. Run the report 4. Observe error "The column selection in this report includes a password field." Signed-off-by: Lari Taskula <lari.taskula@hypernova.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206733|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206750|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206751|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206752|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39943 --- Comment #52 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Lari Taskula from comment #25)
2. Should we enfore an absolute minimum pin length? I've enforced PIN to a minimum of 3 digits
3. ...nullability will be dropped if this change is not pushed. Fixed
4. GUI questions: I think we should display the PIN code field at: - self registration (I could see libraries wanting to store patron's PIN code during self registration
Moved to Bug 43045
Other very minor patch diff issues fixed these as well
I've also Signed-off your patches. Setting Bug status back to "Needs Signoff" -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org