[Bug 20261] New: No result in some page in authority search opac and pro (ES)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Bug ID: 20261 Summary: No result in some page in authority search opac and pro (ES) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: claire.hernandez@biblibre.com How I reproduce this issue: * apply bug 17373 (auth unimarc mapping) * mappings.pl?op=reset&i_know_what_i_am_doing=1 * reindex autorities - ex: rebuild -a -v -d * authority search in opac or pro, looking for a term used * page 1 => OK, I see results * clic on page 2 => OK, I see results * clic on page 3 => KO, no result * clic on the lasty page displayed => KO (another), with an error ==> error.log <== [Wed Feb 21 10:30:11 2018] authorities-home.pl: [Request] ** [http://elastic:80]-[500] {"error":{"root_cause":[{"type":"query_phase_execution_exception","reason":"Result window is too large, from + size must be less than or equal to: [10000] but was [10020]. See the scroll api for a more efficient way to request large data sets. This limit can be set by changing the [index.max_result_window] index level setting."}],"type":"search_phase_execution_exception","reason":"all shards failed","phase":"query","grouped":true,"failed_shards":[{"shard":0,"index":"koha_maedi_authorities","node":"hhR2RjsnSye_jPUnySnMkQ","reason":{"type":"query_phase_execution_exception","reason":"Result window is too large, from + size must be less than or equal to: [10000] but was [10020]. See the scroll api for a more efficient way to request large data sets. This limit can be set by changing the [index.max_result_window] index level setting."}}]},"status":500}, called from sub Search::Elasticsearch::Role::Client::Direct::__ANON__ at /usr/share/perl5/Catmandu/Store/ElasticSearch/Bag.pm line 167. With vars: {'status_code' => 500,'request' => {'method' => 'GET','path' => '/koha_maedi_authorities/data/_search','serialize' => 'std','body' => {'size' => 20,'from' => 10000,'sort' => [{'Heading__sort.phrase' => 'asc'}],'query' => {'bool' => {'should' => [{'match' => {'Heading-Main' => 'de'}}]}}},'qs' => {},'mime_type' => 'application/json','ignore' => []}} [Wed Feb 21 10:30:11 2018] authorities-home.pl: Unable to perform your search. Please try again. I don't know if it is a mapping problem or a page management issue in authority search. To be investigated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17373 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373 [Bug 17373] Elasticsearch - Authority mappings for UNIMARC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 73375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73375&action=edit Bug 20261 - Fix pagination of the results in authority search Test plan: - apply this patch, - do a search that return more than 20 results, - click on page 2, - check that you get results, - check other pages if possible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73375|0 |1 is obsolete| | --- Comment #2 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 73381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73381&action=edit Bug 20261 - Fix pagination of the results in authority search Test plan: - apply this patch, - do a search that return more than 20 results, - click on page 2, - check that you get results, - check other pages if possible Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73381|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 73469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73469&action=edit Bug 20261 - Fix pagination of the results in authority search Test plan: - apply this patch, - do a search that return more than 20 results, - click on page 2, - check that you get results, - check other pages if possible Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Bug 20261 depends on bug 17373, which changed state. Bug 17373 Summary: Elasticsearch - Authority mappings for UNIMARC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17373 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21405 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21405 [Bug 21405] Browse authorities just add one records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |januszop@gmail.com Resolution|FIXED |--- --- Comment #5 from Janusz Kaczmarek <januszop@gmail.com> --- Did you check the impact of the patch on zebra searches? It seems that removing the line: my $offset = ( $startfrom - 1 ) * $resultsperpage + 1; leads to improper behavior of Koha when switching to subsequent pages of result set when zebra is used as a search engine: instead of jumping forward every 20 (or whatsoever) entries it moves forward by one entry only. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 --- Comment #6 from Janusz Kaczmarek <januszop@gmail.com> --- (In reply to Janusz Kaczmarek from comment #5)
Did you check the impact of the patch on zebra searches? It seems that removing the line:
my $offset = ( $startfrom - 1 ) * $resultsperpage + 1;
leads to improper behavior of Koha when switching to subsequent pages of result set when zebra is used as a search engine: instead of jumping forward every 20 (or whatsoever) entries it moves forward by one entry only.
NB. a similar line is to be found in authorities/auth_finder.pl (line 81 in 18.05.06): my $offset = $startfrom * $resultsperpage; and works OK with zebra and search_auth_compat. The difference is that the pages are counted 1-base in authorities-home.pl and 0-based in auth_finder.pl. Does this line not harm ES searches? If not why not unify the mode of operation and make authorities-home.pl 0-based with the initial phrase $offset = $startfrom * $resultsperpage ? Would it be OK for ES? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20261 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Resolution|--- |FIXED Status|REOPENED |RESOLVED --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Janusz Kaczmarek from comment #6)
(In reply to Janusz Kaczmarek from comment #5)
Did you check the impact of the patch on zebra searches? It seems that removing the line:
my $offset = ( $startfrom - 1 ) * $resultsperpage + 1;
leads to improper behavior of Koha when switching to subsequent pages of result set when zebra is used as a search engine: instead of jumping forward every 20 (or whatsoever) entries it moves forward by one entry only.
NB. a similar line is to be found in authorities/auth_finder.pl (line 81 in 18.05.06):
my $offset = $startfrom * $resultsperpage;
and works OK with zebra and search_auth_compat.
The difference is that the pages are counted 1-base in authorities-home.pl and 0-based in auth_finder.pl.
Does this line not harm ES searches? If not why not unify the mode of operation and make authorities-home.pl 0-based with the initial phrase $offset = $startfrom * $resultsperpage ? Would it be OK for ES?
See bugs 19365 and 21405 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org