[Bug 13124] New: Record titles with parentheses causing label weirdness
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Bug ID: 13124 Summary: Record titles with parentheses causing label weirdness Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org See the attached image -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32563&action=edit Label PDF with weirdness -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #2 from Chris Nighswonger <cnighswonger@foundations.edu> --- That is due to the embedded parenthesis. The inner parenthesis are not being escaped properly by the code which handles that. Without looking, I'd say its a pretty trivial fix. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32564&action=edit Label PDF after patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32565&action=edit Bug 13124 - Record titles with parentheses causing label weirdness -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #5 from Chris Nighswonger <cnighswonger@foundations.edu> --- That fix will cause problems with the postscript stream. I don't remember exactly the case, but do remember it took some hours to find and fix. At a minimum these lines should only be commented out rather than removed and a commend added to the effect of what I've mentioned. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Test Plan ( using sample data included with Koha ) 1) Catalog a record and item with the title "Oh no! or, (How my science project destroyed the world) /" 2) Edit the DEFAULT template a) Set layout type to Biblio b) Set data fields to "title, author, isbn, issn, itemtype, barcode, itemcallnumber" c) Set font size to 10 3) Create a batch with just the one item you created 4) Export the PDF with the Avery template and the DEFAULT layout 5) Note the weirdness 6) Apply this patch 7) Re-export the PDF, note it's no longer weird ; ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Chris Nighswonger from comment #5)
That fix will cause problems with the postscript stream. I don't remember exactly the case, but do remember it took some hours to find and fix. At a minimum these lines should only be commented out rather than removed and a commend added to the effect of what I've mentioned.
Will do! I don't see any negative effects. Possibly the need for them was fixed downstream. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32565|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32566&action=edit Bug 13124 - Record titles with parentheses causing label weirdness Test Plan ( using sample data included with Koha ) 1) Catalog a record and item with the title "Oh no! or, (How my science project destroyed the world) /" 2) Edit the DEFAULT template a) Set layout type to Biblio b) Set data fields to "title, author, isbn, issn, itemtype, barcode, itemcallnumber" c) Set font size to 10 3) Create a batch with just the one item you created 4) Export the PDF with the Avery template and the DEFAULT layout 5) Note the weirdness 6) Apply this patch 7) Re-export the PDF, note it's no longer weird ; ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Jeremie <jeremie.benarros@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremie.benarros@inlibro.co | |m --- Comment #9 from Jeremie <jeremie.benarros@inlibro.com> --- I'm not able to reproduce the bug. I followed the instructions but the exports just gives me that result : 0 0 0 0 and the XML files give to me correct informations. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Not only is this bug still valid, it's worse than I had believed. It appears that parens in other parts of the label will stop the reset of the labels in a batch from printing! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 --- Comment #11 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Kyle M Hall from comment #10)
Not only is this bug still valid, it's worse than I had believed. It appears that parens in other parts of the label will stop the reset of the labels in a batch from printing!
I can see how this would be a problem, however. PDF::Reuse::prText presently attempts to escape parentheses. I don't remember why I saw the need to escape them in the label module, but it certainly results in double escapment which could lead to various strange results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|normal |major --- Comment #12 from Chris Nighswonger <cnighswonger@foundations.edu> --- Bumping the importance of this fix. I'll try to sign off today or tomorrow. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32566|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 34337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34337&action=edit [SIGNED OFF] Bug 13124 - Record titles with parentheses causing label weirdness Test Plan ( using sample data included with Koha ) 1) Catalog a record and item with the title "Oh no! or, (How my science project destroyed the world) /" 2) Edit the DEFAULT template a) Set layout type to Biblio b) Set data fields to "title, author, isbn, issn, itemtype, barcode, itemcallnumber" c) Set font size to 10 3) Create a batch with just the one item you created 4) Export the PDF with the Avery template and the DEFAULT layout 5) Note the weirdness 6) Apply this patch 7) Re-export the PDF, note it's no longer weird ; ) Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |kyle@bywatersolutions.com |u | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |cnighswonger@foundations.ed | |u -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34337|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34725&action=edit [PASSED QA] Bug 13124 - Record titles with parentheses causing label weirdness Test Plan ( using sample data included with Koha ) 1) Catalog a record and item with the title "Oh no! or, (How my science project destroyed the world) /" 2) Edit the DEFAULT template a) Set layout type to Biblio b) Set data fields to "title, author, isbn, issn, itemtype, barcode, itemcallnumber" c) Set font size to 10 3) Create a batch with just the one item you created 4) Export the PDF with the Avery template and the DEFAULT layout 5) Note the weirdness 6) Apply this patch 7) Re-export the PDF, note it's no longer weird ; ) Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.16 CC| |mtj@kohaaloha.com --- Comment #17 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, patch will be in 3.16.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #18 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14, will be in 3.14.14. In my opinion, dead code must be removed instead of commented. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|jeremie.benarros@inlibro.co |philippe.blouin@inlibro.com |m | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org