https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 rkuiper@roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper@roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 88639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88639&action=edit Bug 22650: Prevent multiple holds on individual items This patch corrects a missing id on the holds_to_place field and adds code to disable the box when an item is checked Additionally script login now places a single hold if an itemnumebr is passed and checks for holdability of the specific item To test: 1 - Allow multiple holds per record in circ rules 2 - In staff client, go to place a hold on a record 3 - Select a patron 4 - Increase the number of holds 5 - Then select a specific item to hold 6 - Patron now has multiple holds on a single item 7 - Apply patch 8 - Repeat, notice that count is disabled when item checked 9 - Confirm count is enabled when 'Hold next available item' is checked 10 - Set number to more than 1 11 - Check an item and submit 12 - Confirm only one item is reserved 13 - Hit the script directly (with valid info): http://localhost:8081/cgi-bin/koha/reserve/placerequest.pl?biblionumber=1&checkitem=1&holds_to_place_count=2&borrowernumber=5 14 - Confirm only one hold is placed 15 - Confirm multiple hits of the url do not generate further holds -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88639|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 88640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88640&action=edit Bug 22650: Prevent multiple holds on individual items This patch corrects a missing id on the holds_to_place field and adds code to disable the box when an item is checked Additionally script login now places a single hold if an itemnumebr is passed and checks for holdability of the specific item To test: 1 - Allow multiple holds per record in circ rules 2 - In staff client, go to place a hold on a record 3 - Select a patron 4 - Increase the number of holds 5 - Then select a specific item to hold 6 - Patron now has multiple holds on a single item 7 - Apply patch 8 - Repeat, notice that count is disabled when item checked 9 - Confirm count is enabled when 'Hold next available item' is checked 10 - Set number to more than 1 11 - Check an item and submit 12 - Confirm only one item is reserved 13 - Hit the script directly (with valid info): http://localhost:8081/cgi-bin/koha/reserve/placerequest.pl?biblionumber=1&checkitem=1&holds_to_place_count=2&borrowernumber=5 14 - Confirm only one hold is placed 15 - Confirm multiple hits of the url do not generate further holds Signed-off-by: Liz Rea <wizzyrea@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice fix, no regressions found.. Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22650 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22895 [Bug 22895] [18.11] cannot place item level holds -- You are receiving this mail because: You are watching all bug changes.