[Bug 15989] New: Moving classification sources actions into drop-down menus
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Bug ID: 15989 Summary: Moving classification sources actions into drop-down menus Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Similar to Bug 15932, Bug 13778, Bug 15830, Bug 15952, Bug 15966, Bug 15988 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48712&action=edit Bug 15989: Moving classification sources actions into drop-down menus To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and work as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48712|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48714&action=edit Bug 15989: Moving classification sources actions into drop-down menus To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and work as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48714|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 48820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48820&action=edit Bug 15989: Moving classification sources actions into drop-down menus To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48820|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48846&action=edit Bug 15989: Moving classification sources actions into drop-down menus To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' have been moved into drop-down menus for BOTH tables and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16013 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have found bug 16013 on QAing this patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Status|Passed QA |In Discussion --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Aleisha, putting this in discussion, it seems that we should use the drop-down menu only when we have more than 2 buttons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48846|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48900&action=edit Bug 15989: Making classification sources actions buttons To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' now show as buttons for BOTH tables and work as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Moving classification |Making classification |sources actions into |sources actions buttons |drop-down menus | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48900|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48901&action=edit Bug 15989: Making classification sources actions buttons To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' now show as buttons for BOTH tables and work as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48901|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49052&action=edit [SIGNED-OFF] Bug 15989: Making classification sources actions buttons To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' now show as buttons for BOTH tables and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49053&action=edit Bug 15989 [Follow-up] Making classification sources actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. Also changed in this patch: A couple of capitalization errors. To test, apply the patch for Bug 16048 and go to Administration -> Classification sources. Confirm that the "Edit" and "Delete" buttons do not stack on top of each other even at narrow browser widths. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49053|0 |1 is obsolete| | --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 49232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49232&action=edit Bug 15989 [Follow-up] Making classification sources actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. Also changed in this patch: A couple of capitalization errors. To test, apply the patch for Bug 16048 and go to Administration -> Classification sources. Confirm that the "Edit" and "Delete" buttons do not stack on top of each other even at narrow browser widths. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49052|0 |1 is obsolete| | Attachment #49232|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49244&action=edit Bug 15989: Making classification sources actions buttons To test: 1) Go to Administration -> Classification sources 2) Confirm that the actions 'Edit' and 'Delete' now show as buttons for BOTH tables and work as expected. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49245&action=edit Bug 15989 [Follow-up] Making classification sources actions buttons This trivial follow-up adds an "actions" class to the table cell containing the new buttons. In conjunction with the style update in Bug 16048, this will prevent the buttons from wrapping at narrow browser window widths. Also changed in this patch: A couple of capitalization errors. To test, apply the patch for Bug 16048 and go to Administration -> Classification sources. Confirm that the "Edit" and "Delete" buttons do not stack on top of each other even at narrow browser widths. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15989 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #14 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org