http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39464&action=edit Bug 14264: Fix export of late orders when translated Bug 7298 tried to fix this issue, but it was not correct. We have 3 files in acqui/csv: basketgroup.tt, basket.tt and lateorders.tt The first 2 don't contain translatable string, and are not modified on translating the templates (`translate install`) On the contrary, lateorders.tt has some strings to translate ('Author:', 'Published by:', etc.). After being translated, all carriage returns between TT tags are removed. Test plan: 1/ choose a language and update + translate the templates for instance: cd misc/translate; ./translate update es-ES; ./translate install es-ES 2/ Go to acqui/lateorders.pl using this language 3/ Generate a csv for 1+ late orders and confirm the first line only contains the headers. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I tested with de-DE - but it didn't work somehow. Could you take another look please? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39464|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40177&action=edit Bug 14264: Fix export of late orders when translated Bug 7298 tried to fix this issue, but it was not correct. We have 3 files in acqui/csv: basketgroup.tt, basket.tt and lateorders.tt The first 2 don't contain translatable string, and are not modified on translating the templates (`translate install`) On the contrary, lateorders.tt has some strings to translate ('Author:', 'Published by:', etc.). After being translated, all carriage returns between TT tags are removed. Test plan: 1/ choose a language and update + translate the templates for instance: cd misc/translate; ./translate update es-ES; ./translate install es-ES 2/ Go to acqui/lateorders.pl using this language 3/ Generate a csv for 1+ late orders and confirm the first line only contains the headers. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40177|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 45046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45046&action=edit [PASSED QA] Bug 14264: Fix export of late orders when translated Bug 7298 tried to fix this issue, but it was not correct. We have 3 files in acqui/csv: basketgroup.tt, basket.tt and lateorders.tt The first 2 don't contain translatable string, and are not modified on translating the templates (`translate install`) On the contrary, lateorders.tt has some strings to translate ('Author:', 'Published by:', etc.). After being translated, all carriage returns between TT tags are removed. Test plan: 1/ choose a language and update + translate the templates for instance: cd misc/translate; ./translate update es-ES; ./translate install es-ES 2/ Go to acqui/lateorders.pl using this language 3/ Generate a csv for 1+ late orders and confirm the first line only contains the headers. Signed-off-by: Laurence Lefaucheur <laurence.lefaucheur@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14264 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |liz@catalyst.net.nz --- Comment #8 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.13, and released. -- You are receiving this mail because: You are watching all bug changes.