[Bug 29875] New: Update text on MaxReserves system preference to describe functionality.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Bug ID: 29875 Summary: Update text on MaxReserves system preference to describe functionality. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Currently, this syspref reads "Patrons can only have (X) holds at once." I would update that to: "Patrons can have a maximum of (X) holds at once. Leave blank or set to zero to disable." I've just confirmed this behavior on master: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron We've got discussion of this syspref generally over in 25643, but unless we're moving it in the near future we should at least make it clear and accurate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29877 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 129437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129437&action=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129437|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 129443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129443&action=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129443|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 129444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129444&action=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Added a sentence: "Additional limits may apply based on circulation rules." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129444|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 129455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129455&action=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #5)
Added a sentence: "Additional limits may apply based on circulation rules."
Great. Hope Katrin signs it so it can be added before string freeze! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129455|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 129463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129463&action=edit Bug 29875: Update wording on maxreserves system preference To test: 1 - see the current wording 2 - apply patch 3 - words are changed Test to confirm accuracy of wording: 1 - set maxreserves to 1 2 - set all/all circ rule to unlimited holds allowed total, holds allowed daily, and holds per record 3 - confirm you can place 1 hold for a patron, but the second is blocked 4 - set maxreserves to 0 5 - confirm you can place and number of holds for the patron 6 - set maxreserves to blank 7 - confirm you can place any number of holds for the patron Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.03 |22.05.00,21.11.03,21.05.14 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29875 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org