https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 94630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94630&action=edit Bug 23885: Move staff client search results JavaScript into separate file This patch moves most of the JavaScript embedded in results.tt into a separate file. The JavaScript that remains on the page is everything which requires processing by Template Toolkit. This is limited to variable definition. To test, apply the patch and perform a catalog search in the staff client. On the results page, test that JavaScript functionality has not been affected: - The search results toolbar should "float" as you scroll - Select all and Clear all - Default search term highlighting; Unhighlight and highlight controls - Adding and removing one or more items from the cart - Adding one or more items to a list - Placing one or more holds my making selections and clicking "Place hold" - Browse selected records - Z39.50 search (search form should be populated with your search terms) - "Show more" and "Show less" links in the facets sidebar - Book cover image services: Amazon, Coce, local covers, etc. - Open a patron record and click "Search to hold" - Perform a search and select one or more results - Test "Place hold" from the hold menu in the toolbar - Test "Place hold for..." from the hold menu in the toolbar - Test "Forget..." from the hold menu in the toolbar - In Tools -> Patron clubs, locate a club with enrolled members - From the "Actions" menu, select "Search to hold" - Perform a search and select one or more results - Test "Place hold" from the hold menu in the toolbar - Test "Place hold for..." from the hold menu in the toolbar - Test "Forget..." from the hold menu in the toolbar -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94630|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 97964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97964&action=edit Bug 23885: Move staff client search results JavaScript into separate file This patch moves most of the JavaScript embedded in results.tt into a separate file. The JavaScript that remains on the page is everything which requires processing by Template Toolkit. This is limited to variable definition. To test, apply the patch and perform a catalog search in the staff client. On the results page, test that JavaScript functionality has not been affected: - The search results toolbar should "float" as you scroll - Select all and Clear all - Default search term highlighting; Unhighlight and highlight controls - Adding and removing one or more items from the cart - Adding one or more items to a list - Placing one or more holds by making selections and clicking "Place hold" - Browse selected records - Z39.50 search (search form should be populated with your search terms) - "Show more" and "Show less" links in the facets sidebar - Book cover image services: Amazon, Coce, local covers, etc. - Open a patron record and click "Search to hold" - Perform a search and select one or more results - Test "Place hold" from the hold menu in the toolbar - Test "Place hold for..." from the hold menu in the toolbar - Test "Forget..." from the hold menu in the toolbar - In Tools -> Patron clubs, locate a club with enrolled members - From the "Actions" menu, select "Search to hold" - Perform a search and select one or more results - Test "Place hold" from the hold menu in the toolbar - Test "Place hold for..." from the hold menu in the toolbar - Test "Forget..." from the hold menu in the toolbar Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Nind from comment #3)

Created attachment 97970 [details] Bug 23885: Screenshots of potential problem

A potential problem identified during testing is placing a hold for a Patron club.

This didn’t work for me before the patch was applied as well as when the patch was applied, so it is either something I did or it is another issue.

When you select an item with a tick and then try to place a hold for the Patron Club from the drop down list (screenshot 1 in attachment) you get “No items are available” (see screenshot 2 in attachment).

Selecting ‘Place hold for ...’ from the links works fine though.

I haven't managed to get the pull down to display when testing without the patch - maybe someone else can give this a try? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97964|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 98004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98004&action=edit Bug 23885: Move staff client search results JavaScript into separate file This patch moves most of the JavaScript embedded in results.tt into a separate file. The JavaScript that remains on the page is everything which requires processing by Template Toolkit. This is limited to variable definition. To test, apply the patch and perform a catalog search in the staff client. On the results page, test that JavaScript functionality has not been affected: - The search results toolbar should "float" as you scroll - Select all and Clear all - Default search term highlighting; Unhighlight and highlight controls - Adding and removing one or more items from the cart - Adding one or more items to a list - Placing one or more holds my making selections and clicking "Place hold" - Browse selected records - Z39.50 search (search form should be populated with your search terms) - "Show more" and "Show less" links in the facets sidebar - Book cover image services: Amazon, Coce, local covers, etc. - Open a patron record and click "Search to hold" - Perform a search and select one or more results - Test "Place hold" from the hold menu in the toolbar - Test "Place hold for..." from the hold menu in the toolbar - Test "Forget..." from the hold menu in the toolbar - In Tools -> Patron clubs, locate a club with enrolled members - From the "Actions" menu, select "Search to hold" - Perform a search and select one or more results - Test "Place hold" from the hold menu in the toolbar - Test "Place hold for..." from the hold menu in the toolbar - Test "Forget..." from the hold menu in the toolbar Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |joy@bywatersolutions.com --- Comment #7 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23885 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.