[Bug 23551] New: problem while renew the checkout books in koha 19.05.03
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Bug ID: 23551 Summary: problem while renew the checkout books in koha 19.05.03 Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: librarian@sageuniversity.in QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Hi All, Recently I am facing a problem while renew the checkout book in koha 19.05 . I allocated 14 days for loan period, But when i renew the book the system is not adding the loan period (current date + 14 days). system is showing current date. Is there any option to be change current system preference ?. Now the system preference is showing "RenewalPeriodBase: the current date" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Govind Basedia <librarian@sageuniversity.in> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |librarian@sageuniversity.in -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Govind, trying to help narrow this down a bit more: - Does it happen from OPAC and staff interface? - What is your renewal period set to? (loan period is only the initial) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 --- Comment #2 from Govind Basedia <librarian@sageuniversity.in> --- (In reply to Katrin Fischer from comment #1)
Hi Govind, trying to help narrow this down a bit more: - Does it happen from OPAC and staff interface? - What is your renewal period set to? (loan period is only the initial)
Yes 15 days -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 --- Comment #3 from Govind Basedia <librarian@sageuniversity.in> --- Not solved this problem Hi All, Recently I am facing a problem while renew the checkout book in koha 19.05 . I allocated 14 days for loan period, But when i renew the book the system is not adding the loan period (current date + 14 days). system is showing current date. Is there any option to be change current system preference ?. Now the system preference is showing "RenewalPeriodBase: the current date" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 SiobhanC <siobhancottam@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |siobhancottam@gmail.com --- Comment #4 from SiobhanC <siobhancottam@gmail.com> --- This is happening for me too - when I use the 'renew' function in the header search, it renews to the exact time of renewal, rather than picking up on the circ rules. Renewing from the Loans table in the user record works as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 --- Comment #5 from Fiona Borthwick <fiona.borthwick@ptfs-europe.com> --- Can we try to pursue a fix for this soon please? Renewals work ok from the patron record but lots of our customers use this Renew option when they just want to renew a single item. It is a problem at 18.11 also. We have now had 3 customers report the same issue in the space of 3 days. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|problem while renew the |Problem with renewal period |checkout books in koha |when using the renewal tab |19.05.03 |in 19.05.03 Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think until 2 days ago we were missing the final clue - the difference is between the renewal tab and the other renewal features. I updated the severity and changed the title. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Holly <hc@interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc@interleaf.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 93746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93746&action=edit Bug 23551: Fix AddRenewal call in circ/renew.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7088 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think this traces back to bug 7088, though that's not in 18.11.x series as far as I can tell. Either way, the fix should resolve the issue and I will attempt to add a selenium regression test shortly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mozmen@tedankara.k12.tr --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 23802 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93746|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 94105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94105&action=edit Bug 23551: Fix AddRenewal call in circ/renew.pl Without the patch, renewing from the renewal tab/page led to wrong renewal/due dates. To test: - Check an item out to your patron account - Renew it from the patron account - Note the due date - Return the item - Check the item out again - Renew it using the renewal tab - Verify a different due date was calculated - Apply patch - Repeat test - due dates now should be the same Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Problem with renewal period |Problem with renewal period |when using the renewal tab |when using the renewal tab |in 19.05.03 | Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 --- Comment #12 from melis ozmen <mozmen@tedankara.k12.tr> --- works good. thank you -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94105|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 94214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94214&action=edit Bug 23551: Fix AddRenewal call in circ/renew.pl Without the patch, renewing from the renewal tab/page led to wrong renewal/due dates. To test: - Check an item out to your patron account - Renew it from the patron account - Note the due date - Return the item - Check the item out again - Renew it using the renewal tab - Verify a different due date was calculated - Apply patch - Repeat test - due dates now should be the same Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> It's ugly, but we are mimicking what is done in svc/renew so that's fine :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7088 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 [Bug 7088] Cannot renew items on hold even with override -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Hey team, great work with this! Can it please be backported for 19.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org