[Bug 34409] New: Inconsistencies in Audio alerts page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 Bug ID: 34409 Summary: Inconsistencies in Audio alerts page titles, breadcrumbs, and header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Audio alerts page, here is what should be changed to make it consistent with the other pages in the module: Page title - Add level for when adding a new audio alert 'New audio alert' - Add level for when editing an existing audio alert "Modify audio alert 'selector'" (not sure what makes sense here, selector?) Breadcrumb - Add level for when adding a new audio alert 'New audio alert' - Add level for when editing an existing audio alert "Modify audio alert 'selector'" (not sure what makes sense here, selector?) Page header - Change 'Add new alert' to 'New audio alert' - The styling of the header 'Add new alert' is different than usual - Change 'Edit alert' to "Modify audio alert 'selector'" (not sure what makes sense here, selector?) - The styling of the header 'Edit alert' is different than usual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34396 [Bug 34396] [OMNIBUS] Inconsistencies in page titles, breadcrumbs, and page headers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 155336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155336&action=edit Bug 34409: Fix inconsistencies in Audio alerts headers This patch makes a minor change to the structure of the audio alerts administration template so that the add/edit form is more consistent with other similar forms. The patch doesn't make any changes to page title and breadcrumbs because the add/edit action doesn't trigger a page reload, so the required change can't be made just with markup. To test, apply the patch and enable the AudioAlerts system preference if necessary. - Go to Administration -> Audio alerts. - Click "New alert" and confirm that the form looks correct. - Edit an existing alert to confirm that this view also looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 salahh <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155336|0 |1 is obsolete| | --- Comment #2 from salahh <salah.ghedda@inlibro.com> --- Created attachment 155485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155485&action=edit Bug 34409: Fix inconsistencies in Audio alerts headers This patch makes a minor change to the structure of the audio alerts administration template so that the add/edit form is more consistent with other similar forms. The patch doesn't make any changes to page title and breadcrumbs because the add/edit action doesn't trigger a page reload, so the required change can't be made just with markup. To test, apply the patch and enable the AudioAlerts system preference if necessary. - Go to Administration -> Audio alerts. - Click "New alert" and confirm that the form looks correct. - Edit an existing alert to confirm that this view also looks correct. Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 salahh <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155485|0 |1 is obsolete| | --- Comment #3 from salahh <salah.ghedda@inlibro.com> --- Created attachment 155486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155486&action=edit Bug 34409: Fix inconsistencies in Audio alerts headers This patch makes a minor change to the structure of the audio alerts administration template so that the add/edit form is more consistent with other similar forms. The patch doesn't make any changes to page title and breadcrumbs because the add/edit action doesn't trigger a page reload, so the required change can't be made just with markup. To test, apply the patch and enable the AudioAlerts system preference if necessary. - Go to Administration -> Audio alerts. - Click "New alert" and confirm that the form looks correct. - Edit an existing alert to confirm that this view also looks correct. Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 salahh <salah.ghedda@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |salah.ghedda@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155486|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155744&action=edit Bug 34409: Fix inconsistencies in Audio alerts headers This patch makes a minor change to the structure of the audio alerts administration template so that the add/edit form is more consistent with other similar forms. The patch doesn't make any changes to page title and breadcrumbs because the add/edit action doesn't trigger a page reload, so the required change can't be made just with markup. To test, apply the patch and enable the AudioAlerts system preference if necessary. - Go to Administration -> Audio alerts. - Click "New alert" and confirm that the form looks correct. - Edit an existing alert to confirm that this view also looks correct. Signed-off-by: Salah Ghedda <salah.ghedda@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Like others, not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34409 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org