https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 Esther Melander <estherm@sodaspringsid.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |estherm@sodaspringsid.com --- Comment #1 from Esther Melander <estherm@sodaspringsid.com> --- This bug popped up recently in 20.05.13. Our consortium wanted to block renewals for Long Overdue Lost items in the OPAC. We changed the ItemsDeniedRenewal setting so there are no custom rules, which somehow prevents Long Overdue Lost items from being renewed in the OPAC. However, this also blocked renewal in the staff client. All other combinations of patron and item categories appear to be able to renew. Only items with the item status of Long Overdue Lost is blocked - at least as far we can determine. For a staff account with superlibrarian permissions, or specifically the override blocked renewals permission the override returns an error. To test: - Use a staff account with permission to override blocked renewals - Remove custom rules for ItemsDeniedRenewal - Locate a patron with Long Overdue Lost items. - Check the box to override renewal restrictions - Select items that are Long Overdue Lost and click renew items. System will return : Renew failed: item_denied_renewal Koha should allow the renewal of items with the status of Long Overdue Lost with the override renewal function. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 --- Comment #3 from Esther Melander <estherm@sodaspringsid.com> --- I need to revise the above steps. To test: - Use a staff account with permission to override blocked renewals - Add custom rule for ItemsDeniedRenewal, itemlost: [1,2] - Locate a patron with Long Overdue Lost items. - Check the box to override renewal restrictions - Select items that are Long Overdue Lost and click renew items. System will return : Renew failed: item_denied_renewal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I marked this an enhancement when I filed it. In retrospect, I believe it is a bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 124272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124272&action=edit Bug 22866 - Allow override of renewals denied by ItemsDeniedRenewal Test Plan: 1) Create a circ rule for patron category Y and itemtype X 2) Block renewal of itemtype X using ItemsDeniedRenewal 3) Confirm AllowRenewalLimitOverride is set to Allow 4) Check item of itemtype X out to patron of category Y 5) See that circulation.pl shows "renewal denied by syspref" 6) Click the checkbox for "Override renewal limit" 7) See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed 8) Attempt to renew item 9) See error "Renew failed: item_denied_renewal" 10) Apply this patch 11) Restart all the things! 12) Attempt to renew the item via override again 13) The renewal is a success! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124272|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 124273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124273&action=edit Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal Test Plan: 1) Create a circ rule for patron category Y and itemtype X 2) Block renewal of itemtype X using ItemsDeniedRenewal 3) Confirm AllowRenewalLimitOverride is set to Allow 4) Check item of itemtype X out to patron of category Y 5) See that circulation.pl shows "renewal denied by syspref" 6) Click the checkbox for "Override renewal limit" 7) See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed 8) Attempt to renew item 9) See error "Renew failed: item_denied_renewal" 10) Apply this patch 11) Restart all the things! 12) Attempt to renew the item via override again 13) The renewal is a success! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124273|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 124277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124277&action=edit Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal Test Plan: 1) Create a circ rule for patron category Y and itemtype X 2) Block renewal of itemtype X using ItemsDeniedRenewal 3) Confirm AllowRenewalLimitOverride is set to Allow 4) Check item of itemtype X out to patron of category Y 5) See that circulation.pl shows "renewal denied by syspref" 6) Click the checkbox for "Override renewal limit" 7) See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed 8) Attempt to renew item 9) See error "Renew failed: item_denied_renewal" 10) Apply this patch 11) Restart all the things! 12) Attempt to renew the item via override again 13) The renewal is a success! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- This one should have another syspref to enable this behvaiour - some libraries do not wish the items denied renewal to be overridden -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 124324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124324&action=edit Bug 22866: Add syspref -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124312|0 |1 is obsolete| | Attachment #124324|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 126750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126750&action=edit Bug 22866: Allow override of renewals denied by ItemsDeniedRenewal Test Plan: 1) Create a circ rule for patron category Y and itemtype X 2) Block renewal of itemtype X using ItemsDeniedRenewal 3) Confirm AllowRenewalLimitOverride is set to Allow 4) Check item of itemtype X out to patron of category Y 5) See that circulation.pl shows "renewal denied by syspref" 6) Click the checkbox for "Override renewal limit" 7) See that "renewal denied by syspref" message is replaced by a checkbox suggesting renewal will be allowed 8) Attempt to renew item 9) See error "Renew failed: item_denied_renewal" 10) Apply this patch 11) Restart all the things! 12) Attempt to renew the item via override again 13) The renewal is a success! Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Esther Melander <estherm@sodaspringsid.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have to admit, AllowRenewalItemsDeniedOverride reads a little strange to me, why not AllowItemsDeniedRenewalOverride to stick with the feature name? Not a blocker. ItemsDeniedRenewal in the pref description should be linked, I will provide a follow-up. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22866 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The override checkbox will only show if AllowRenewalLimitOverride is also set to "Allow", but this dependency is not clear from the preferences and might be unintended? As is the new preference alone will have no effect. How should this work in reference to the Override blocked renewals (override_renewals) permission? Can you please clarify? -- You are receiving this mail because: You are watching all bug changes.