[Bug 39058] New: Top and left menu should have a fixed position
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 Bug ID: 39058 Summary: Top and left menu should have a fixed position Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: mathsabypro@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com It would improve Koha usabilty - to always display the top elements (navbar, header_search, maybe sub-header) even if the user scroll down the page - to always display the left menu, and to make it collapsible if the user choose to -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 --- Comment #1 from Mathieu Saby <mathsabypro@gmail.com> --- should it be in "template" component ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think both components are fine, but I am not sure if that would really improve things. We sometimes have longer content on the left side than a screen for example and we'd need to include scroll bars (think circulation or tools navigation). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 --- Comment #3 from Mathieu Saby <mathsabypro@gmail.com> --- I'd be rather surprised if there were any objections to making the top menu "sticky", but changing the display of the side menu might be less immediately useful and more complex to achieve. An alternative (or a complementary idea?) could be to modify the display of tables (all over Koha), to make "wide" tables easier to consult and to use (e.g. avoid action buttons on the very right of rows !) and prevent them from disrupting the pages in which they appear. Generally speaking, it might be worthwhile to have a usability audit of Koha carried out by an expert, and to implement the best options... Has this ever been discussed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe we discussed similar in context of things a foundation could potentially help organize or help funding. But I think small improvements can always be made independently. Another idea discussed was it to make it possible to collapse the left hand menu to give more space when required. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 --- Comment #5 from Mathieu Saby <mathsabypro@gmail.com> --- What do you think of this idea ? https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39127 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chloe.zermatten@openfifth.c | |o.uk, | |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |chloe.zermatten@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- I don't think the top menu or the sidebar should be made "sticky." I think we should prioritize the screen space for the task at hand. The staff interface has a "back to top" button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Owen Leonard from comment #6)
I don't think the top menu or the sidebar should be made "sticky." I think we should prioritize the screen space for the task at hand. The staff interface has a "back to top" button.
Agreed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #7)
(In reply to Owen Leonard from comment #6)
I don't think the top menu or the sidebar should be made "sticky." I think we should prioritize the screen space for the task at hand. The staff interface has a "back to top" button.
Agreed
Oh I really reversed my position in the comments on bug 39127 I think Mathieu makes an interesting point -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Top and left menu should |Top menu should optionally |have a fixed position |have a fixed position -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Why not keep everyone happy and make it syspref controlled again. Lets reduce the scope to sticky top nav driven by a pref. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 --- Comment #10 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- Created attachment 200499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200499&action=edit Bug 39058: feat: IntranetStickyHeader sys pref - add IntranetStickyHeader to systempreferences - define IntranetStickyHeader in staff_interface.pref - add IntranetStickyHeader to sysprefs.sql Test plan: 1. Apply the patch 2. Run $ perl installer/data/mysql/updatedatabase.pl 3. Log in to Koha as an administrator with sys pref permissions 4. Navigate to /cgi-bin/koha/admin/preferences.pl?tab=staff_interface 5. Under 'Options', notice the new IntranetStickyHeader sys pref 6. Toggle 'Pin' / 'Unpin' and ensure it saves appropriately -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 --- Comment #11 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- Created attachment 200500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200500&action=edit Bug 39058: feat: implement IntranetStickyHeader If IntranetStickyHeader is enabled, wrap the top nav bar and search bar into a section of class header-region, and implement a 'sticky' class similar to the one in _toolbar.scss Test plan: 1. run yarn css:build if you haven't after applying the patch 2. Toggle on IntranetStickyHeader 3. Reload the page - either hard refresh or navigate to a different staff intranet page. 4. Scroll down, and notice that the top nav and search bar remain affixed to the top of the page 5. Untoggle IntranetStickyHeader 6. Repeat 3. and 4., and notice that this time the top nav and search bar scroll out of view. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 Chloé Zermatten <chloe.zermatten@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #12 from Chloé Zermatten <chloe.zermatten@openfifth.co.uk> --- If we wanted the top menu (so navigation bar and search bar) to be sticky, and for a syspref to control that behaviour, here's how I reckon we could do that :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 200589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200589&action=edit Bug 39058: (follow-up) Default the syspref to off Also make sure there is a space between the section classes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39058 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Assignee|chloe.zermatten@openfifth.c |david@davidnind.com |o.uk | CC| |david@davidnind.com --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 201140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201140&action=edit Screenshot - Overlapping sticky headers (after the patches) I've Failed QA, as the sticky header overlaps with the table sticky header. To reproduce: 1. Log into the staff interface. 2. Perform a catalog search, for example: perl 3. Scroll down the results page 4. Note that the header stays sticky, as well as the search results table sticky header (same results in Firefox and Chrome-based browsers). 5. See the screenshot. 6. Other notes: . The arrow to go to the top of the page continues to appear (as expected) . Sidebar collapse: see Bug 42322 (now Passed QA) . Maybe the system preference should be renamed to StaffInterfaceStickyGlobalHeader - Intranet changed to StaffInterface - I added Global to make it clear from the name that it is the main header - Or maybe StaffInterfaceStickyMainNavigationHeader (or Bar) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org