[Bug 28586] New: Cannot resolve a claim
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Bug ID: 28586 Summary: Cannot resolve a claim Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart+koha@gmail.com [2021-06-17 14:42:51.00970] [909] [warn] OpenAPI <<< PUT api/v1/return_claims/1/resolve [{"message":"Properties not allowed: updated_by.","path":"\/body"}] To recreate: Checkout Claim it Go to claims Action > resolve > resolve claim -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | CC| |tomascohen@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28271 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 [Bug 28271] Add the ability to set a new lost status when a claim is resolved -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_21_05_candidate Severity|major |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 122083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122083&action=edit Bug 28586: Pass the right parameter to resolve claim Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This is yet another case highlighted by adding additionalProperties: false. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 122092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122092&action=edit Bug 28586: (follow-up) updated_by should be set This patch makes the route set the 'updated_by' attribute as well, when resolving a return claim through the API. Tests are added for this behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! updated_by is set correctly! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122083|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 122110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122110&action=edit Bug 28586: Pass the right parameter to resolve claim Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122092|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 122111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122111&action=edit Bug 28586: (follow-up) updated_by should be set This patch makes the route set the 'updated_by' attribute as well, when resolving a return claim through the API. Tests are added for this behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! updated_by is set correctly! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 --- Comment #6 from David Nind <david@davidnind.com> --- Testing notes (koha-testing-docker): - To reproduce the issue: . Set a value for ClaimReturnedLostValue, for example: 4 . Check out an item to a patron . Go to the patron's check out page > show check outs . In the 'Return claims' column select 'Claim returned', enter a note and click 'Make claim" . Go to to the Claim(s) tab and select Actions > Resolve > select a resolution reason from the drop down list > Click on 'Resolve claim' . Select a reason and enter some text - Before the patch is applied the page just hangs and there is the [warn] message (see bug description) in /var/log/koha/kohadev/plack-error.log - After the patch is applied (and browser cache cleared) the browser no longer hangs and there is no warning message in the log -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122110|0 |1 is obsolete| | --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 122124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122124&action=edit Bug 28586: Pass the right parameter to resolve claim Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122111|0 |1 is obsolete| | --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 122125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122125&action=edit Bug 28586: (follow-up) updated_by should be set This patch makes the route set the 'updated_by' attribute as well, when resolving a return claim through the API. Tests are added for this behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! updated_by is set correctly! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|nick@bywatersolutions.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122124|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122126&action=edit Bug 28586: Pass the right parameter to resolve claim Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122125|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122127&action=edit Bug 28586: (follow-up) updated_by should be set This patch makes the route set the 'updated_by' attribute as well, when resolving a return claim through the API. Tests are added for this behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! updated_by is set correctly! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122126|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122129&action=edit Bug 28586: Pass the right parameter to resolve claim Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122127|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 122130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122130&action=edit Bug 28586: (follow-up) updated_by should be set This patch makes the route set the 'updated_by' attribute as well, when resolving a return claim through the API. Tests are added for this behavior. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/return_claims.t => SUCCESS: Tests pass! updated_by is set correctly! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue with release notes| |the 'Returned claims' | |feature (enabled by setting | |a value for | |ClaimReturnedLostValue)- | |resolving returned claims | |now works as expected. | | | |Before this fix, an attempt | |to resolve a claim resulted | |in the page hanging and the | |claim not being able to be | |resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #13)
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.01 |21.11.00,21.05.01,20.11.08 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.01,20.11.08 |21.11.00,21.05.01,20.11.08, released in| |20.05.14 Status|Pushed to oldstable |Pushed to oldoldstable CC| |victor@tuxayo.net --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 20.05.x branch for 20.05.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.01,20.11.08, |21.11.00,21.05.01,20.11.08, released in|20.05.14 |20.05.14,19.11.20 Status|Pushed to oldoldstable |Pushed to oldoldoldstable CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #17 from wainuiwitikapark@catalyst.net.nz --- Backported to 19.11.x for 19.11.20 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org