[Bug 18820] New: The different parts in the main don' t automatically adjust with the available space.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Bug ID: 18820 Summary: The different parts in the main don't automatically adjust with the available space. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: philippe.audet-fortin@inlibro.com QA Contact: testopia@bugs.koha-community.org If opacuserlogin is disabled and you are on the opac homepage, you can see that there is an empty space on the right where the login form is supposed to be. It would be better if the main content took all available space. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #1 from Philippe Audet-Fortin <philippe.audet-fortin@inlibro.com> --- Created attachment 64424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64424&action=edit Bug 18820: Adding lines that check if opacuserlogin is enable and if OpacNav has content. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Philippe Audet-Fortin <philippe.audet-fortin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Philippe Audet-Fortin <philippe.audet-fortin@inlibro.com> --- The patch check if opacuserlogin is enable and if OpacNav has content. Depending on what is true or false the main content is wrap in a div spanXX. Test plan: 1)In the intranet, disable opacuserlogin 2)Go on the Opac homepage. There will be an empty space on the right of the main block where the login form was. 3)Apply the patch. 4)There should be no more empty space. 5)Remove all content from the OpacNav and the main content should take all available space. 6)Enable opacuserlogin and leave OpacNav empty and the main content should take all available space. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Philippe Audet-Fortin <philippe.audet-fortin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philippe.audet-fortin@inlib | |ro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64424|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 64447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64447&action=edit [SIGNED-OFF] Bug 18820: Adding lines that check if opacuserlogin is enable and if OpacNav has content. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64447|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 66698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66698&action=edit Bug 18820: Adding lines that check if opacuserlogin is enable and if OpacNav has content. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #4)
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Please read QA contact field ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Yes, I was testing it too and would have passed qa on it. But I could not manange somehow to make this patch show a difference. Followed the test plan and emptied Nav NavBottom MainUserBlock. Refreshing etc. no difference? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #6)
Yes, I was testing it too and would have passed qa on it. But I could not manange somehow to make this patch show a difference. Followed the test plan and emptied Nav NavBottom MainUserBlock. Refreshing etc. no difference?
Same, I cannot see any difference. Could you explain a bit more? Philippe, the author's name of the patch is Paudet, is it what you want? It will appear as it in the release notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominic.pichette@inlibro.co | |m Attachment #66698|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66698|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66698|0 |1 is obsolete| | --- Comment #8 from Dominic Pichette <dominic.pichette@inlibro.com> --- Created attachment 67101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67101&action=edit Bug 18820: Adding lines that check if opacuserlogin is enable and if OpacNav has content. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Dominic Pichette <dominic@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #9 from Dominic Pichette <dominic.pichette@inlibro.com> --- (In reply to Dominic Pichette from comment #8)
Created attachment 67101 [details] [review] Bug 18820: Adding lines that check if opacuserlogin is enable and if OpacNav has content.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Note: You have to generate the page in English since other languages are excluded from git and, therefore, not changed by the patch. This might have been the problem for Jonathan and Marcel? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #10 from Dominic Pichette <dominic.pichette@inlibro.com> --- Created attachment 67103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67103&action=edit before the patch was applied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #11 from Dominic Pichette <dominic.pichette@inlibro.com> --- Created attachment 67104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67104&action=edit with the patch, opacuserlogin=false and opacnac=false -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #12 from Dominic Pichette <dominic.pichette@inlibro.com> --- Created attachment 67105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67105&action=edit with the patch, opacuserlogin=true and opacnav=false -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #13 from Dominic Pichette <dominic.pichette@inlibro.com> --- Created attachment 67106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67106&action=edit with the patch, opacuserlogin=true and opacnav=true -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #14 from Dominic Pichette <dominic.pichette@inlibro.com> --- Just to make sure I'm clear. I attached some screenshots to show the difference with the result before the patch. - "beforepatch.png" shows the result you get when opacuserlogin and opacnav are set to false. - "opacuserlogin=f_opacnav=f.png" shows the result with the patch and opacuserlogin and opacnav set to false - "opacuserlogin=t_opacnav=f.png" shows the result with the patch and opacuserlogin set to true and opacnav set to false So what I meant in my last comment was that you always get the "beforepatch.png" result when you're not reading the page in english but the patch works properly otherwise as can be seen in the two other pictures. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67101|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 68736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68736&action=edit Bug 18820: Adding lines that check if opacuserlogin is enable and if OpacNav has content. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I need another confirmation. Before the patch: https://screenshots.firefox.com/i220lvWCoUM1Mlf8/catalogue.kohadev.org After the patch: https://screenshots.firefox.com/PBXfxyLVaP1tHIXm/catalogue.kohadev.org Could you confirm it is what we want? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #17 from Owen Leonard <oleonard@myacpl.org> --- I'm not sure if this is something I missed or if this is a new problem, but with opacuserlogin off OpacNavRight is misplaced. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dominic.pichette@inlibro.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #18 from Roch D'Amour <roch.damour@inlibro.com> --- Created attachment 72098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72098&action=edit Bug 18820: Main block size now adjust to OpacNavRight like it would for opacuserlogin Test plans : - "beforepatch.png" shows the result you get when OpacNavRight and opacnav are set to false. - "opacuserlogin=f_opacnav=f.png" shows the result with the patch and OpacNavRight and opacnav set to false - "opacuserlogin=t_opacnav=f.png" shows the result with the patch and OpacNavRight set to true and opacnav set to false -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |roch.damour@inlibro.com Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Roch D'Amour <roch.damour@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dominic.pichette@inlibro.co |roch.damour@inlibro.com |m | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72098|0 |1 is obsolete| | --- Comment #19 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 72284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72284&action=edit Bug 18820: Main block size now adjust to OpacNavRight like it would for opacuserlogin Test plans : - "beforepatch.png" shows the result you get when OpacNavRight and opacnav are set to false. - "opacuserlogin=f_opacnav=f.png" shows the result with the patch and OpacNavRight and opacnav set to false - "opacuserlogin=t_opacnav=f.png" shows the result with the patch and OpacNavRight set to true and opacnav set to false Applied patch, can confirm it functions as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|The different parts in the |The different parts in the |main don't automatically |main don't automatically |adjust with the available |adjust with the available |space. |space -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I tested in Chrome: Turn opacuserlogin off, put text in OpacMainUserBlock and opacnavright. OpacNavRight ends up on the left side inside of OpacMainUserBlock. Something is not right there. To test: OpacNavRight: Just put some text OpacMainUserBlock: <div style="background-color:green; width:100%> </div> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Resetting - I think the error was on my side! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68736|0 |1 is obsolete| | Attachment #72284|0 |1 is obsolete| | --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73508&action=edit Bug 18820: Adding lines that check if opacuserlogin is enable and if OpacNav has content. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73509&action=edit Bug 18820: Main block size now adjust to OpacNavRight like it would for opacuserlogin Test plans : - "beforepatch.png" shows the result you get when OpacNavRight and opacnav are set to false. - "opacuserlogin=f_opacnav=f.png" shows the result with the patch and OpacNavRight and opacnav set to false - "opacuserlogin=t_opacnav=f.png" shows the result with the patch and OpacNavRight set to true and opacnav set to false Applied patch, can confirm it functions as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches pushed to master. Congratulations Roch and Philippe for your first patches in! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73509|0 |1 is obsolete| | --- Comment #25 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 73547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73547&action=edit Bug 18820: Main block size now adjust to OpacNavRight like it would for opacuserlogin Test plans : - "beforepatch.png" shows the result you get when OpacNavRight and opacnav are set to false. - "opacuserlogin=f_opacnav=f.png" shows the result with the patch and OpacNavRight and opacnav set to false - "opacuserlogin=t_opacnav=f.png" shows the result with the patch and OpacNavRight set to true and opacnav set to false Applied patch, can confirm it functions as expected. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18820 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |nick@bywatersolutions.com Resolution|--- |FIXED --- Comment #26 from Nick Clemens <nick@bywatersolutions.com> --- Seems more like enhancement, not backporting to 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org