[Bug 37330] New: LocalCoverImages for items don't show if StaffDetailItemSelection disabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Bug ID: 37330 Summary: LocalCoverImages for items don't show if StaffDetailItemSelection disabled Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 168843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168843&action=edit Bug 37330: Add drawcallback if LocalCoverImages 1) Enable LocalCoverImages 2) Visit a biblio: /cgi-bin/koha/catalogue/detail.pl?biblionumber=294 3) On the actions column, click the arrow and click upload image, submit an image 4) Go back to biblio, notice the image shows for the specific item 5) Disable StaffDetailItemSelection 6) Go back to biblio, notice the image is gone 7) Apply patch. Repeat. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | CC| |david@davidnind.com, | |oleonard@myacpl.org Version|unspecified |Main Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 --- Comment #2 from David Nind <david@davidnind.com> --- Something weird is going on here for me with item cover images. Tested on the latest main, with everything up to date for KTD, and clearing browser caches between changes. Before the patch, the item cover image is NOT showing for the individual item in the holdings table, but is showing for the record cover images. This is without the patch and after the patch, and with and without StaffDetailItemSelection enabled. That is (for me), no item cover images are showing for any of the combinations before and after the patch. I've tested before and after in Firefox and Chromium. I've also tested with combinations of AllowMultipleCovers, LocalCoverImages, OPACLocalCoverImages. I thought it may have been something with Bug 33526 - Use template wrapper for tabs: bibliographic detail page and Bug 36966 - Fix links for local cover images for items on staff detail page. These are in main, but if I use 24.05.01 I still get the same behavour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Olivier V <ovezina@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ovezina@inlibro.com --- Comment #3 from Olivier V <ovezina@inlibro.com> --- The StaffDetailItemSelection seems to be gone in the current main. I don't know if this voids this patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think you might still be able to test it. We removed it, but it defaults to "ON" now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|pedro.amorim@ptfs-europe.co |jonathan.druart@gmail.com |m | Status|Failed QA |ASSIGNED Depends on| |33526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 [Bug 33526] Use template wrapper for tabs: bibliographic detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168843|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171519&action=edit Bug 37330: (bug 33526 follow-up) Fix display of cover images for items The id has been modified by bug 33526. We can simply pass the table element however. Test plan: Have some cover images at item level and notice that they are correctly displayed on the bibliographic record detail page. Note that the slider does not work correctly. If you click on the dot (so if you have several images for an item) the scrollbar is going to hit the top of the page and the image won't change. Could be reported separately if not done yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|LocalCoverImages for items |LocalCoverImages for items |don't show if |don't show after 33526 |StaffDetailItemSelection | |disabled | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171519|0 |1 is obsolete| | --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171522&action=edit Bug 37330: Fix callback table selector 1) Enable LocalCoverImages 2) Visit a biblio: /cgi-bin/koha/catalogue/detail.pl?biblionumber=294 3) On the actions column, click the arrow and click upload image, submit an image 4) Go back to biblio, notice the image shows for the specific item 5) Disable StaffDetailItemSelection 6) Go back to biblio, notice the image is gone 7) Apply patch. Repeat. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171519|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171522|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171519|0 |1 is obsolete| | --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 171523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171523&action=edit Bug 37330: (bug 33526 follow-up) Fix display of cover images for items The id has been modified by bug 33526. We can simply pass the table element however. Test plan: Have some cover images at item level and notice that they are correctly displayed on the bibliographic record detail page. Note that the slider does not work correctly. If you click on the dot (so if you have several images for an item) the scrollbar is going to hit the top of the page and the image won't change. Could be reported separately if not done yet. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171523|0 |1 is obsolete| | --- Comment #8 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 171591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171591&action=edit Bug 37330: (bug 33526 follow-up) Fix display of cover images for items The id has been modified by bug 33526. We can simply pass the table element however. Test plan: Have some cover images at item level and notice that they are correctly displayed on the bibliographic record detail page. Note that the slider does not work correctly. If you click on the dot (so if you have several images for an item) the scrollbar is going to hit the top of the page and the image won't change. Could be reported separately if not done yet. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks for all the hard work! Pushed to main for the next 24.11.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37330 Bug 37330 depends on bug 33526, which changed state. Bug 33526 Summary: Use template wrapper for tabs: bibliographic detail page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33526 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org