[Bug 7937] New: Silence warns in OPAC error log (koha-opac-error_log)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Priority: P5 - low Change sponsored?: --- Bug ID: 7937 Assignee: gmcharlt@gmail.com Summary: Silence warns in OPAC error log (koha-opac-error_log) QA Contact: koha.sekjal@gmail.com Severity: normal Classification: Unclassified OS: All Reporter: katrin.fischer@bsz-bw.de Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 9059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9059&action=edit Bug 7937: Silence warns in OPAC error log (koha-opac-error_log) To reproduce: Access a detail page where at least some items are available and have no due date. Log: opac-detail.pl: Use of uninitialized value in concatenation (.) or string at /home/katrin/kohaclone/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt line 657. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 9060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9060&action=edit Bug 7937: Silence warns in OPAC error log (koha-opac-error_log) I noticed warnings in the logs for an item without itemtype on item and record level. While trying to resolve the warns, I noticed a possible optimization in XSLT.pm. GetItemsInfo is built to return the notforloan value both for the item and record level, depending on the item-level_itype setting. - $item->{notforloan} doesn't exist in @items - $itemtypes->{ $item->{itype} }->{notforloan} can be replaced by $item->{notforloan_per_itemtype} -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 9061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9061&action=edit Bug 7937: Fix warns on opac-userupdate.pl 1) opac-userupdate.pl: Use of uninitialized value $updateemailaddress in pattern match (m//) at /home/katrin/kohaclone/opac/opac-userupdate.pl line 61. Warn was created when branch has no email address. The script falls back to KohaAdminEmailAddress first and shows an error message in OPAC when there is no email address to be used. 2) opac-userupdate.pl: Use of uninitialized value in concatenation (.) or string at /home/katrin/kohaclone/koha-tmpl/opac-tmpl/prog/en/modules/opac-userupdate.tt line 75. Warn was created when patron has no date of birth. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 9063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9063&action=edit Bug 7937: Fix warns in opac-authoritiesdetail.pl [Tue Apr 10 01:51:20 2012] opac-authoritiesdetail.pl: Use of uninitialized value in concatenation (.) or string line 162 Warn is created, when authority record contains a field that does not exist in the authorities frameworks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 9064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9064&action=edit Bug 7937: Fixes warns in authority search (C4/Authorities.pm) Errors were output when searching for authorities in OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 9065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9065&action=edit Bug 7937: Fix warns in opac-reserve.pl 1) opac-reserve.pl: Use of uninitialized value in string ne at /home/katrin/kohaclone/opac/opac-reserve.pl line 475. 2) opac-reserve.pl: Use of uninitialized value $reservedfor in string eq at /home/katrin/kohaclone/opac/opac-reserve.pl line 410 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9059|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 9115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9115&action=edit [SIGNED-OFF] Bug 7937: Silence warns in OPAC error log (koha-opac-error_log) To reproduce: Access a detail page where at least some items are available and have no due date. Log: opac-detail.pl: Use of uninitialized value in concatenation (.) or string at /home/katrin/kohaclone/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt line 657. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Entry in the log is gone after the patch is applied. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9060|0 |1 is obsolete| | --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9134&action=edit [SIGNED OFF] Bug 7937: Silence warns in OPAC error log (koha-opac-error_log) I noticed warnings in the logs for an item without itemtype on item and record level. While trying to resolve the warns, I noticed a possible optimization in XSLT.pm. GetItemsInfo is built to return the notforloan value both for the item and record level, depending on the item-level_itype setting. - $item->{notforloan} doesn't exist in @items - $itemtypes->{ $item->{itype} }->{notforloan} can be replaced by $item->{notforloan_per_itemtype} Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9061|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9135&action=edit [SIGNED OFF] Bug 7937: Fix warns on opac-userupdate.pl 1) opac-userupdate.pl: Use of uninitialized value $updateemailaddress in pattern match (m//) at /home/katrin/kohaclone/opac/opac-userupdate.pl line 61. Warn was created when branch has no email address. The script falls back to KohaAdminEmailAddress first and shows an error message in OPAC when there is no email address to be used. 2) opac-userupdate.pl: Use of uninitialized value in concatenation (.) or string at /home/katrin/kohaclone/koha-tmpl/opac-tmpl/prog/en/modules/opac-userupdate.tt line 75. Warn was created when patron has no date of birth. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9063|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9141&action=edit [SIGNED OFF] Bug 7937: Fix warns in opac-authoritiesdetail.pl [Tue Apr 10 01:51:20 2012] opac-authoritiesdetail.pl: Use of uninitialized value in concatenation (.) or string line 162 Warn is created, when authority record contains a field that does not exist in the authorities frameworks. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9064|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9142&action=edit [SIGNED OFF] Bug 7937: Fixes warns in authority search (C4/Authorities.pm) Errors were output when searching for authorities in OPAC. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9065|0 |1 is obsolete| | --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9143&action=edit [SIGNED OFF] Bug 7937: Fix warns in opac-reserve.pl 1) opac-reserve.pl: Use of uninitialized value in string ne at /home/katrin/kohaclone/opac/opac-reserve.pl line 475. 2) opac-reserve.pl: Use of uninitialized value $reservedfor in string eq at /home/katrin/kohaclone/opac/opac-reserve.pl line 410 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7965 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Ian Walls <koha.sekjal@gmail.com> --- First patch: fixes some spacing, then adds conditional check to template var before printing. second patch: C4 change. Replaces usage of $itemtypes with $item->{notforloan_per_itemtype}, making the subroutine buildKohaItemsNamespace more efficient third patch: fixes spacing and conditional check on template, and provides default value for possibly undefined variable. fourth patch: conditional check for variable before concatenating fifth patch: C4 change. Introduces conditional checks into SearchAuthorities(). Lots of text moved to fix indenting, but functional changes are minimal. sixth patch: better conditional checks on variables. Marking all 6 Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> --- About patch 1, shouldn't we fix the KohaDate itself, to return '' if there is no date provided ? Something like: my ($self,$text) = @_; + return '' unless $text; my $date = C4::Dates->new( $text, 'iso' ); return $date->output("syspref"); patch 3 would also have to be rewriten in this case. (This option would result in silencing all KohaDates warning isn't it ?) I agree with patch 2 and 4 I think patch 5 is OK, but there maybe some side effect replacing $x ne 1 by !$x (even if I think there is none in this case). I'll delay this one for after 3.8.0 release, just to be carefull. Waiting for feedback on counter-patch for 1 and 3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> --- Katrin, any feedback about my comment 14 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #16 from Paul Poulain <paul.poulain@biblibre.com> --- filing QA because of comment 14, hoping that will motivate katrin to answer ;-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I want to continue working on this - but I have to find time :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7937 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hblancoca@gmail.com --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** Bug 9040 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org