[Bug 41866] New: "Use of uninitialized value..." warning in opac-search.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 Bug ID: 41866 Summary: "Use of uninitialized value..." warning in opac-search.pl Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: roman.dolny@jezuici.pl QA Contact: testopia@bugs.koha-community.org CC: januszop@gmail.com The warning [WARN] Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/opac/opac-search.pl line 600. appears in plack-opac-error.log To reproduce in KTD: 1. Observe plack-opac-error.log. 2. Go to Advanced search in OPAC. 3. Select any of item type ("Limit to any of the following:") in tab "Item type" and perform search (do not enter any "Search for:" terms). 4. Warning appears in plack-opac-error.log. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 --- Comment #1 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 194934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194934&action=edit Bug 41866: "Use of uninitialized value..." warning in opac-search.pl The warning [WARN] Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/opac/opac-search.pl line 600. appears in plack-opac-error.log Test plan: ========== 1. Observe plack-opac-error.log. 2. Go to Advanced search in OPAC. 3. Select any of item type ("Limit to any of the following:") in tab "Item type" and perform search (do not enter any "Search for:" terms). ==> Warning appears in plack-opac-error.log. 4. Apply the patch; restart_all. 5. Repeat 2-3. ==> No warning in plack-opac-error.log. Sponsored-by: Ignatianum University in Cracow -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Ignatianum University in list of Sponsors| |Cracow Assignee|oleonard@myacpl.org |roman.dolny@jezuici.pl Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194934|0 |1 is obsolete| | --- Comment #2 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 194936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194936&action=edit Bug 41866: "Use of uninitialized value..." warning in opac-search.pl The warning [WARN] Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/opac/opac-search.pl line 600. appears in plack-opac-error.log Test plan: ========== 1. Observe plack-opac-error.log. 2. Go to Advanced search in OPAC. 3. Select any of item type ("Limit to any of the following:") in tab "Item type" and perform search (do not enter any "Search for:" terms). ==> Warning appears in plack-opac-error.log. 4. Apply the patch; restart_all. 5. Repeat 2-3. ==> No warning in plack-opac-error.log. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Don't you two work together at Ignatianum? Sign offs need to come from a different organisation. That said, in this case, I think it might be a minor enough change for it not to matter... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Hmm I can't reproduce the problem using that test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 --- Comment #5 from Roman Dolny <roman.dolny@jezuici.pl> --- David, thank you for trying to test. Not sure if something is not clear in test plan, but when I use advanced search in OPAC on fresh KTD there is a warning in plack-opac-error.log. URL for query looks like: /cgi-bin/koha/opac-search.pl?advsearch=1&weight_search_submitted=1 &weight_search=1&do=Search&limit=mc-itype%2Cphr%3ABK&sort_by=relevance Could you check it once again, maybe with fresh KTD? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Roman Dolny from comment #5)
David, thank you for trying to test.
Not sure if something is not clear in test plan, but when I use advanced search in OPAC on fresh KTD there is a warning in plack-opac-error.log.
URL for query looks like: /cgi-bin/koha/opac-search.pl?advsearch=1&weight_search_submitted=1 &weight_search=1&do=Search&limit=mc-itype%2Cphr%3ABK&sort_by=relevance
Looks fine for me with that exact URL.
Could you check it once again, maybe with fresh KTD?
I'm on a pretty recent KTD but yeah I can give it another go. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Yeah no still no error in the plack-opac-error.log file. But I think I've worked it out. You didn't provide enough details for your steps to reproduce. You're using Elasticsearch right? The default for KTD should be Zebra. With Zebra, there's no error. An error does appear for Elasticsearch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194936|0 |1 is obsolete| | --- Comment #8 from David Cook <dcook@prosentient.com.au> --- Created attachment 195108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=195108&action=edit Bug 41866: "Use of uninitialized value..." warning in opac-search.pl The warning [WARN] Use of uninitialized value in concatenation (.) or string at /kohadevbox/koha/opac/opac-search.pl line 600. appears in plack-opac-error.log Test plan: ========== 1. Observe plack-opac-error.log. 2. Go to Advanced search in OPAC. 3. Select any of item type ("Limit to any of the following:") in tab "Item type" and perform search (do not enter any "Search for:" terms). ==> Warning appears in plack-opac-error.log. 4. Apply the patch; restart_all. 5. Repeat 2-3. ==> No warning in plack-opac-error.log. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Janusz Kaczmarek <januszop@gmail.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 --- Comment #9 from Roman Dolny <roman.dolny@jezuici.pl> --- (In reply to David Cook from comment #7)
... You're using Elasticsearch right? The default for KTD should be Zebra. With Zebra, there's no error. An error does appear for Elasticsearch.
Yes, I've been using ES for a while now and forgot about the default Zebra. You're absolutely right, thanks for catching that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Thanks for all the hard work! Pushed to main for the next 26.05.00 release as RM Assistant -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 --- Comment #11 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41866 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 25.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org