[Bug 28688] New: Auto Renew Patron Membership if Patron has Been Active
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Bug ID: 28688 Summary: Auto Renew Patron Membership if Patron has Been Active Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: jzairo@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When membership renewals come up for a patron, it would be useful for libraries to make a decision about automatic renewals of membership, based on current activity at the library. This would be a benefit/advantage for users who don't come into the physical branch but use curbside or electronic services. If Koha could look at borrowers.lastseen - last time a patron has been seen (connected at the OPAC or staff interface), this could be used as a way to identify that activity and renew the patron accordingly. In addition, if a library uses TrackLastPatronActivity the borrowers.lastseen date could also identify when a patron is using SIP-related connections. It would be great to have a system preference that would allow you to turn this function on or off for libraries who want patrons to come in to renew membership (ie show driver's license for mail verifying address). It would also be great to have a tie-in notice that automatically notifies them when they have been renewed! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #1 from George Williams (NEKLS) <george@nekls.org> --- I agree. I think this is a great idea so long as there is some kind of system preference to turn it on or off. Even better, though, would be to make it part of the circulation rules so that it could be turned on or off based on the borrower's home library or part of the patron category configuration so it could be turned on or off based on a borrower's category. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I like the sound of this. (It makes me wonder if all my library cards have expired since I haven't been to a public library since 2019 thanks to the pandemic*.) *I wonder if we'll look back one day on these Bugzilla comments and say "oh right... we did have a pandemic back then..." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 saylett@spanishfork.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |saylett@spanishfork.org --- Comment #3 from saylett@spanishfork.org --- This would be a great feature. We field countless calls/texts/emails from active patrons needing to renew their accounts. We've discussed extending the renewal period, but having it auto-renew based on activity would be much better. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Great idea. Is borrowers.lastseen the best way to detect activity, or should we look at holds or issues or ..? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Amanda Campbell <acampbell@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |acampbell@hmcpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33245 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 [Bug 33245] Add $patron->is_active -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Auto Renew Patron |Automatically renew patron |Membership if Patron has |membership for active |Been Active |patrons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4)
Great idea. Is borrowers.lastseen the best way to detect activity, or should we look at holds or issues or ..?
Bug 33245 provides a base for this. You can do $patron->is_active({ months => 6 }) or something and continue. The is_active method looks at datelastseen, enrollment date, expiry date, anonymized status, and recent holds, issues and article requests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33522 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Note that bug 33522 provides another perspective: do not send expiry notices to inactive patrons. Might feel a bit less friendly, but could be an option too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33522 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33522 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 [Bug 33522] Optionally skip (in)active patrons when sending membership expiry notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Status|NEW |ASSIGNED --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #6)
Note that bug 33522 provides another perspective: do not send expiry notices to inactive patrons. Might feel a bit less friendly, but could be an option too.
Decided to put this one on top of 33522. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 152378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152378&action=edit Bug 28688: Add new notice MEMBERSHIP_RENEWED Test plan: Run new install or upgrade. Check for this notice under Tools/Notices. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 152379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152379&action=edit Bug 28688: Add renew option to membership_expiry.pl Test plan: [1] Pick an account to expire soon. [2] Choose MembershipExpiryDaysNotice so that it will be selected. (Note: You can extend the selection with -before or -after.) [3] Run misc/cronjobs/membership_expiry.pl -c -v -renew [4] Check new expiry date in the notice. Does it correspond with enrollment period of category and pref BorrowerRenewalPeriodBase? [5] If the patron category has an enrollment fee, check account too. [6] Reset dateexpiry of this patron to original date. [7] Run misc/cronjobs/membership_expiry.pl -c -v [8] Check if you got an expiry notice instead and dateexpiry did not change. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 152380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152380&action=edit Bug 28688: Allow to pass another renewal notice Just as passing another expiry notice. Test plan: Pick a patron to expire. Create another membership renewal notice, say X. Run misc/cronjobs/membership_expiry.pl -c -n -v -letter_renew X Check output on command line. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 152381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152381&action=edit Bug 28688: Add renewal to crontab example Note: I did not add an example to the debian cron daily file, since we have no commented lines there. And automatic renewal is no default behavior. Test plan: Read new lines in misc/cronjobs/crontab.example. Just comments. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Automatically renew patron |Automatically renew patron |membership for active |membership |patrons | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch set allows you release notes| |to renew patrons | |automatically when running | |the membership_expiry.pl | |cron job. | |You can pass | |filters to do this only on | |selected patrons, like | |active patrons, etc. | |Default behavior does not | |change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- This works and see the contens of the MEMBERSHIP_RENEWED notice in the command line output. However I don't see the MEMBERSHIP_RENEWED notice in the message_queue. Ive tried with the default notice MEMEBERSHIP_RENEWED ( /misc/cronjobs/membership_expiry.pl -c -n -v -letter_renew MEMBERSHIP_RENEWED -renew ) and with a custom notice called X ( /misc/cronjobs/membership_expiry.pl -c -n -v -letter_renew X -renew ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass from comment #12)
This works and see the contens of the MEMBERSHIP_RENEWED notice in the command line output. However I don't see the MEMBERSHIP_RENEWED notice in the message_queue.
Ive tried with the default notice MEMEBERSHIP_RENEWED ( /misc/cronjobs/membership_expiry.pl -c -n -v -letter_renew MEMBERSHIP_RENEWED -renew )
and with a custom notice called X ( /misc/cronjobs/membership_expiry.pl -c -n -v -letter_renew X -renew )
Thanks for testing, Lucas. I cannot reproduce this. I do see the notices in the message queue. I assume that you installed the dbrev, since you see output on the cmdline. Did you check if the patrons have a working email address? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152378|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155170&action=edit Bug 28688: Add new notice MEMBERSHIP_RENEWED Test plan: Run new install or upgrade. Check for this notice under Tools/Notices. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152379|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155171&action=edit Bug 28688: Add renew option to membership_expiry.pl Test plan: [1] Pick an account to expire soon. [2] Choose MembershipExpiryDaysNotice so that it will be selected. (Note: You can extend the selection with -before or -after.) [3] Run misc/cronjobs/membership_expiry.pl -c -v -renew [4] Check new expiry date in the notice. Does it correspond with enrollment period of category and pref BorrowerRenewalPeriodBase? [5] If the patron category has an enrollment fee, check account too. [6] Reset dateexpiry of this patron to original date. [7] Run misc/cronjobs/membership_expiry.pl -c -v [8] Check if you got an expiry notice instead and dateexpiry did not change. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152380|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155172&action=edit Bug 28688: Allow to pass another renewal notice Just as passing another expiry notice. Test plan: Pick a patron to expire. Create another membership renewal notice, say X. Run misc/cronjobs/membership_expiry.pl -c -n -v -letter_renew X Check output on command line. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152381|0 |1 is obsolete| | --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155173&action=edit Bug 28688: Add renewal to crontab example Note: I did not add an example to the debian cron daily file, since we have no commented lines there. And automatic renewal is no default behavior. Test plan: Read new lines in misc/cronjobs/crontab.example. Just comments. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased on top of 33245/33522. PLEASE test ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155170|0 |1 is obsolete| | --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 155222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155222&action=edit Bug 28688: Add new notice MEMBERSHIP_RENEWED Test plan: Run new install or upgrade. Check for this notice under Tools/Notices. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155171|0 |1 is obsolete| | --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 155223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155223&action=edit Bug 28688: Add renew option to membership_expiry.pl Test plan: [1] Pick an account to expire soon. [2] Choose MembershipExpiryDaysNotice so that it will be selected. (Note: You can extend the selection with -before or -after.) [3] Run misc/cronjobs/membership_expiry.pl -c -v -renew [4] Check new expiry date in the notice. Does it correspond with enrollment period of category and pref BorrowerRenewalPeriodBase? [5] If the patron category has an enrollment fee, check account too. [6] Reset dateexpiry of this patron to original date. [7] Run misc/cronjobs/membership_expiry.pl -c -v [8] Check if you got an expiry notice instead and dateexpiry did not change. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155172|0 |1 is obsolete| | --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 155224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155224&action=edit Bug 28688: Allow to pass another renewal notice Just as passing another expiry notice. Test plan: Pick a patron to expire. Create another membership renewal notice, say X. Run misc/cronjobs/membership_expiry.pl -c -n -v -letter_renew X Check output on command line. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155173|0 |1 is obsolete| | --- Comment #22 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 155225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155225&action=edit Bug 28688: Add renewal to crontab example Note: I did not add an example to the debian cron daily file, since we have no commented lines there. And automatic renewal is no default behavior. Test plan: Read new lines in misc/cronjobs/crontab.example. Just comments. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #23 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass from comment #22)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Great! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26355 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g --- Comment #24 from Kristi <kkrueger@cuyahogalibrary.org> --- I see this is signed off. This is a system preference our library branches are eager to see in place. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think we should move the logic enrollment_fee logic to the notice template + $fees->{$recent->branchcode} = $recent->category->enrolmentfee if !exists $fees->{$recent->branchcode}; + $substitute->{enrollment_fee} = $fees->{$recent->branchcode} if $fees->{$recent->branchcode} > 0; It can be [% patron.category.enrolmentfee %], and we don't add black magic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hum, and why are you using the branchcode as the key of $fees? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Please clarify. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #26)
Hum, and why are you using the branchcode as the key of $fees?
Thats a good question. It seems to be a typo. I do not recall another reason right now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #25)
I think we should move the logic enrollment_fee logic to the notice template
+ $fees->{$recent->branchcode} = $recent->category->enrolmentfee if !exists $fees->{$recent->branchcode}; + $substitute->{enrollment_fee} = $fees->{$recent->branchcode} if $fees->{$recent->branchcode} > 0;
It can be [% patron.category.enrolmentfee %], and we don't add black magic.
Will have a look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Nice that both enrollmentfee and enrolment fee are correct spellings.. Please ignore that inconsistency here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155222|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156522&action=edit Bug 28688: Add new notice MEMBERSHIP_RENEWED Test plan: Run new install or upgrade. Check for this notice under Tools/Notices. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Enrollment fee via object instead of substitute hash. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155223|0 |1 is obsolete| | --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156523&action=edit Bug 28688: Add renew option to membership_expiry.pl Test plan: [1] Pick an account to expire soon. [2] Choose MembershipExpiryDaysNotice so that it will be selected. (Note: You can extend the selection with -before or -after.) [3] Run misc/cronjobs/membership_expiry.pl -c -v -renew [4] Check new expiry date in the notice. Does it correspond with enrollment period of category and pref BorrowerRenewalPeriodBase? [5] If the patron category has an enrollment fee, check account too. [6] Reset dateexpiry of this patron to original date. [7] Run misc/cronjobs/membership_expiry.pl -c -v [8] Check if you got an expiry notice instead and dateexpiry did not change. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Removed $fees and $substitute in favor of notice approach -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155224|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156524&action=edit Bug 28688: Allow to pass another renewal notice Just as passing another expiry notice. Test plan: Pick a patron to expire. Create another membership renewal notice, say X. Run misc/cronjobs/membership_expiry.pl -c -n -v -letter_renew X Check output on command line. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155225|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156525&action=edit Bug 28688: Add renewal to crontab example Note: I did not add an example to the debian cron daily file, since we have no commented lines there. And automatic renewal is no default behavior. Test plan: Read new lines in misc/cronjobs/crontab.example. Just comments. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #25)
I think we should move the logic enrollment_fee logic to the notice template
+ $fees->{$recent->branchcode} = $recent->category->enrolmentfee if !exists $fees->{$recent->branchcode}; + $substitute->{enrollment_fee} = $fees->{$recent->branchcode} if $fees->{$recent->branchcode} > 0;
It can be [% patron.category.enrolmentfee %], and we don't add black magic.
Removed the $fees and $substitute construct now and moved it to the notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- New test result: +------------+-----------+----------------+-----------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------+--------------------+------------------------+---------+---------------------+---------------------+------------+-----------------------------+---------------+--------------+--------------+ | message_id | letter_id | borrowernumber | subject | content | metadata | letter_code | message_transport_type | status | time_queued | updated_on | to_address | from_address | reply_address | content_type | failure_code | +------------+-----------+----------------+-----------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------+--------------------+------------------------+---------+---------------------+---------------------+------------+-----------------------------+---------------+--------------+--------------+ | 513 | 173 | 50 | Account renewal | Dear Tommy Peters, Your library account has been renewed. The new expiry date is: 2032-01-04. An enrollment fee of $12.35 has been applied. Thank you, Your library, Springfield | | MEMBERSHIP_RENEWED | email | pending | 2023-10-04 11:47:28 | 2023-10-04 11:47:28 | NULL | noreply@master.rijkskoha.nl | NULL | NULL | | +------------+-----------+----------------+-----------------+----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+----------+--------------------+------------------------+---------+---------------------+---------------------+------------+-----------------------------+---------------+--------------+--------------+ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156522|0 |1 is obsolete| | Attachment #156523|0 |1 is obsolete| | Attachment #156524|0 |1 is obsolete| | Attachment #156525|0 |1 is obsolete| | --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156533&action=edit Bug 28688: Add new notice MEMBERSHIP_RENEWED Test plan: Run new install or upgrade. Check for this notice under Tools/Notices. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Enrollment fee via object instead of substitute hash. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156534&action=edit Bug 28688: Add renew option to membership_expiry.pl Test plan: [1] Pick an account to expire soon. [2] Choose MembershipExpiryDaysNotice so that it will be selected. (Note: You can extend the selection with -before or -after.) [3] Run misc/cronjobs/membership_expiry.pl -c -v -renew [4] Check new expiry date in the notice. Does it correspond with enrollment period of category and pref BorrowerRenewalPeriodBase? [5] If the patron category has an enrollment fee, check account too. [6] Reset dateexpiry of this patron to original date. [7] Run misc/cronjobs/membership_expiry.pl -c -v [8] Check if you got an expiry notice instead and dateexpiry did not change. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> [EDIT] Removed $fees and $substitute in favor of notice approach Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156535&action=edit Bug 28688: Allow to pass another renewal notice Just as passing another expiry notice. Test plan: Pick a patron to expire. Create another membership renewal notice, say X. Run misc/cronjobs/membership_expiry.pl -c -n -v -letter_renew X Check output on command line. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156536&action=edit Bug 28688: Add renewal to crontab example Note: I did not add an example to the debian cron daily file, since we have no commented lines there. And automatic renewal is no default behavior. Test plan: Read new lines in misc/cronjobs/crontab.example. Just comments. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #41 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156537&action=edit Bug 28688: Use pod2usage for incorrect usage Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #41)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Great! Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #43 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (Note that we should remove the Options part from the SYNOPSIS, it's redundant when you get the help message). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 156540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156540&action=edit Bug 28688: (follow-up) Remove redundant options Test plan: Run misc/cronjobs/membership_expiry.pl --help misc/cronjobs/membership_expiry.pl --man Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #45 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #46 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35001 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #47 from Kristi <kkrueger@cuyahogalibrary.org> --- We are very excited about this update! Any possibility of backporting the update to 22.11? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Kristi from comment #47)
We are very excited about this update! Any possibility of backporting the update to 22.11?
Hi Kristi, this is a new feature, inluding a new notice, and as such should not be backported to stable versions. This is also Frido as Rmaint of 23.05 decided and then it cannot go into even lower versions (waterfall principle). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Bug 28688 depends on bug 33245, which changed state. Bug 33245 Summary: Add $patron->is_active https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 --- Comment #49 from Fridolin Somers <fridolin.somers@biblibre.com> --- Indeed, lots of changes here. This may introduce bugs in stable versions. 23.11 will be release soon :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/799 Documentation| |Caroline Cyr La Rose contact| | Status|Needs documenting |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28688 Bug 28688 depends on bug 33522, which changed state. Bug 33522 Summary: Optionally skip (in)active patrons when sending membership expiry notices https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33522 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org